You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "David Reiss (JIRA)" <ji...@apache.org> on 2008/11/05 21:31:44 UTC
[jira] Created: (THRIFT-192) TBinaryProtocol In Erlang always reads
booleans as true
TBinaryProtocol In Erlang always reads booleans as true
-------------------------------------------------------
Key: THRIFT-192
URL: https://issues.apache.org/jira/browse/THRIFT-192
Project: Thrift
Issue Type: Bug
Components: Library (Erlang)
Reporter: David Reiss
Title says it all. Fix ready: http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=d86b629
The test code depends on the patches for 126 and 127.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-192) TBinaryProtocol In Erlang always
reads booleans as true
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688832#action_12688832 ]
David Reiss commented on THRIFT-192:
------------------------------------
Because without 126 and 127, the patch doesn't apply. I see you just dropped the test code, but it isn't really appropriate to close the issue until it can be committed.
> TBinaryProtocol In Erlang always reads booleans as true
> -------------------------------------------------------
>
> Key: THRIFT-192
> URL: https://issues.apache.org/jira/browse/THRIFT-192
> Project: Thrift
> Issue Type: Bug
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Fix For: 0.1
>
> Attachments: 0003-THRIFT-192.-erlang-Fix-a-bug-that-caused-bools-to-a.patch
>
>
> Title says it all. Fix ready: http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=d86b629
> The test code depends on the patches for 126 and 127.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-192) TBinaryProtocol In Erlang always
reads booleans as true
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688470#action_12688470 ]
Bryan Duxbury commented on THRIFT-192:
--------------------------------------
Any reason not to commit this patch?
> TBinaryProtocol In Erlang always reads booleans as true
> -------------------------------------------------------
>
> Key: THRIFT-192
> URL: https://issues.apache.org/jira/browse/THRIFT-192
> Project: Thrift
> Issue Type: Bug
> Components: Library (Erlang)
> Reporter: David Reiss
> Attachments: 0003-THRIFT-192.-erlang-Fix-a-bug-that-caused-bools-to-a.patch
>
>
> Title says it all. Fix ready: http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=d86b629
> The test code depends on the patches for 126 and 127.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-192) TBinaryProtocol In Erlang always reads
booleans as true
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Clark closed THRIFT-192.
------------------------------
Resolution: Fixed
Fix Version/s: 0.1
Assignee: David Reiss
In r757870.
> TBinaryProtocol In Erlang always reads booleans as true
> -------------------------------------------------------
>
> Key: THRIFT-192
> URL: https://issues.apache.org/jira/browse/THRIFT-192
> Project: Thrift
> Issue Type: Bug
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Fix For: 0.1
>
> Attachments: 0003-THRIFT-192.-erlang-Fix-a-bug-that-caused-bools-to-a.patch
>
>
> Title says it all. Fix ready: http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=d86b629
> The test code depends on the patches for 126 and 127.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-192) TBinaryProtocol In Erlang always
reads booleans as true
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650872#action_12650872 ]
Todd Lipcon commented on THRIFT-192:
------------------------------------
oof, nice catch... guess we don't use any booleans!
+1
> TBinaryProtocol In Erlang always reads booleans as true
> -------------------------------------------------------
>
> Key: THRIFT-192
> URL: https://issues.apache.org/jira/browse/THRIFT-192
> Project: Thrift
> Issue Type: Bug
> Components: Library (Erlang)
> Reporter: David Reiss
>
> Title says it all. Fix ready: http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=d86b629
> The test code depends on the patches for 126 and 127.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-192) TBinaryProtocol In Erlang always reads
booleans as true
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss closed THRIFT-192.
------------------------------
Resolution: Fixed
> TBinaryProtocol In Erlang always reads booleans as true
> -------------------------------------------------------
>
> Key: THRIFT-192
> URL: https://issues.apache.org/jira/browse/THRIFT-192
> Project: Thrift
> Issue Type: Bug
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Fix For: 0.1
>
> Attachments: 0003-THRIFT-192.-erlang-Fix-a-bug-that-caused-bools-to-a.patch
>
>
> Title says it all. Fix ready: http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=d86b629
> The test code depends on the patches for 126 and 127.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (THRIFT-192) TBinaryProtocol In Erlang always
reads booleans as true
Posted by Eugene Letuchy <el...@facebook.com>.
Looks great to me.
- Eugene
On 1/29/09 4:14 PM, David Reiss (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/THRIFT-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> David Reiss updated THRIFT-192:
> -------------------------------
>
> Attachment: 0003-THRIFT-192.-erlang-Fix-a-bug-that-caused-bools-to-a.patch
>
>> TBinaryProtocol In Erlang always reads booleans as true
>> -------------------------------------------------------
>>
>> Key: THRIFT-192
>> URL: https://issues.apache.org/jira/browse/THRIFT-192
>> Project: Thrift
>> Issue Type: Bug
>> Components: Library (Erlang)
>> Reporter: David Reiss
>> Attachments: 0003-THRIFT-192.-erlang-Fix-a-bug-that-caused-bools-to-a.patch
>>
>>
>> Title says it all. Fix ready: http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=d86b629
>> The test code depends on the patches for 126 and 127.
>
[jira] Updated: (THRIFT-192) TBinaryProtocol In Erlang always reads
booleans as true
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-192:
-------------------------------
Attachment: 0003-THRIFT-192.-erlang-Fix-a-bug-that-caused-bools-to-a.patch
> TBinaryProtocol In Erlang always reads booleans as true
> -------------------------------------------------------
>
> Key: THRIFT-192
> URL: https://issues.apache.org/jira/browse/THRIFT-192
> Project: Thrift
> Issue Type: Bug
> Components: Library (Erlang)
> Reporter: David Reiss
> Attachments: 0003-THRIFT-192.-erlang-Fix-a-bug-that-caused-bools-to-a.patch
>
>
> Title says it all. Fix ready: http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=d86b629
> The test code depends on the patches for 126 and 127.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-192) TBinaryProtocol In Erlang always
reads booleans as true
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688857#action_12688857 ]
Kevin Clark commented on THRIFT-192:
------------------------------------
Doh, must have missed adding the test to svn. I'll reopen and someone who knows what they're doing can reapply properly.
> TBinaryProtocol In Erlang always reads booleans as true
> -------------------------------------------------------
>
> Key: THRIFT-192
> URL: https://issues.apache.org/jira/browse/THRIFT-192
> Project: Thrift
> Issue Type: Bug
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Fix For: 0.1
>
> Attachments: 0003-THRIFT-192.-erlang-Fix-a-bug-that-caused-bools-to-a.patch
>
>
> Title says it all. Fix ready: http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=d86b629
> The test code depends on the patches for 126 and 127.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (THRIFT-192) TBinaryProtocol In Erlang always
reads booleans as true
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss reopened THRIFT-192:
--------------------------------
> TBinaryProtocol In Erlang always reads booleans as true
> -------------------------------------------------------
>
> Key: THRIFT-192
> URL: https://issues.apache.org/jira/browse/THRIFT-192
> Project: Thrift
> Issue Type: Bug
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Fix For: 0.1
>
> Attachments: 0003-THRIFT-192.-erlang-Fix-a-bug-that-caused-bools-to-a.patch
>
>
> Title says it all. Fix ready: http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=d86b629
> The test code depends on the patches for 126 and 127.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.