You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/04/20 13:06:51 UTC
[GitHub] [eventmesh] pandaapo opened a new pull request, #3783: [ISSUE #3725]Not annotated parameter overrides @ParametersAreNonnullByDefault parameter[PravegaCloudEventWriter]
pandaapo opened a new pull request, #3783:
URL: https://github.com/apache/eventmesh/pull/3783
Fixes #3725.
### Motivation
Aoid `Not annotated parameter overrides @ParametersAreNonnullByDefault parameter`.
### Modifications
Add `@Nonnull` or `@Nullable`.
### Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3783: [ISSUE #3725]Not annotated parameter overrides @ParametersAreNonnullByDefault parameter[PravegaCloudEventWriter]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3783:
URL: https://github.com/apache/eventmesh/pull/3783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3783: [ISSUE #3725]Not annotated parameter overrides @ParametersAreNonnullByDefault parameter[PravegaCloudEventWriter]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3783:
URL: https://github.com/apache/eventmesh/pull/3783#issuecomment-1521102736
## [Codecov](https://codecov.io/gh/apache/eventmesh/pull/3783?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3783](https://codecov.io/gh/apache/eventmesh/pull/3783?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f0cd568) into [master](https://codecov.io/gh/apache/eventmesh/commit/2389f5d61407701dfcfc65a364a290789d63c74c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2389f5d) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head f0cd568 differs from pull request most recent head fdc8919. Consider uploading reports for the commit fdc8919 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3783 +/- ##
============================================
- Coverage 13.80% 13.78% -0.02%
Complexity 1291 1291
============================================
Files 571 571
Lines 29154 29146 -8
Branches 2856 2844 -12
============================================
- Hits 4024 4019 -5
+ Misses 24756 24754 -2
+ Partials 374 373 -1
```
| [Impacted Files](https://codecov.io/gh/apache/eventmesh/pull/3783?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ntmesh/runtime/util/EventMeshCloudEventWriter.java](https://codecov.io/gh/apache/eventmesh/pull/3783?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3V0aWwvRXZlbnRNZXNoQ2xvdWRFdmVudFdyaXRlci5qYXZh) | `100.00% <ø> (ø)` | |
| [.../knative/cloudevent/impl/KnativeMessageWriter.java](https://codecov.io/gh/apache/eventmesh/pull/3783?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLWtuYXRpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9zdG9yYWdlL2tuYXRpdmUvY2xvdWRldmVudC9pbXBsL0tuYXRpdmVNZXNzYWdlV3JpdGVyLmphdmE=) | `61.11% <0.00%> (ø)` | |
| [...torage/pravega/client/PravegaCloudEventWriter.java](https://codecov.io/gh/apache/eventmesh/pull/3783?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UtcGx1Z2luL2V2ZW50bWVzaC1zdG9yYWdlLXByYXZlZ2Evc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9zdG9yYWdlL3ByYXZlZ2EvY2xpZW50L1ByYXZlZ2FDbG91ZEV2ZW50V3JpdGVyLmphdmE=) | `0.00% <ø> (ø)` | |
... and [7 files with indirect coverage changes](https://codecov.io/gh/apache/eventmesh/pull/3783/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org