You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@drill.apache.org by bo...@apache.org on 2020/07/08 15:09:25 UTC
[drill] branch master updated: DRILL-7764: Cleanup warning messages
in GuavaPatcher class (#2093)
This is an automated email from the ASF dual-hosted git repository.
bohdan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/drill.git
The following commit(s) were added to refs/heads/master by this push:
new 792d0c2 DRILL-7764: Cleanup warning messages in GuavaPatcher class (#2093)
792d0c2 is described below
commit 792d0c2220e6e16223cf9ad40482ed930e77c9de
Author: Bohdan Kazydub <38...@users.noreply.github.com>
AuthorDate: Wed Jul 8 18:09:13 2020 +0300
DRILL-7764: Cleanup warning messages in GuavaPatcher class (#2093)
* DRILL-7764: Cleanup warning messages in GuavaPatcher class
---
.../main/java/org/apache/drill/common/util/GuavaPatcher.java | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/common/src/main/java/org/apache/drill/common/util/GuavaPatcher.java b/common/src/main/java/org/apache/drill/common/util/GuavaPatcher.java
index a618d05..0a0a7b2 100644
--- a/common/src/main/java/org/apache/drill/common/util/GuavaPatcher.java
+++ b/common/src/main/java/org/apache/drill/common/util/GuavaPatcher.java
@@ -73,10 +73,15 @@ public class GuavaPatcher {
logger.info("Google's Stopwatch patched for old HBase Guava version.");
} catch (Exception e) {
- logger.warn("Unable to patch Guava classes.", e);
+ logUnableToPatchException(e);
}
}
+ private static void logUnableToPatchException(Exception e) {
+ logger.warn("Unable to patch Guava classes: {}", e.getMessage());
+ logger.debug("Exception:", e);
+ }
+
private static void patchCloseables() {
try {
ClassPool cp = getClassPool();
@@ -93,7 +98,7 @@ public class GuavaPatcher {
logger.info("Google's Closeables patched for old HBase Guava version.");
} catch (Exception e) {
- logger.warn("Unable to patch Guava classes.", e);
+ logUnableToPatchException(e);
}
}
@@ -191,7 +196,7 @@ public class GuavaPatcher {
cc.toClass();
logger.info("Google's Preconditions were patched to hold new methods.");
} catch (Exception e) {
- logger.warn("Unable to patch Guava classes.", e);
+ logUnableToPatchException(e);
}
}