[jira] Commented: (BSF-14) BSFManager should use final fields where possible

["Rony G. Flatscher (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BSF-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598575#action_12598575 ] 

Rony G. Flatscher commented on BSF-14:
--------------------------------------

In principle I would agree, of course.

The reason why I have never tackled this was the impossibility of overviewing how BSF has been deployed. In theory it is possible that some applications would take advantage of these fields not being final. Therefore (once burnt, always shy) I have gone with the simple, but extremely imporant rule: "never change a running program" (and in this case a framework, unless there are reasons, that make it acceptable that currently deployed applications break).

In this particular case I might be way too wary. 

> BSFManager should use final fields where possible
> -------------------------------------------------
>
>                 Key: BSF-14
>                 URL: https://issues.apache.org/jira/browse/BSF-14
>             Project: BSF
>          Issue Type: Bug
>    Affects Versions: BSF-2.4
>            Reporter: Sebb
>            Priority: Minor
>
> BSFManager should use final fields where possible to avoid inadvertent changes.
> For example, version should be final. Likewise the HashTables.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org