You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/12 10:38:50 UTC
[GitHub] [doris] zbtzbtzbt opened a new pull request, #15876: [fix] remove echo database passwd
zbtzbtzbt opened a new pull request, #15876:
URL: https://github.com/apache/doris/pull/15876
# Proposed changes
echo password is dangerous, we should delete it.
## Problem summary
1. remove echo passwd
2. add some necessary information (e.g. add timer for data load)
3. remove some redundant code
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Does it need to update dependencies:
- [ ] Yes
- [ ] No
6. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zbtzbtzbt commented on pull request #15876: [fix](terminal) remove echo database passwd
Posted by GitBox <gi...@apache.org>.
zbtzbtzbt commented on PR #15876:
URL: https://github.com/apache/doris/pull/15876#issuecomment-1380183534
use shfmt to format.
e.g.
`shfmt -w tools/ssb-tools/bin/load-ssb-data.sh`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zbtzbtzbt commented on a diff in pull request #15876: [fix](terminal) remove echo database passwd
Posted by GitBox <gi...@apache.org>.
zbtzbtzbt commented on code in PR #15876:
URL: https://github.com/apache/doris/pull/15876#discussion_r1068180259
##########
tools/ssb-tools/bin/gen-ssb-data.sh:
##########
@@ -126,7 +126,7 @@ date
cd -
# move data to $SSB_DATA_DIR
-mv "${SSB_DBGEN_DIR}"/*.tbl* "${SSB_DATA_DIR}/"
+mv "${SSB_DBGEN_DIR}"*.tbl* "${SSB_DATA_DIR}/"
Review Comment:
ok, good idea, Thanks for your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15876: [fix](terminal) remove echo database passwd
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15876:
URL: https://github.com/apache/doris/pull/15876#issuecomment-1380156336
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3901582592") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' found no issues.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- tools/ssb-tools/bin/create-ssb-tables.sh.orig
+++ tools/ssb-tools/bin/create-ssb-tables.sh
--- tools/ssb-tools/bin/load-ssb-data.sh.orig
+++ tools/ssb-tools/bin/load-ssb-data.sh
@@ -281,4 +281,4 @@
end_time=$(date +%s)
echo "End time: $(date)"
-echo "Finish load ssb data, Time taken: $((end_time-start_time)) seconds"
+echo "Finish load ssb data, Time taken: $((end_time - start_time)) seconds"
--- tools/tpch-tools/bin/create-tpch-tables.sh.orig
+++ tools/tpch-tools/bin/create-tpch-tables.sh
--- tools/tpch-tools/bin/load-tpch-data.sh.orig
+++ tools/tpch-tools/bin/load-tpch-data.sh
@@ -236,4 +236,4 @@
end_time=$(date +%s)
echo "End time: $(date)"
-echo "Finish load tpch data, Time taken: $((end_time-start_time)) seconds"
+echo "Finish load tpch data, Time taken: $((end_time - start_time)) seconds"
--- tools/tpch-tools/bin/run-tpch-queries.sh.orig
+++ tools/tpch-tools/bin/run-tpch-queries.sh
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15876: [fix](terminal) remove echo database passwd
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15876:
URL: https://github.com/apache/doris/pull/15876#issuecomment-1381410124
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener merged pull request #15876: [fix](terminal) remove echo database passwd
Posted by GitBox <gi...@apache.org>.
jackwener merged PR #15876:
URL: https://github.com/apache/doris/pull/15876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15876: [fix](terminal) remove echo database passwd
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15876:
URL: https://github.com/apache/doris/pull/15876#issuecomment-1381549154
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15876: [fix] remove echo database passwd
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15876:
URL: https://github.com/apache/doris/pull/15876#issuecomment-1380132618
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3901438284") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' found no issues.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- tools/ssb-tools/bin/create-ssb-tables.sh.orig
+++ tools/ssb-tools/bin/create-ssb-tables.sh
--- tools/ssb-tools/bin/load-ssb-data.sh.orig
+++ tools/ssb-tools/bin/load-ssb-data.sh
@@ -281,4 +281,4 @@
end_time=$(date +%s)
echo "End time: $(date)"
-echo "Finish load ssb data, Time taken: $((end_time-start_time)) seconds"
+echo "Finish load ssb data, Time taken: $((end_time - start_time)) seconds"
--- tools/tpch-tools/bin/create-tpch-tables.sh.orig
+++ tools/tpch-tools/bin/create-tpch-tables.sh
--- tools/tpch-tools/bin/load-tpch-data.sh.orig
+++ tools/tpch-tools/bin/load-tpch-data.sh
@@ -236,4 +236,4 @@
end_time=$(date +%s)
echo "End time: $(date)"
-echo "Finish load tpch data, Time taken: $((end_time-start_time)) seconds"
+echo "Finish load tpch data, Time taken: $((end_time - start_time)) seconds"
--- tools/tpch-tools/bin/run-tpch-queries.sh.orig
+++ tools/tpch-tools/bin/run-tpch-queries.sh
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #15876: [fix](terminal) remove echo database passwd
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #15876:
URL: https://github.com/apache/doris/pull/15876#discussion_r1068146932
##########
tools/ssb-tools/bin/gen-ssb-data.sh:
##########
@@ -126,7 +126,7 @@ date
cd -
# move data to $SSB_DATA_DIR
-mv "${SSB_DBGEN_DIR}"/*.tbl* "${SSB_DATA_DIR}/"
+mv "${SSB_DBGEN_DIR}"*.tbl* "${SSB_DATA_DIR}/"
Review Comment:
`"${SSB_DBGEN_DIR}"*.tbl*` looks weird. I think the original one is better. Maybe we should remove the `/` from the assignment of `SSB_DBGEN_DIR` in [#L32](https://github.com/apache/doris/blob/f8f4cba64f8e75910b0a447c1813a2203e5c99b4/tools/ssb-tools/bin/gen-ssb-data.sh#L32).
##########
tools/ssb-tools/bin/gen-ssb-data.sh:
##########
@@ -126,7 +126,7 @@ date
cd -
# move data to $SSB_DATA_DIR
-mv "${SSB_DBGEN_DIR}"/*.tbl* "${SSB_DATA_DIR}/"
+mv "${SSB_DBGEN_DIR}"*.tbl* "${SSB_DATA_DIR}/"
# check data
-du -sh "${SSB_DATA_DIR}"/*.tbl*
+du -sh "${SSB_DATA_DIR}"*.tbl*
Review Comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15876: [fix](terminal) remove echo database passwd
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15876:
URL: https://github.com/apache/doris/pull/15876#issuecomment-1381410043
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #15876: [fix](terminal) remove echo database passwd
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #15876:
URL: https://github.com/apache/doris/pull/15876#issuecomment-1381411756
Hi @zbtzbtzbt , would you like to rebase the branch master to re-trigger the checks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zbtzbtzbt commented on pull request #15876: [fix](terminal) remove echo database passwd
Posted by GitBox <gi...@apache.org>.
zbtzbtzbt commented on PR #15876:
URL: https://github.com/apache/doris/pull/15876#issuecomment-1381542087
> Hi @zbtzbtzbt , would you like to rebase the branch on master to re-trigger the checks?
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org