You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Bhathiya <no...@github.com> on 2014/06/17 21:46:40 UTC
[jclouds-labs-google] GCS sketch with authentication (#28)
Setup GCS provider with oatuh module in jclouds-labs-google for authentication
You can merge this Pull Request by running:
git pull https://github.com/hsbhathiya/jclouds-labs-google Authstream
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-google/pull/28
-- Commit Summary --
* GCS sketch with authentication
-- File Changes --
A google-cloud-storage/README.md (46)
A google-cloud-storage/pom.xml (126)
A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/GoogleCloudStorageApi.java (29)
A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/GoogleCloudStorageApiMetadata.java (93)
A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/config/GoogleCloudStorageHttpApiModule.java (31)
A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/config/GoogleCloudStorageParserModule.java (49)
A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/config/OAuthModuleWithoutTypeAdapters.java (49)
A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/reference/GoogleCloudStorageConstants.java (50)
A google-cloud-storage/src/main/resources/META-INF/services/org.jclouds.apis.ApiMetadata (19)
A google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/GoogleCloudStorageApiMetadataTest.java (31)
A google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/GoogleCloudStorageAuthenticatedRestContextLiveTest.java (36)
M pom.xml (6)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/28.patch
https://github.com/jclouds/jclouds-labs-google/pull/28.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #80](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/80/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28#issuecomment-46378987
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by Andrew Gaul <no...@github.com>.
@hsbhathiya Did you look at the Checkstyle violations?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28#issuecomment-46374451
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #78](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/78/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28#issuecomment-46375501
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #79](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/79/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28#issuecomment-46376843
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by Andrew Gaul <no...@github.com>.
I addressed some minor formatting nits and pushed to master. Great work @hsbhathiya ! I look forward the subsequent pull requests and my apologies for the delay in reviewing your pull requests.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28#issuecomment-46379738
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by Andrew Gaul <no...@github.com>.
Also some of the Java soure files have trailing whitespace can you remove that as well?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28#issuecomment-46367510
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #77](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/77/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28#issuecomment-46374038
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-google-pull-requests #75](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/75/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28#issuecomment-46356479
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by Andrew Gaul <no...@github.com>.
> +
> +2. Extract only the pk and remove passphrase
> + openssl rsa -in <my_keystore>.pem -out <my_key>.pem
> +
> +The last file (<my_key>.pem) should contain the pk that needs to be passed to `ContextBuilder.credential()` for the provider `google-cloud-storage`.
> +
> +
> +Running the live tests:
> +---------------------------------------------------------------
> +
> +1 Place the following in your ~/.m2/settings.xml in a profile enabled when live:
> +```
> + <test.google-cloud-storage.identity>Email address associated with service account</test.google-cloud-storage.identity>
> + <test.google-cloud-storage.credential>-----BEGIN RSA PRIVATE KEY-----
> +MIICXgIBAAKBgQRRbRqVDtJLN1MO/xJoKqZuphDeBh5jIKueW3aNIiWs1XFcct+h
> +-- this text is literally from your <my_key>.pem
Can you move this text above the property inside an XML comment <!-- --> ?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28/files#r13886154
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by Andrew Gaul <no...@github.com>.
> @@ -0,0 +1,43 @@
> +jclouds Google Cloud Storage Provider
> +===========================================================
> +<!-- Make sure both Google Cloud Storage and Google Cloud Storage JSON API are enabled for the project
Most of the README.md is commented out, check out the rendered view of this file.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28/files#r13890224
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by Andrew Gaul <no...@github.com>.
> @@ -17,7 +17,8 @@
> limitations under the License.
>
> -->
> -<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
Can you remove these reformattings?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28/files#r13886069
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by Andrew Gaul <no...@github.com>.
Closed #28.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28#event-132436267
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by Andrew Gaul <no...@github.com>.
@hsbhathiya this looks really good! Can you address the Checkstyle violations that the following command reports: `mvn checkstyle:checkstyle -Dcheckstyle.output.file=/dev/stdout -Dcheckstyle.output.format=plain` ? Also can you include the JIRA issue JCLOUDS-458 in the commit message and all subsequent commits so we tag this properly? Otherwise this looks ready to merge!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28#issuecomment-46367263
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1009](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1009/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28#issuecomment-46376729
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1007](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1007/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28#issuecomment-46373863
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1011](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1011/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28#issuecomment-46378836
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by Andrew Gaul <no...@github.com>.
> +```
> + <test.google-cloud-storage.identity>Email address associated with service account</test.google-cloud-storage.identity>
> + <test.google-cloud-storage.credential>-----BEGIN RSA PRIVATE KEY-----
> +MIICXgIBAAKBgQRRbRqVDtJLN1MO/xJoKqZuphDeBh5jIKueW3aNIiWs1XFcct+h
> +-- this text is literally from your <my_key>.pem
> +aH7xmpHSTbbXmQkuuv+z8EKijigprd/FoJpTX1f5/R+4wQ==
> +-----END RSA PRIVATE KEY-----</test.google-cloud-storage.credential>
> + <test.google-cloud-storage.bucket>YOUR_BUCKET_NAME</test.google-cloud-storage.bucket>
> + </properties>
> +```
> +Example identity :- 123451234-abcd01234efgh@developer.gserviceaccount.com (NUMERIC_PREFIX-ALPHANEUMERIC_SUFFIX@developer.gserviceaccount.com)
> +
> +2 mvn integration-test -pl google-cloud-storage -Plive
> +
> +
> +
Remove trailing newlines.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28/files#r13886091
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1004](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1004/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28#issuecomment-46356325
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by Andrew Gaul <no...@github.com>.
> +
> +A.
> +
> +1. Convert the p12 file into pem format (it will ask for the keystore password, which is usually "notasecret"):
> + openssl pkcs12 -in <my_keystore>.p12 -out <my_keystore>.pem -nodes
> +
> +2. Extract only the pk and remove passphrase
> + openssl rsa -in <my_keystore>.pem -out <my_key>.pem
> +
> +The last file (<my_key>.pem) should contain the pk that needs to be passed to `ContextBuilder.credential()` for the provider `google-cloud-storage`.
> +
> +
> +Running the live tests:
> +---------------------------------------------------------------
> +
> +1 Place the following in your ~/.m2/settings.xml in a profile enabled when live:
Should these be 1. and 2. to render like the other bullets?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28/files#r13886316
Re: [jclouds-labs-google] GCS sketch with authentication (#28)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-google #1008](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1008/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/28#issuecomment-46375345