You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org> on 2009/12/10 23:42:18 UTC
[jira] Created: (HADOOP-6432) Statistics support in FileContext
Statistics support in FileContext
---------------------------------
Key: HADOOP-6432
URL: https://issues.apache.org/jira/browse/HADOOP-6432
Project: Hadoop Common
Issue Type: New Feature
Reporter: Jitendra Nath Pandey
Assignee: Jitendra Nath Pandey
FileContext should have API to get statistics from underlying file systems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6432) Statistics support in FileContext
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6432:
-----------------------------------------
Attachment: (was: HDFS-899.5.patch)
> Statistics support in FileContext
> ---------------------------------
>
> Key: HADOOP-6432
> URL: https://issues.apache.org/jira/browse/HADOOP-6432
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6432.1.patch, HADOOP-6432.2.patch, HADOOP-6432.3.patch, HADOOP-6432.4.patch
>
>
> FileContext should have API to get statistics from underlying file systems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6432) Statistics support in FileContext
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792246#action_12792246 ]
Hadoop QA commented on HADOOP-6432:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12428368/HADOOP-6432.4.patch
against trunk revision 891511.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 7 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/219/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/219/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/219/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/219/console
This message is automatically generated.
> Statistics support in FileContext
> ---------------------------------
>
> Key: HADOOP-6432
> URL: https://issues.apache.org/jira/browse/HADOOP-6432
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6432.1.patch, HADOOP-6432.2.patch, HADOOP-6432.3.patch, HADOOP-6432.4.patch
>
>
> FileContext should have API to get statistics from underlying file systems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6432) Statistics support in FileContext
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6432:
-----------------------------------------
Attachment: HADOOP-6432.1.patch
> Statistics support in FileContext
> ---------------------------------
>
> Key: HADOOP-6432
> URL: https://issues.apache.org/jira/browse/HADOOP-6432
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6432.1.patch
>
>
> FileContext should have API to get statistics from underlying file systems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6432) Statistics support in FileContext
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6432:
-----------------------------------------
Attachment: HADOOP-6432.2.patch
> Statistics support in FileContext
> ---------------------------------
>
> Key: HADOOP-6432
> URL: https://issues.apache.org/jira/browse/HADOOP-6432
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6432.1.patch, HADOOP-6432.2.patch
>
>
> FileContext should have API to get statistics from underlying file systems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6432) Statistics support in FileContext
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6432:
-----------------------------------------
Status: Patch Available (was: Open)
HADOOP-6432.4.patch submitted for hudson tests.
> Statistics support in FileContext
> ---------------------------------
>
> Key: HADOOP-6432
> URL: https://issues.apache.org/jira/browse/HADOOP-6432
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6432.1.patch, HADOOP-6432.2.patch, HADOOP-6432.3.patch, HADOOP-6432.4.patch
>
>
> FileContext should have API to get statistics from underlying file systems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6432) Statistics support in FileContext
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6432:
-----------------------------------------
Status: Patch Available (was: Open)
HADOOP-6432.3.patch submitted for hudson tests.
> Statistics support in FileContext
> ---------------------------------
>
> Key: HADOOP-6432
> URL: https://issues.apache.org/jira/browse/HADOOP-6432
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6432.1.patch, HADOOP-6432.2.patch, HADOOP-6432.3.patch
>
>
> FileContext should have API to get statistics from underlying file systems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6432) Statistics support in FileContext
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792188#action_12792188 ]
Hadoop QA commented on HADOOP-6432:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12428353/HADOOP-6432.3.patch
against trunk revision 891511.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 7 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/218/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/218/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/218/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/218/console
This message is automatically generated.
> Statistics support in FileContext
> ---------------------------------
>
> Key: HADOOP-6432
> URL: https://issues.apache.org/jira/browse/HADOOP-6432
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6432.1.patch, HADOOP-6432.2.patch, HADOOP-6432.3.patch
>
>
> FileContext should have API to get statistics from underlying file systems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6432) Statistics support in FileContext
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6432:
-----------------------------------------
Attachment: HDFS-899.5.patch
> Statistics support in FileContext
> ---------------------------------
>
> Key: HADOOP-6432
> URL: https://issues.apache.org/jira/browse/HADOOP-6432
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6432.1.patch, HADOOP-6432.2.patch, HADOOP-6432.3.patch, HADOOP-6432.4.patch, HDFS-899.5.patch
>
>
> FileContext should have API to get statistics from underlying file systems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6432) Statistics support in FileContext
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6432:
-----------------------------------------
Attachment: HADOOP-6432.3.patch
A few points regarding the patch:
1. The Statistics are statically stored inside AbstractFileSystem in a map that is keyed on URI. Only scheme and authority part of the URI are used.
2. API are added to FileContext to get the statistics.
3. FileContext.getAllStatistics returns a map of URI and statistics, but the URI key contains only scheme and authority.
> Statistics support in FileContext
> ---------------------------------
>
> Key: HADOOP-6432
> URL: https://issues.apache.org/jira/browse/HADOOP-6432
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6432.1.patch, HADOOP-6432.2.patch, HADOOP-6432.3.patch
>
>
> FileContext should have API to get statistics from underlying file systems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6432) Statistics support in FileContext
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6432:
-----------------------------------------
Attachment: HADOOP-6432.4.patch
New patch fixing the javadoc warning.
> Statistics support in FileContext
> ---------------------------------
>
> Key: HADOOP-6432
> URL: https://issues.apache.org/jira/browse/HADOOP-6432
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6432.1.patch, HADOOP-6432.2.patch, HADOOP-6432.3.patch, HADOOP-6432.4.patch
>
>
> FileContext should have API to get statistics from underlying file systems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6432) Statistics support in FileContext
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791534#action_12791534 ]
Suresh Srinivas commented on HADOOP-6432:
-----------------------------------------
# Can you please add a brief description of what the patch does
# FileContext.java - remove Options.Rename import
# All FileContext.java public methods added should have javadoc
# FileContext.getStatistics() - add more description to the method that only scheme and authority is used for looking up the file system.
# FileContext.getAllStatistics() - should not throw URISyntaxException.
# AbstractFileSystem.java - IdentifyHashMap import is unused
# AbstractFileSystem.STATISTICS_TABLE declaration exceeds 80 columns.
# AbstractFileSystem.getStatistics() - use getUri() method get the URI with scheme and authority.
# AbstractFileSystem and FileContext printStatistics() prints the statistics using System.out.println. Not sure where this is used and if we need it.
# AbstractFileSystem.getAllStatistics - initialize statsMap size to that of STATISTICS_TABLE. Also it is a good idea to define copy constructor in Statistics class.
# Is it a good idea to have FcStatisticsTest that includes common logic and have a subclass for TestLocalFcStatistics, TestHdfsFcStatistics etc? Could the base test use FileContextTestHelper and avoid using /tmp as directory to create tests. Also code could be reused by adding a method checkStatistics(int expectedBytesRead, int expectedBytesWritten, Statistics s)
> Statistics support in FileContext
> ---------------------------------
>
> Key: HADOOP-6432
> URL: https://issues.apache.org/jira/browse/HADOOP-6432
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6432.1.patch, HADOOP-6432.2.patch
>
>
> FileContext should have API to get statistics from underlying file systems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6432) Statistics support in FileContext
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6432:
-----------------------------------------
Status: Open (was: Patch Available)
> Statistics support in FileContext
> ---------------------------------
>
> Key: HADOOP-6432
> URL: https://issues.apache.org/jira/browse/HADOOP-6432
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6432.1.patch, HADOOP-6432.2.patch, HADOOP-6432.3.patch, HADOOP-6432.4.patch
>
>
> FileContext should have API to get statistics from underlying file systems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6432) Statistics support in FileContext
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6432:
-----------------------------------------
Status: Open (was: Patch Available)
> Statistics support in FileContext
> ---------------------------------
>
> Key: HADOOP-6432
> URL: https://issues.apache.org/jira/browse/HADOOP-6432
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-6432.1.patch, HADOOP-6432.2.patch, HADOOP-6432.3.patch
>
>
> FileContext should have API to get statistics from underlying file systems.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.