You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/08/25 02:00:49 UTC

[GitHub] [yunikorn-site] yangwwei opened a new pull request, #180: [YUNIKORN-1293] Add custom redirects to the current version doc

yangwwei opened a new pull request, #180:
URL: https://github.com/apache/yunikorn-site/pull/180

   Docusaurus hides the version number in the URL for the latest versions, e.g right now our latest version is 1.0.0, but http://localhost:3000/docs/1.0.0 gives a 404. Ideally, we should make have an accessible URL for this version as well.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yunikorn-site] wilfred-s commented on pull request #180: [YUNIKORN-1293] Add custom redirects to the current version doc

Posted by GitBox <gi...@apache.org>.
wilfred-s commented on PR #180:
URL: https://github.com/apache/yunikorn-site/pull/180#issuecomment-1226804595

   This is not a scalable or maintainable solution. It breaks the release procedure.
   
   Not sure why YuniKorn needs to comply with this rule for a specific version of documentation when there is no version information in any of the volcano links published as part of the [Spark 3.3 documentation](https://spark.apache.org/docs/latest/running-on-kubernetes.html#using-volcano-as-customized-scheduler-for-spark-on-kubernetes):
   * https://volcano.sh/en/docs/podgroup/
   * https://volcano.sh/en/docs/podgroup/#example
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yunikorn-site] wilfred-s commented on pull request #180: [YUNIKORN-1293] Add custom redirects to the current version doc

Posted by GitBox <gi...@apache.org>.
wilfred-s commented on PR #180:
URL: https://github.com/apache/yunikorn-site/pull/180#issuecomment-1226820265

   We'll leave it in place for the next days, release 1.1 is due next week and should include a new versioned release for the docs to be created. Before we can commit that update this change will most likely need to be rolled back to not break our docs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yunikorn-site] yangwwei commented on pull request #180: [YUNIKORN-1293] Add custom redirects to the current version doc

Posted by GitBox <gi...@apache.org>.
yangwwei commented on PR #180:
URL: https://github.com/apache/yunikorn-site/pull/180#issuecomment-1226817499

   > This is not a scalable or maintainable solution. It breaks the release procedure.
   > 
   > Not sure why YuniKorn needs to comply with this rule for a specific version of documentation when there is no version information in any of the volcano links published as part of the [Spark 3.3 documentation](https://spark.apache.org/docs/latest/running-on-kubernetes.html#using-volcano-as-customized-scheduler-for-spark-on-kubernetes):
   > 
   > * https://volcano.sh/en/docs/podgroup/
   > * https://volcano.sh/en/docs/podgroup/#example
   
   This is a very good point. Let's move the discussion to the Spark community: https://github.com/apache/spark/pull/37622. This PR is not a sustainable solution, it's gonna break when we release a new version. We can revert this once we reach a consensus there.  BTW, I've spent hours and this is the best solution so far that can work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [yunikorn-site] yangwwei merged pull request #180: [YUNIKORN-1293] Add custom redirects to the current version doc

Posted by GitBox <gi...@apache.org>.
yangwwei merged PR #180:
URL: https://github.com/apache/yunikorn-site/pull/180


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org