You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/08/28 23:01:18 UTC
Review Request: Fix for -Wall -Werror build regression on Linux
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6812/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
This fixes the build on linux, I've tested this out on centos.
Diffs
-----
src/flags/flags.hpp aca3be5
src/java/jni/convert.cpp 075ea58
src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 2ee8c83
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 3095f9b
src/jvm/jvm.hpp 7e4e433
src/jvm/jvm.cpp a916548
src/linux/fs.cpp 8bcc2cd
src/linux/proc.cpp 7af7802
src/master/drf_sorter.hpp b8ea828
src/slave/lxc_isolation_module.cpp de2a3fd
src/tests/allocator_tests.cpp 84c347e
src/tests/proc_tests.cpp 035db70
src/zookeeper/zookeeper.cpp ba64a82
third_party/boost-1.37.0.tar.gz 9d1b639
third_party/boost-1.51.0.tar.gz PRE-CREATION
third_party/libprocess/include/process/event.hpp a722c4a
third_party/libprocess/include/process/filter.hpp 43e4ce7
third_party/libprocess/include/stout/foreach.hpp 4b90c21
third_party/libprocess/src/encoder.hpp ac4886e
third_party/libprocess/third_party/boost-1.37.0.tar.gz 0045b62
third_party/libprocess/third_party/boost-1.51.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/versions.am 812b2d6
third_party/versions.am 15dc524
Diff: https://reviews.apache.org/r/6812/diff/
Testing
-------
built on mac and linux (centos)
Thanks,
Ben Mahler
Re: Review Request: Fix for -Wall -Werror build regression on Linux
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6812/
-----------------------------------------------------------
(Updated Aug. 30, 2012, 5:06 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Binary patch attached since reviewboard doesn't keep the binary portion of the patch.
Description
-------
This fixes the build on linux, I've tested this out on centos.
Note that this upgrades our boost version as well :)
Diffs
-----
src/flags/flags.hpp aca3be5
src/java/jni/convert.cpp 075ea58
src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 2ee8c83
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 3095f9b
src/jvm/jvm.hpp 7e4e433
src/jvm/jvm.cpp a916548
src/linux/fs.cpp 8bcc2cd
src/linux/proc.cpp 7af7802
src/master/drf_sorter.hpp b8ea828
src/slave/lxc_isolation_module.cpp de2a3fd
src/tests/allocator_tests.cpp 84c347e
src/tests/proc_tests.cpp 035db70
src/zookeeper/zookeeper.cpp ba64a82
third_party/boost-1.37.0.tar.gz 9d1b639c8af024a8c3af8635bb921e6447d788b7
third_party/boost-1.51.0.tar.gz PRE-CREATION
third_party/libprocess/include/process/event.hpp a722c4a
third_party/libprocess/include/process/filter.hpp 43e4ce7
third_party/libprocess/include/stout/foreach.hpp 4b90c21
third_party/libprocess/src/encoder.hpp ac4886e
third_party/libprocess/third_party/boost-1.37.0.tar.gz 0045b6247ca83b8c0839affd793b18306eb3ae97
third_party/libprocess/third_party/boost-1.51.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/versions.am 812b2d6
third_party/versions.am 15dc524
Diff: https://reviews.apache.org/r/6812/diff/
Testing
-------
make check on mac and linux (centos)
Thanks,
Ben Mahler
Re: Review Request: Fix for -Wall -Werror build regression on Linux
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6812/
-----------------------------------------------------------
(Updated Aug. 30, 2012, 5:05 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
This fixes the build on linux, I've tested this out on centos.
Note that this upgrades our boost version as well :)
Diffs (updated)
-----
src/flags/flags.hpp aca3be5
src/java/jni/convert.cpp 075ea58
src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 2ee8c83
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 3095f9b
src/jvm/jvm.hpp 7e4e433
src/jvm/jvm.cpp a916548
src/linux/fs.cpp 8bcc2cd
src/linux/proc.cpp 7af7802
src/master/drf_sorter.hpp b8ea828
src/slave/lxc_isolation_module.cpp de2a3fd
src/tests/allocator_tests.cpp 84c347e
src/tests/proc_tests.cpp 035db70
src/zookeeper/zookeeper.cpp ba64a82
third_party/boost-1.37.0.tar.gz 9d1b639c8af024a8c3af8635bb921e6447d788b7
third_party/boost-1.51.0.tar.gz PRE-CREATION
third_party/libprocess/include/process/event.hpp a722c4a
third_party/libprocess/include/process/filter.hpp 43e4ce7
third_party/libprocess/include/stout/foreach.hpp 4b90c21
third_party/libprocess/src/encoder.hpp ac4886e
third_party/libprocess/third_party/boost-1.37.0.tar.gz 0045b6247ca83b8c0839affd793b18306eb3ae97
third_party/libprocess/third_party/boost-1.51.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/versions.am 812b2d6
third_party/versions.am 15dc524
Diff: https://reviews.apache.org/r/6812/diff/
Testing
-------
make check on mac and linux (centos)
Thanks,
Ben Mahler
Re: Review Request: Fix for -Wall -Werror build regression on Linux
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6812/
-----------------------------------------------------------
(Updated Aug. 29, 2012, 9:13 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
patch generated with 'git diff --binary' to include binary diffs
Description
-------
This fixes the build on linux, I've tested this out on centos.
Note that this upgrades our boost version as well :)
Diffs (updated)
-----
src/flags/flags.hpp aca3be5
src/java/jni/convert.cpp 075ea58
src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 2ee8c83
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 3095f9b
src/jvm/jvm.hpp 7e4e433
src/jvm/jvm.cpp a916548
src/linux/fs.cpp 8bcc2cd
src/linux/proc.cpp 7af7802
src/master/drf_sorter.hpp b8ea828
src/slave/lxc_isolation_module.cpp de2a3fd
src/tests/allocator_tests.cpp 84c347e
src/tests/proc_tests.cpp 035db70
src/zookeeper/zookeeper.cpp ba64a82
third_party/boost-1.37.0.tar.gz 9d1b639c8af024a8c3af8635bb921e6447d788b7
third_party/boost-1.51.0.tar.gz PRE-CREATION
third_party/libprocess/include/process/event.hpp a722c4a
third_party/libprocess/include/process/filter.hpp 43e4ce7
third_party/libprocess/include/stout/foreach.hpp 4b90c21
third_party/libprocess/src/encoder.hpp ac4886e
third_party/libprocess/third_party/boost-1.37.0.tar.gz 0045b6247ca83b8c0839affd793b18306eb3ae97
third_party/libprocess/third_party/boost-1.51.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/versions.am 812b2d6
third_party/versions.am 15dc524
Diff: https://reviews.apache.org/r/6812/diff/
Testing
-------
make check on mac and linux (centos)
Thanks,
Ben Mahler
Re: Review Request: Fix for -Wall -Werror build regression on Linux
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6812/
-----------------------------------------------------------
(Updated Aug. 29, 2012, 5:41 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
updated with jie's bugfix from: https://reviews.apache.org/r/6826
Description
-------
This fixes the build on linux, I've tested this out on centos.
Note that this upgrades our boost version as well :)
Diffs (updated)
-----
src/flags/flags.hpp aca3be5
src/java/jni/convert.cpp 075ea58
src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 2ee8c83
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 3095f9b
src/jvm/jvm.hpp 7e4e433
src/jvm/jvm.cpp a916548
src/linux/fs.cpp 8bcc2cd
src/linux/proc.cpp 7af7802
src/master/drf_sorter.hpp b8ea828
src/slave/lxc_isolation_module.cpp de2a3fd
src/tests/allocator_tests.cpp 84c347e
src/tests/proc_tests.cpp 035db70
src/zookeeper/zookeeper.cpp ba64a82
third_party/boost-1.37.0.tar.gz 9d1b639
third_party/boost-1.51.0.tar.gz PRE-CREATION
third_party/libprocess/include/process/event.hpp a722c4a
third_party/libprocess/include/process/filter.hpp 43e4ce7
third_party/libprocess/include/stout/foreach.hpp 4b90c21
third_party/libprocess/src/encoder.hpp ac4886e
third_party/libprocess/third_party/boost-1.37.0.tar.gz 0045b62
third_party/libprocess/third_party/boost-1.51.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/versions.am 812b2d6
third_party/versions.am 15dc524
Diff: https://reviews.apache.org/r/6812/diff/
Testing (updated)
-------
make check on mac and linux (centos)
Thanks,
Ben Mahler
Re: Review Request: Fix for -Wall -Werror build regression on Linux
Posted by Ben Mahler <be...@gmail.com>.
> On Aug. 29, 2012, 5:12 p.m., Jie Yu wrote:
> > src/linux/fs.cpp, line 40
> > <https://reviews.apache.org/r/6812/diff/2/?file=146877#file146877line40>
> >
> > Here, probably you can look at my fix
> > https://reviews.apache.org/r/6826/
> >
> > It is a bug (typo).
looking now
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6812/#review10846
-----------------------------------------------------------
On Aug. 28, 2012, 9:20 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6812/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2012, 9:20 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This fixes the build on linux, I've tested this out on centos.
>
> Note that this upgrades our boost version as well :)
>
>
> Diffs
> -----
>
> src/flags/flags.hpp aca3be5
> src/java/jni/convert.cpp 075ea58
> src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 2ee8c83
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 3095f9b
> src/jvm/jvm.hpp 7e4e433
> src/jvm/jvm.cpp a916548
> src/linux/fs.cpp 8bcc2cd
> src/linux/proc.cpp 7af7802
> src/master/drf_sorter.hpp b8ea828
> src/slave/lxc_isolation_module.cpp de2a3fd
> src/tests/allocator_tests.cpp 84c347e
> src/tests/proc_tests.cpp 035db70
> src/zookeeper/zookeeper.cpp ba64a82
> third_party/boost-1.37.0.tar.gz 9d1b639
> third_party/boost-1.51.0.tar.gz PRE-CREATION
> third_party/libprocess/include/process/event.hpp a722c4a
> third_party/libprocess/include/process/filter.hpp 43e4ce7
> third_party/libprocess/include/stout/foreach.hpp 4b90c21
> third_party/libprocess/src/encoder.hpp ac4886e
> third_party/libprocess/third_party/boost-1.37.0.tar.gz 0045b62
> third_party/libprocess/third_party/boost-1.51.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/versions.am 812b2d6
> third_party/versions.am 15dc524
>
> Diff: https://reviews.apache.org/r/6812/diff/
>
>
> Testing
> -------
>
> built on mac and linux (centos)
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fix for -Wall -Werror build regression on Linux
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6812/#review10846
-----------------------------------------------------------
src/linux/fs.cpp
<https://reviews.apache.org/r/6812/#comment23378>
Here, probably you can look at my fix
https://reviews.apache.org/r/6826/
It is a bug (typo).
- Jie Yu
On Aug. 28, 2012, 9:20 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6812/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2012, 9:20 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This fixes the build on linux, I've tested this out on centos.
>
> Note that this upgrades our boost version as well :)
>
>
> Diffs
> -----
>
> src/flags/flags.hpp aca3be5
> src/java/jni/convert.cpp 075ea58
> src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 2ee8c83
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 3095f9b
> src/jvm/jvm.hpp 7e4e433
> src/jvm/jvm.cpp a916548
> src/linux/fs.cpp 8bcc2cd
> src/linux/proc.cpp 7af7802
> src/master/drf_sorter.hpp b8ea828
> src/slave/lxc_isolation_module.cpp de2a3fd
> src/tests/allocator_tests.cpp 84c347e
> src/tests/proc_tests.cpp 035db70
> src/zookeeper/zookeeper.cpp ba64a82
> third_party/boost-1.37.0.tar.gz 9d1b639
> third_party/boost-1.51.0.tar.gz PRE-CREATION
> third_party/libprocess/include/process/event.hpp a722c4a
> third_party/libprocess/include/process/filter.hpp 43e4ce7
> third_party/libprocess/include/stout/foreach.hpp 4b90c21
> third_party/libprocess/src/encoder.hpp ac4886e
> third_party/libprocess/third_party/boost-1.37.0.tar.gz 0045b62
> third_party/libprocess/third_party/boost-1.51.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/versions.am 812b2d6
> third_party/versions.am 15dc524
>
> Diff: https://reviews.apache.org/r/6812/diff/
>
>
> Testing
> -------
>
> built on mac and linux (centos)
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fix for -Wall -Werror build regression on Linux
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6812/
-----------------------------------------------------------
(Updated Aug. 28, 2012, 9:20 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
review changes
Description
-------
This fixes the build on linux, I've tested this out on centos.
Note that this upgrades our boost version as well :)
Diffs (updated)
-----
src/flags/flags.hpp aca3be5
src/java/jni/convert.cpp 075ea58
src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 2ee8c83
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 3095f9b
src/jvm/jvm.hpp 7e4e433
src/jvm/jvm.cpp a916548
src/linux/fs.cpp 8bcc2cd
src/linux/proc.cpp 7af7802
src/master/drf_sorter.hpp b8ea828
src/slave/lxc_isolation_module.cpp de2a3fd
src/tests/allocator_tests.cpp 84c347e
src/tests/proc_tests.cpp 035db70
src/zookeeper/zookeeper.cpp ba64a82
third_party/boost-1.37.0.tar.gz 9d1b639
third_party/boost-1.51.0.tar.gz PRE-CREATION
third_party/libprocess/include/process/event.hpp a722c4a
third_party/libprocess/include/process/filter.hpp 43e4ce7
third_party/libprocess/include/stout/foreach.hpp 4b90c21
third_party/libprocess/src/encoder.hpp ac4886e
third_party/libprocess/third_party/boost-1.37.0.tar.gz 0045b62
third_party/libprocess/third_party/boost-1.51.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/versions.am 812b2d6
third_party/versions.am 15dc524
Diff: https://reviews.apache.org/r/6812/diff/
Testing
-------
built on mac and linux (centos)
Thanks,
Ben Mahler
Re: Review Request: Fix for -Wall -Werror build regression on Linux
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6812/#review10822
-----------------------------------------------------------
Ship it!
third_party/libprocess/include/process/filter.hpp
<https://reviews.apache.org/r/6812/#comment23322>
ws
third_party/libprocess/include/stout/foreach.hpp
<https://reviews.apache.org/r/6812/#comment23323>
make this a TODO
- Vinod Kone
On Aug. 28, 2012, 9:03 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6812/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2012, 9:03 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This fixes the build on linux, I've tested this out on centos.
>
> Note that this upgrades our boost version as well :)
>
>
> Diffs
> -----
>
> src/flags/flags.hpp aca3be5
> src/java/jni/convert.cpp 075ea58
> src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 2ee8c83
> src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 3095f9b
> src/jvm/jvm.hpp 7e4e433
> src/jvm/jvm.cpp a916548
> src/linux/fs.cpp 8bcc2cd
> src/linux/proc.cpp 7af7802
> src/master/drf_sorter.hpp b8ea828
> src/slave/lxc_isolation_module.cpp de2a3fd
> src/tests/allocator_tests.cpp 84c347e
> src/tests/proc_tests.cpp 035db70
> src/zookeeper/zookeeper.cpp ba64a82
> third_party/boost-1.37.0.tar.gz 9d1b639
> third_party/boost-1.51.0.tar.gz PRE-CREATION
> third_party/libprocess/include/process/event.hpp a722c4a
> third_party/libprocess/include/process/filter.hpp 43e4ce7
> third_party/libprocess/include/stout/foreach.hpp 4b90c21
> third_party/libprocess/src/encoder.hpp ac4886e
> third_party/libprocess/third_party/boost-1.37.0.tar.gz 0045b62
> third_party/libprocess/third_party/boost-1.51.0.tar.gz PRE-CREATION
> third_party/libprocess/third_party/versions.am 812b2d6
> third_party/versions.am 15dc524
>
> Diff: https://reviews.apache.org/r/6812/diff/
>
>
> Testing
> -------
>
> built on mac and linux (centos)
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fix for -Wall -Werror build regression on Linux
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6812/
-----------------------------------------------------------
(Updated Aug. 28, 2012, 9:03 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description (updated)
-------
This fixes the build on linux, I've tested this out on centos.
Note that this upgrades our boost version as well :)
Diffs
-----
src/flags/flags.hpp aca3be5
src/java/jni/convert.cpp 075ea58
src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 2ee8c83
src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 3095f9b
src/jvm/jvm.hpp 7e4e433
src/jvm/jvm.cpp a916548
src/linux/fs.cpp 8bcc2cd
src/linux/proc.cpp 7af7802
src/master/drf_sorter.hpp b8ea828
src/slave/lxc_isolation_module.cpp de2a3fd
src/tests/allocator_tests.cpp 84c347e
src/tests/proc_tests.cpp 035db70
src/zookeeper/zookeeper.cpp ba64a82
third_party/boost-1.37.0.tar.gz 9d1b639
third_party/boost-1.51.0.tar.gz PRE-CREATION
third_party/libprocess/include/process/event.hpp a722c4a
third_party/libprocess/include/process/filter.hpp 43e4ce7
third_party/libprocess/include/stout/foreach.hpp 4b90c21
third_party/libprocess/src/encoder.hpp ac4886e
third_party/libprocess/third_party/boost-1.37.0.tar.gz 0045b62
third_party/libprocess/third_party/boost-1.51.0.tar.gz PRE-CREATION
third_party/libprocess/third_party/versions.am 812b2d6
third_party/versions.am 15dc524
Diff: https://reviews.apache.org/r/6812/diff/
Testing
-------
built on mac and linux (centos)
Thanks,
Ben Mahler