You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "tchughesiv (via GitHub)" <gi...@apache.org> on 2023/11/08 18:01:28 UTC
[PR] [KOGITO-9924] use AppPropertyHandler for Data Index custom properties [incubator-kie-kogito-serverless-operator]
tchughesiv opened a new pull request, #299:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/299
<!--
Welcome to the SonataFlow Operator! Before contributing, make sure to:
- Rebase your branch on the latest upstream main
- Link any relevant issues, PR's, or documentation
- Check that the commit message is concise and helpful:
- When fixing an issue, add "Closes #<ISSUE_NUMBER>"
- Follow the below checklist
-->
**Description of the change:**
**Motivation for the change:**
**Checklist**
- [ ] Add or Modify a unit test for your change
- [ ] Have you verified that tall the tests are passing?
<details>
<summary>
How to backport a pull request to a different branch?
</summary>
In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-<branch-name>`, where `<branch-name>` is the name of the branch where the pull request must be backported to (e.g., `backport-7.67.x` to backport the original PR to the `7.67.x` branch).
> **NOTE**: **backporting** is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.
Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.
> **NOTE**: this automated backporting is triggered whenever a pull request on `main` branch is labeled or closed, but both conditions must be satisfied to get the new PR created.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [KOGITO-9924] use AppPropertyHandler for Data Index custom properties [incubator-kie-kogito-serverless-operator]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini merged PR #299:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [KOGITO-9924] use AppPropertyHandler for Data Index custom properties [incubator-kie-kogito-serverless-operator]
Posted by "tchughesiv (via GitHub)" <gi...@apache.org>.
tchughesiv commented on code in PR #299:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/299#discussion_r1389818557
##########
controllers/profiles/common/app_properties.go:
##########
@@ -50,6 +51,7 @@ var immutableApplicationProperties = "quarkus.http.port=" + DefaultHTTPWorkflowP
var _ AppPropertyHandler = &appPropertyHandler{}
type AppPropertyHandler interface {
+ asService() AppPropertyHandler
Review Comment:
good catch, i had originally made it public
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [KOGITO-9924] use AppPropertyHandler for Data Index custom properties [incubator-kie-kogito-serverless-operator]
Posted by "tchughesiv (via GitHub)" <gi...@apache.org>.
tchughesiv commented on code in PR #299:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/299#discussion_r1389880948
##########
controllers/profiles/common/app_properties.go:
##########
@@ -50,6 +51,7 @@ var immutableApplicationProperties = "quarkus.http.port=" + DefaultHTTPWorkflowP
var _ AppPropertyHandler = &appPropertyHandler{}
type AppPropertyHandler interface {
+ asService() AppPropertyHandler
Review Comment:
i've decided to do away with that method entirely... seems cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [KOGITO-9924] use AppPropertyHandler for Data Index custom properties [incubator-kie-kogito-serverless-operator]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #299:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/299#discussion_r1389793603
##########
controllers/profiles/common/app_properties.go:
##########
@@ -50,6 +51,7 @@ var immutableApplicationProperties = "quarkus.http.port=" + DefaultHTTPWorkflowP
var _ AppPropertyHandler = &appPropertyHandler{}
type AppPropertyHandler interface {
+ asService() AppPropertyHandler
Review Comment:
You don't need to add a private method to the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org