You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "fuweng11 (via GitHub)" <gi...@apache.org> on 2023/12/07 09:05:19 UTC
[PR] [INLONG-9440][Manager] Support querying audit information based on ip [inlong]
fuweng11 opened a new pull request, #9443:
URL: https://github.com/apache/inlong/pull/9443
### Prepare a Pull Request
- Fixes #9440
### Motivation
Support querying audit information based on ip.
### Modifications
Support querying audit information based on ip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9440][Manager] Support querying audit information based on ip [inlong]
Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on code in PR #9443:
URL: https://github.com/apache/inlong/pull/9443#discussion_r1418856153
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AuditServiceImpl.java:
##########
@@ -330,8 +333,10 @@ public List<AuditVO> listByCondition(AuditRequest request) throws Exception {
}
} else if (AuditQuerySource.CLICKHOUSE == querySource) {
try (Connection connection = config.getCkConnection();
- PreparedStatement statement = getAuditCkStatement(connection, groupId, streamId, auditId,
- request.getStartDate(), request.getEndDate());
+ PreparedStatement statement = StringUtils.isNotBlank(request.getIp()) ? getAuditCkStatementByIp(
Review Comment:
Automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9440][Manager] Support querying audit information based on ip [inlong]
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap merged PR #9443:
URL: https://github.com/apache/inlong/pull/9443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9440][Manager] Support querying audit information based on ip [inlong]
Posted by "vernedeng (via GitHub)" <gi...@apache.org>.
vernedeng commented on code in PR #9443:
URL: https://github.com/apache/inlong/pull/9443#discussion_r1418796627
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/AuditServiceImpl.java:
##########
@@ -330,8 +333,10 @@ public List<AuditVO> listByCondition(AuditRequest request) throws Exception {
}
} else if (AuditQuerySource.CLICKHOUSE == querySource) {
try (Connection connection = config.getCkConnection();
- PreparedStatement statement = getAuditCkStatement(connection, groupId, streamId, auditId,
- request.getStartDate(), request.getEndDate());
+ PreparedStatement statement = StringUtils.isNotBlank(request.getIp()) ? getAuditCkStatementByIp(
Review Comment:
release resource plz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org