You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by mmiklavc <gi...@git.apache.org> on 2016/08/01 19:27:20 UTC
[GitHub] incubator-metron pull request #204: METRON-356 Modify Storm topology.classpa...
GitHub user mmiklavc opened a pull request:
https://github.com/apache/incubator-metron/pull/204
METRON-356 Modify Storm topology.classpath via Ambari
This PR completes - [https://issues.apache.org/jira/browse/METRON-356](https://issues.apache.org/jira/browse/METRON-356)
The code changes leverage Storm's built-in classpath properties for adding additional files to the classpath instead of modifying Metron jar file internals to include items required on the classpath.
I successfully tested this on full dev platform.
Additional info - [https://issues.apache.org/jira/browse/STORM-54](https://issues.apache.org/jira/browse/STORM-54)
**Testing**
Standard deployment that includes deployment via Ambari. Ensure that the pipeline runs without Exceptions from the parsers through to indexing in Elasticsearch. Verify you see indexes being populated in Kibana. Note: If you're seeing exceptions in the full dev platform in Vagrant, you might need to stop YARN, MR2, and any other processes not necessary to verify indexing works correctly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/incubator-metron METRON-356
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/204.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #204
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #204: METRON-356 Modify Storm topology.classpath via ...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/204
+1 by inspection, great job!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #204: METRON-356 Modify Storm topology.classpath via ...
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the issue:
https://github.com/apache/incubator-metron/pull/204
Thanks- it'll help later when we modify the Ambari setup scripts to accept the setting. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #204: METRON-356 Modify Storm topology.classpath via ...
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the issue:
https://github.com/apache/incubator-metron/pull/204
+1. Ran it up on EC2- worked great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #204: METRON-356 Modify Storm topology.classpath via ...
Posted by mmiklavc <gi...@git.apache.org>.
Github user mmiklavc commented on the issue:
https://github.com/apache/incubator-metron/pull/204
It's a setting in Ambari that exposes the functionality, which is set via the Ansible scripts. I will rename it per your recommendation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #204: METRON-356 Modify Storm topology.classpa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-metron/pull/204
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron issue #204: METRON-356 Modify Storm topology.classpath via ...
Posted by dlyle65535 <gi...@git.apache.org>.
Github user dlyle65535 commented on the issue:
https://github.com/apache/incubator-metron/pull/204
This looks really good, @mmiklavc I suspect you meant Ansible above? Perhaps you can re-title this to "Enable topology classpath to be updated via configuration"?
I'll run it up tomorrow morning and let you know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---