You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/06/15 07:52:54 UTC

[GitHub] [ozone] adoroszlai opened a new pull request #2336: HDDS-5347. Wrong cache key for integration tests

adoroszlai opened a new pull request #2336:
URL: https://github.com/apache/ozone/pull/2336


   ## What changes were proposed in this pull request?
   
   1. Cache key for integration tests is incomplete, hash of pom.xml files is missing:
      ```
      Run actions/cache@v2
        with:
          path: ~/.m2/repository
          key: maven-repo--8-
          restore-keys: maven-repo--8
        maven-repo-
        maven-repo-
      ...
      Cache restored from key: maven-repo--8-
      ```
      Path for `hashFiles` needs to include the custom checkout dir for _integration_ check.
   
   2. Fix reference to undefined `matrix.check` in _integration_ and _coverage_ checks.
   
   https://issues.apache.org/jira/browse/HDDS-5347
   
   ## How was this patch tested?
   
   Verified cache restore key in CI:
   
   ```
   Run actions/cache@v2
     with:
       path: ~/.m2/repository
       key: maven-repo-56cc6f8280fca1fe3170b0f76702498cdbcf129fe0d6acde06a612c2a210b2c8-8-filesystem-hdds
       restore-keys: maven-repo-56cc6f8280fca1fe3170b0f76702498cdbcf129fe0d6acde06a612c2a210b2c8-8
     maven-repo-56cc6f8280fca1fe3170b0f76702498cdbcf129fe0d6acde06a612c2a210b2c8
     maven-repo-
   ...
   Cache restored from key: maven-repo-6ff0cbbe45787840d0cb6dc629936b8771df1fdb184182b74c0fa60e4702c860-8
   ```
   
   https://github.com/adoroszlai/hadoop-ozone/runs/2826201686#step:4:1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai merged pull request #2336: HDDS-5347. Wrong cache key for integration tests

Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #2336:
URL: https://github.com/apache/ozone/pull/2336


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on pull request #2336: HDDS-5347. Wrong cache key for integration tests

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2336:
URL: https://github.com/apache/ozone/pull/2336#issuecomment-865662650


   Thanks @errose28 for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai merged pull request #2336: HDDS-5347. Wrong cache key for integration tests

Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #2336:
URL: https://github.com/apache/ozone/pull/2336


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on pull request #2336: HDDS-5347. Wrong cache key for integration tests

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2336:
URL: https://github.com/apache/ozone/pull/2336#issuecomment-865662650


   Thanks @errose28 for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org