You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2021/05/16 21:21:00 UTC
[GitHub] [mesos] cf-natali opened a new pull request #387: Fixed compilation error on CAP_(PERFMON,BPF,CHECKPOINT_RESTORE).
cf-natali opened a new pull request #387:
URL: https://github.com/apache/mesos/pull/387
They should be defined without the "CAP_" prefix to avoid clashing with
the corresponding definitions in `linux/capability.h` - and be
consistent with other capabilities.
@asekretenko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] asekretenko edited a comment on pull request #387: Fixed compilation error on CAP_(PERFMON,BPF,CHECKPOINT_RESTORE).
Posted by GitBox <gi...@apache.org>.
asekretenko edited a comment on pull request #387:
URL: https://github.com/apache/mesos/pull/387#issuecomment-842080959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] asekretenko edited a comment on pull request #387: Fixed compilation error on CAP_(PERFMON,BPF,CHECKPOINT_RESTORE).
Posted by GitBox <gi...@apache.org>.
asekretenko edited a comment on pull request #387:
URL: https://github.com/apache/mesos/pull/387#issuecomment-842080959
@cf-natali It would help readers if the commit message made it clear that the issue is only triggered by recent linux headers (something in line of "Fixed compilation against linux 5.0+ capabilities.h" - I'm not sure which exact kernel version introduced them, please check that). Otherwise, looks good to me.
Great that you caught this before releasing this code! Otherwise, this rename in `proto`s would be potentially breaking users of json APIs (due to how our json deserialization uses protobuf reflection).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] asekretenko commented on pull request #387: Fixed compilation error on CAP_(PERFMON,BPF,CHECKPOINT_RESTORE).
Posted by GitBox <gi...@apache.org>.
asekretenko commented on pull request #387:
URL: https://github.com/apache/mesos/pull/387#issuecomment-842080959
@cf-natali It would help readers if the commit message made it clear that the issue is only triggered by recent linux headers (something in line of "Fixed compilation against linux 5.0+ capabilities.h" - I'm not sure which exact introduced them, please check that). Otherwise, looks good to me.
Great that you caught this before releasing this code! Otherwise, this rename in `proto`s would be potentially breaking users of json APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] asekretenko edited a comment on pull request #387: Fixed compilation error on CAP_(PERFMON,BPF,CHECKPOINT_RESTORE).
Posted by GitBox <gi...@apache.org>.
asekretenko edited a comment on pull request #387:
URL: https://github.com/apache/mesos/pull/387#issuecomment-842080959
@cf-natali It would help readers if the commit message made it clear that the issue is only triggered by recent linux headers (something in line of "Fixed compilation against linux 5.0+ capabilities.h" - I'm not sure which exact kernel version introduced them, please check that). Otherwise, looks good to me.
Great that you caught this before releasing this code! Otherwise, this rename in `proto`s would be potentially breaking users of json APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] cf-natali commented on pull request #387: Fixed compilation error on CAP_(PERFMON,BPF,CHECKPOINT_RESTORE).
Posted by GitBox <gi...@apache.org>.
cf-natali commented on pull request #387:
URL: https://github.com/apache/mesos/pull/387#issuecomment-842090331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] asekretenko commented on pull request #387: Fixed compilation error on CAP_(PERFMON,BPF,CHECKPOINT_RESTORE).
Posted by GitBox <gi...@apache.org>.
asekretenko commented on pull request #387:
URL: https://github.com/apache/mesos/pull/387#issuecomment-842080959
@cf-natali It would help readers if the commit message made it clear that the issue is only triggered by recent linux headers (something in line of "Fixed compilation against linux 5.0+ capabilities.h" - I'm not sure which exact introduced them, please check that). Otherwise, looks good to me.
Great that you caught this before releasing this code! Otherwise, this rename in `proto`s would be potentially breaking users of json APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] cf-natali commented on pull request #387: Fixed compilation error on CAP_(PERFMON,BPF,CHECKPOINT_RESTORE).
Posted by GitBox <gi...@apache.org>.
cf-natali commented on pull request #387:
URL: https://github.com/apache/mesos/pull/387#issuecomment-847205926
@qianzhangxa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] cf-natali commented on pull request #387: Fixed compilation error on CAP_(PERFMON,BPF,CHECKPOINT_RESTORE).
Posted by GitBox <gi...@apache.org>.
cf-natali commented on pull request #387:
URL: https://github.com/apache/mesos/pull/387#issuecomment-842091364
> Great that you caught this before releasing this code! Otherwise, this rename in protos would be potentially breaking users of json APIs (due to how our json deserialization uses protobuf reflection).
Yeah, although it was my fault in the first place, at the time I didn't have access to such a recent kernel/libc, so couldn't properly test it.
It'd help if we had more recent/varied buildbots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] asekretenko merged pull request #387: Fixed compilation error on CAP_(PERFMON,BPF,CHECKPOINT_RESTORE).
Posted by GitBox <gi...@apache.org>.
asekretenko merged pull request #387:
URL: https://github.com/apache/mesos/pull/387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] cf-natali commented on pull request #387: Fixed compilation error on CAP_(PERFMON,BPF,CHECKPOINT_RESTORE).
Posted by GitBox <gi...@apache.org>.
cf-natali commented on pull request #387:
URL: https://github.com/apache/mesos/pull/387#issuecomment-842090331
> @cf-natali It would help readers if the commit message made it clear that the issue is only triggered by recent linux headers (something in line of "Fixed compilation against linux 5.0+ capabilities.h" - I'm not sure which exact kernel version introduced them, please check that). Otherwise, looks good to me.
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org