You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/13 23:10:53 UTC

[GitHub] [kafka] dielhennr opened a new pull request #10689: KAFKA-12697: Add EventQueueSize metric to Quorum controller

dielhennr opened a new pull request #10689:
URL: https://github.com/apache/kafka/pull/10689


   A counter is kept in the event queue.
   
   Tested using events that wait on a CountDownLatch before completing.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cmccabe commented on pull request #10689: KAFKA-12697: Add EventQueueSize metric to Quorum controller

Posted by GitBox <gi...@apache.org>.

cmccabe commented on pull request #10689:
URL: https://github.com/apache/kafka/pull/10689#issuecomment-840914242


   I think this would be too much work for us to maintain, and would get out of sync quickly.  The better approach would be to have a QueueMetrics interface, which QuorumControllerMetrics can then implement, for things like the size of the event queue.  We probably want a few other things in there too like how long each event is taking and how long events are sitting in the queue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org