You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltacloud.apache.org by da...@gmail.com on 2011/11/20 14:58:40 UTC
[PATCH] repair memory & storage unit at vsphere driver
From: ike-dai <da...@hotmail.co.jp>
---
.../deltacloud/drivers/vsphere/vsphere_driver.rb | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb b/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb
index 96db242..e725d24 100644
--- a/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb
+++ b/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb
@@ -43,7 +43,7 @@ module Deltacloud::Drivers::VSphere
service = vsphere.serviceInstance.content
max_memory, max_cpu_cores = [], []
service.rootFolder.childEntity.grep(RbVmomi::VIM::Datacenter).each do |dc|
- max_memory << dc.hostFolder.childEntity.first.summary.effectiveMemory
+ max_memory << dc.hostFolder.childEntity.first.summary.effectiveMemory)/(1024*1024)
max_cpu_cores << dc.hostFolder.childEntity.first.summary.numCpuCores
end
[Deltacloud::HardwareProfile::new('default') do
@@ -162,7 +162,7 @@ module Deltacloud::Drivers::VSphere
properties = {
:memory => config[:memorySizeMB],
:cpus => config[:numCpu],
- :storage => vm.summary.storage[:unshared],
+ :storage => vm.summary.storage[:unshared]/(1024*1024*1024),
:name => config[:name],
:full_name => config[:guestFullName],
}
--
1.7.5.4
Re: [PATCH] repair memory & storage unit at vsphere driver
Posted by David Lutterkort <lu...@redhat.com>.
On Sun, 2011-11-20 at 22:58 +0900, dai.ikd123@gmail.com wrote:
> From: ike-dai <da...@hotmail.co.jp>
>
> ---
> .../deltacloud/drivers/vsphere/vsphere_driver.rb | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb b/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb
> index 96db242..e725d24 100644
> --- a/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb
> +++ b/server/lib/deltacloud/drivers/vsphere/vsphere_driver.rb
> @@ -43,7 +43,7 @@ module Deltacloud::Drivers::VSphere
> service = vsphere.serviceInstance.content
> max_memory, max_cpu_cores = [], []
> service.rootFolder.childEntity.grep(RbVmomi::VIM::Datacenter).each do |dc|
> - max_memory << dc.hostFolder.childEntity.first.summary.effectiveMemory
> + max_memory << dc.hostFolder.childEntity.first.summary.effectiveMemory)/(1024*1024)
Is this really right ? The docs[1] state that this is already in MB
> @@ -162,7 +162,7 @@ module Deltacloud::Drivers::VSphere
> properties = {
> :memory => config[:memorySizeMB],
> :cpus => config[:numCpu],
> - :storage => vm.summary.storage[:unshared],
> + :storage => vm.summary.storage[:unshared]/(1024*1024*1024),
Yes, according to docs this is in bytes, and needs to be converted to
GB.
David
[1] http://www.vmware.com/support/developer/vc-sdk/visdk41pubs/ApiReference/index.html