You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2012/06/01 22:52:47 UTC
Re: svn commit: r1340318 - in /subversion/trunk/subversion:
libsvn_client/status.c svn/status-cmd.c tests/cmdline/stat_tests.py
On Fri, May 18, 2012 at 8:21 PM, <rh...@apache.org> wrote:
> Author: rhuijben
> Date: Sat May 19 00:21:31 2012
> New Revision: 1340318
>
> URL: http://svn.apache.org/viewvc?rev=1340318&view=rev
> Log:
> Avoid an unneeded ancestor check in the status walker. This has the added
> benefit that api users can now see a different error code for not in a working
> copy and not below a working copy.
I just found this breaks stat 19 for me:
W: EXPECTED STDERR (regexp):
svn: warning: W155007: '.*(/|\\)stat_tests-19' is not a working copy
W: ACTUAL STDERR:
svn: warning: W155010: The node
'/Users/gstein/src/svn/subversion/tests/cmdline/svn-test-work/working_copies'
was not found.
svn: warning: W155010: The node
'/Users/gstein/src/svn/subversion/tests/cmdline/svn-test-work/working_copies'
was not found.
W: CWD: /Users/gstein/src/svn/subversion/tests/cmdline
>...
Seems that check is needed :-P
Cheers,
-g
Re: svn commit: r1340318 - in /subversion/trunk/subversion:
libsvn_client/status.c svn/status-cmd.c tests/cmdline/stat_tests.py
Posted by Greg Stein <gs...@gmail.com>.
On Fri, Jun 1, 2012 at 5:52 PM, Bert Huijben <be...@vmoo.com> wrote:
>> -----Original Message-----
>> From: Greg Stein [mailto:gstein@gmail.com]
>> Sent: vrijdag 1 juni 2012 23:46
>> To: Philip Martin
>> Cc: dev@subversion.apache.org; Bert Huijben
>> Subject: Re: svn commit: r1340318 - in /subversion/trunk/subversion:
>> libsvn_client/status.c svn/status-cmd.c tests/cmdline/stat_tests.py
>>
>> On Fri, Jun 1, 2012 at 5:22 PM, Philip Martin
>> <ph...@wandisco.com> wrote:
...
>> > The test will FAIL when subversion/tests/cmdline/, or any directory
>> > between there and /, is a working copy. If subversion/tests/cmdline/ is
>> > outside a working copy the test will PASS.
>>
>> Alright. Do you know how we can fix that? Our tests should not be
>> sensitive to their placement in a filesystem. (otherwise, it isn't a
>> very reliable test!)
>
> Should be fixed by r1345361.
Confirmed. Thanks!
RE: svn commit: r1340318 - in /subversion/trunk/subversion: libsvn_client/status.c svn/status-cmd.c tests/cmdline/stat_tests.py
Posted by Bert Huijben <be...@vmoo.com>.
> -----Original Message-----
> From: Greg Stein [mailto:gstein@gmail.com]
> Sent: vrijdag 1 juni 2012 23:46
> To: Philip Martin
> Cc: dev@subversion.apache.org; Bert Huijben
> Subject: Re: svn commit: r1340318 - in /subversion/trunk/subversion:
> libsvn_client/status.c svn/status-cmd.c tests/cmdline/stat_tests.py
>
> On Fri, Jun 1, 2012 at 5:22 PM, Philip Martin
> <ph...@wandisco.com> wrote:
> > Greg Stein <gs...@gmail.com> writes:
> >
> >> On Fri, May 18, 2012 at 8:21 PM, <rh...@apache.org> wrote:
> >>> Author: rhuijben
> >>> Date: Sat May 19 00:21:31 2012
> >>> New Revision: 1340318
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=1340318&view=rev
> >>> Log:
> >>> Avoid an unneeded ancestor check in the status walker. This has the
> added
> >>> benefit that api users can now see a different error code for not in a
> working
> >>> copy and not below a working copy.
> >>
> >> I just found this breaks stat 19 for me:
> >> Seems that check is needed :-P
> >
> > The test will FAIL when subversion/tests/cmdline/, or any directory
> > between there and /, is a working copy. If subversion/tests/cmdline/ is
> > outside a working copy the test will PASS.
>
> Alright. Do you know how we can fix that? Our tests should not be
> sensitive to their placement in a filesystem. (otherwise, it isn't a
> very reliable test!)
Should be fixed by r1345361.
Bert
Re: svn commit: r1340318 - in /subversion/trunk/subversion:
libsvn_client/status.c svn/status-cmd.c tests/cmdline/stat_tests.py
Posted by Greg Stein <gs...@gmail.com>.
On Fri, Jun 1, 2012 at 5:22 PM, Philip Martin
<ph...@wandisco.com> wrote:
> Greg Stein <gs...@gmail.com> writes:
>
>> On Fri, May 18, 2012 at 8:21 PM, <rh...@apache.org> wrote:
>>> Author: rhuijben
>>> Date: Sat May 19 00:21:31 2012
>>> New Revision: 1340318
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1340318&view=rev
>>> Log:
>>> Avoid an unneeded ancestor check in the status walker. This has the added
>>> benefit that api users can now see a different error code for not in a working
>>> copy and not below a working copy.
>>
>> I just found this breaks stat 19 for me:
>>
>> W: EXPECTED STDERR (regexp):
>> svn: warning: W155007: '.*(/|\\)stat_tests-19' is not a working copy
>> W: ACTUAL STDERR:
>> svn: warning: W155010: The node
>> '/Users/gstein/src/svn/subversion/tests/cmdline/svn-test-work/working_copies'
>> was not found.
>> svn: warning: W155010: The node
>> '/Users/gstein/src/svn/subversion/tests/cmdline/svn-test-work/working_copies'
>> was not found.
>> W: CWD: /Users/gstein/src/svn/subversion/tests/cmdline
>>
>>>...
>>
>> Seems that check is needed :-P
>
> The test will FAIL when subversion/tests/cmdline/, or any directory
> between there and /, is a working copy. If subversion/tests/cmdline/ is
> outside a working copy the test will PASS.
Alright. Do you know how we can fix that? Our tests should not be
sensitive to their placement in a filesystem. (otherwise, it isn't a
very reliable test!)
Cheers,
-g
Re: svn commit: r1340318 - in /subversion/trunk/subversion: libsvn_client/status.c svn/status-cmd.c tests/cmdline/stat_tests.py
Posted by Philip Martin <ph...@wandisco.com>.
Greg Stein <gs...@gmail.com> writes:
> On Fri, May 18, 2012 at 8:21 PM, <rh...@apache.org> wrote:
>> Author: rhuijben
>> Date: Sat May 19 00:21:31 2012
>> New Revision: 1340318
>>
>> URL: http://svn.apache.org/viewvc?rev=1340318&view=rev
>> Log:
>> Avoid an unneeded ancestor check in the status walker. This has the added
>> benefit that api users can now see a different error code for not in a working
>> copy and not below a working copy.
>
> I just found this breaks stat 19 for me:
>
> W: EXPECTED STDERR (regexp):
> svn: warning: W155007: '.*(/|\\)stat_tests-19' is not a working copy
> W: ACTUAL STDERR:
> svn: warning: W155010: The node
> '/Users/gstein/src/svn/subversion/tests/cmdline/svn-test-work/working_copies'
> was not found.
> svn: warning: W155010: The node
> '/Users/gstein/src/svn/subversion/tests/cmdline/svn-test-work/working_copies'
> was not found.
> W: CWD: /Users/gstein/src/svn/subversion/tests/cmdline
>
>>...
>
> Seems that check is needed :-P
The test will FAIL when subversion/tests/cmdline/, or any directory
between there and /, is a working copy. If subversion/tests/cmdline/ is
outside a working copy the test will PASS.
--
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com