You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "seawinde (via GitHub)" <gi...@apache.org> on 2026/05/21 10:00:01 UTC
[PR] [fix](fe) Preserve labels for histogram metrics [doris]
seawinde opened a new pull request, #63485:
URL: https://github.com/apache/doris/pull/63485
### What problem does this PR solve?
Issue Number: N/A
Related PR: #13832
Problem Summary:
Histogram metrics that encode labels in the Dropwizard metric name can be rendered incorrectly when label values contain dots or other special characters. For example, a user value like `qing.lu@lbk.one` can be split as part of the metric name instead of being kept as the `user` label.
Root cause: In `PrometheusMetricVisitor.visitHistogram()` and `JsonMetricVisitor.visitHistogram()`, the legacy histogram export path splits the Dropwizard histogram name by dots and infers labels from `k=v` name segments. `MetricRepo.USER_HISTO_QUERY_LATENCY` previously embedded the user label into the histogram name, so dots inside user names were treated as metric-name separators.
Change Summary:
| File | Change Description |
|------|--------------------|
| `fe/fe-core/src/main/java/org/apache/doris/metric/HistogramMetric.java` | Add a small wrapper that keeps the Dropwizard `Histogram` together with its metric name and structured labels. |
| `fe/fe-core/src/main/java/org/apache/doris/metric/MetricRepo.java` | Export labeled histogram metrics through the new structured label path while keeping existing static histograms exported. |
| `fe/fe-core/src/main/java/org/apache/doris/metric/CloudMetrics.java` | Keep cloud query latency and meta-service RPC latency labels structured instead of encoding them in histogram names. |
| `fe/fe-core/src/main/java/org/apache/doris/metric/MetricVisitor.java` | Add a labeled histogram visit overload. |
| `fe/fe-core/src/main/java/org/apache/doris/metric/PrometheusMetricVisitor.java` | Render structured histogram labels directly in Prometheus output. |
| `fe/fe-core/src/main/java/org/apache/doris/metric/JsonMetricVisitor.java` | Render structured histogram labels directly in JSON output. |
| `fe/fe-core/src/test/java/org/apache/doris/metric/MetricsTest.java` | Cover user and cloud histogram labels containing dots and at signs. |
Design Rationale:
The fix follows the existing counter and gauge approach: keep metric names stable and carry dimensions as `MetricLabel` values. The legacy three-argument histogram visitor remains for existing static Dropwizard histograms without labels, while dynamic histograms that need labels use the structured four-argument path.
```mermaid
graph TD
A[Query finished] --> B[AuditLogHelper.updateMetricsImpl]
B --> C[USER_HISTO_QUERY_LATENCY.getOrAdd(user)]
C --> D[HistogramMetric name + Histogram + labels]
D --> E[MetricRepo.visitHistograms]
E --> F[PrometheusMetricVisitor / JsonMetricVisitor]
F --> G[Stable metric name with structured labels]
```
### Release note
Fixed an issue where FE histogram metrics with label values containing dots, such as user names or cloud cluster names, could be exported with malformed metric names or labels.
### Check List (For Author)
- Test
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason
Unit tests:
- Maven package for `fe-core` passed with tests skipped to verify compile and checkstyle.
- `org.apache.doris.metric.MetricsTest` passed manually, `OK (12 tests)`.
- `./run-fe-ut.sh --run org.apache.doris.metric.MetricsTest` was attempted but blocked by an unrelated testCompile classpath issue where `CloudProcVersionDisplayTest` imports `mockit`.
- Behavior changed:
- [x] No. This restores intended metric label rendering.
- [ ] Yes.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Preserve labels for histogram metrics to fix wrong metric name for prometheus [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63485:
URL: https://github.com/apache/doris/pull/63485#issuecomment-4507733687
# FE UT Coverage Report
Increment line coverage ` 81.97% (50/61)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63485_d75989a31e8e63f9cad55cf2a27f6c12f1c84fb3/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63485_d75989a31e8e63f9cad55cf2a27f6c12f1c84fb3/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Preserve labels for histogram metrics [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63485:
URL: https://github.com/apache/doris/pull/63485#issuecomment-4506989708
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Preserve labels for histogram metrics to fix wrong metric name for prometheus [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63485:
URL: https://github.com/apache/doris/pull/63485#issuecomment-4518038916
<details>
<summary>TPC-H: <b>Total hot run time: 31584 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 29aa71b76d6d3399419dd60e6869f927080302cc, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17719 3968 3937 3937
q2 q3 10753 1384 810 810
q4 4687 485 350 350
q5 7593 2317 2092 2092
q6 242 177 136 136
q7 949 791 636 636
q8 9408 1788 1620 1620
q9 5208 4903 4937 4903
q10 6404 2141 1810 1810
q11 431 268 243 243
q12 633 428 292 292
q13 18109 3455 2843 2843
q14 261 261 234 234
q15 q16 851 775 705 705
q17 1005 1078 928 928
q18 6914 5698 5511 5511
q19 1340 1343 1137 1137
q20 589 466 293 293
q21 6120 2955 2731 2731
q22 486 373 468 373
Total cold run time: 99702 ms
Total hot run time: 31584 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4678 4555 4669 4555
q2 q3 4913 5218 4644 4644
q4 2143 2195 1414 1414
q5 4849 4658 4663 4658
q6 233 183 136 136
q7 1907 1740 1503 1503
q8 2391 2083 2101 2083
q9 7715 7324 7213 7213
q10 4491 4488 4026 4026
q11 522 371 347 347
q12 712 725 509 509
q13 3030 3482 2797 2797
q14 263 271 253 253
q15 q16 678 709 609 609
q17 1291 1247 1233 1233
q18 7297 6956 6757 6757
q19 1121 1097 1102 1097
q20 2199 2212 1936 1936
q21 5308 4681 4479 4479
q22 520 461 411 411
Total cold run time: 56261 ms
Total hot run time: 50660 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Preserve labels for histogram metrics to fix wrong metric name for prometheus [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on code in PR #63485:
URL: https://github.com/apache/doris/pull/63485#discussion_r3285607538
##########
fe/fe-core/src/main/java/org/apache/doris/metric/HistogramMetric.java:
##########
@@ -0,0 +1,53 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.metric;
+
+import com.codahale.metrics.ExponentiallyDecayingReservoir;
+import com.codahale.metrics.Histogram;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
+public class HistogramMetric {
Review Comment:
maybe extending from `com.codahale.metrics.Histogram` is better way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Preserve labels for histogram metrics to fix wrong metric name for prometheus [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63485:
URL: https://github.com/apache/doris/pull/63485#issuecomment-4508793623
<details>
<summary>TPC-DS: <b>Total hot run time: 168953 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ed0253de4886fb6cf4f2f75189513fbdb9539f0e, data reload: false
query5 4324 649 515 515
query6 322 222 195 195
query7 4334 548 309 309
query8 318 223 218 218
query9 8849 3931 3929 3929
query10 465 335 286 286
query11 5761 2495 2236 2236
query12 180 125 122 122
query13 1256 599 448 448
query14 5914 5377 5073 5073
query14_1 4338 4377 4351 4351
query15 218 204 179 179
query16 1005 461 443 443
query17 1128 723 610 610
query18 2452 525 355 355
query19 216 203 156 156
query20 145 127 134 127
query21 210 137 117 117
query22 13569 13611 13459 13459
query23 17190 16322 15923 15923
query23_1 16142 16181 16132 16132
query24 7663 1738 1282 1282
query24_1 1301 1285 1290 1285
query25 548 482 417 417
query26 1292 314 165 165
query27 2750 551 326 326
query28 4464 1967 1895 1895
query29 958 632 507 507
query30 306 241 194 194
query31 1110 1068 933 933
query32 90 74 74 74
query33 529 366 285 285
query34 1171 1126 654 654
query35 767 776 670 670
query36 1277 1347 1178 1178
query37 146 103 87 87
query38 3199 3121 3086 3086
query39 921 927 894 894
query39_1 874 873 879 873
query40 230 142 124 124
query41 65 61 62 61
query42 115 108 109 108
query43 358 325 288 288
query44
query45 207 203 195 195
query46 1092 1250 718 718
query47 2291 2345 2249 2249
query48 403 400 298 298
query49 636 494 388 388
query50 989 356 249 249
query51 4380 4269 4269 4269
query52 105 101 92 92
query53 248 267 198 198
query54 305 265 247 247
query55 91 91 84 84
query56 296 291 302 291
query57 1409 1369 1310 1310
query58 299 270 266 266
query59 1548 1636 1457 1457
query60 306 312 297 297
query61 159 158 171 158
query62 675 626 553 553
query63 246 193 195 193
query64 2380 775 610 610
query65
query66 1726 470 357 357
query67 29533 30046 29893 29893
query68
query69 466 339 304 304
query70 1016 983 917 917
query71 299 270 267 267
query72 3100 2726 2348 2348
query73 971 792 426 426
query74 5061 4927 4712 4712
query75 2655 2556 2264 2264
query76 2264 1102 758 758
query77 393 401 311 311
query78 12116 12151 11691 11691
query79 1252 1026 736 736
query80 570 546 439 439
query81 447 279 240 240
query82 230 150 123 123
query83 286 271 245 245
query84 263 137 110 110
query85 885 628 540 540
query86 350 328 308 308
query87 3372 3328 3254 3254
query88 3479 2639 2642 2639
query89 420 380 331 331
query90 2148 169 179 169
query91 178 163 135 135
query92 78 76 67 67
query93 1415 1447 860 860
query94 535 361 298 298
query95 655 367 342 342
query96 1095 870 326 326
query97 2698 2679 2558 2558
query98 239 226 223 223
query99 1107 1090 978 978
Total cold run time: 250499 ms
Total hot run time: 168953 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Preserve labels for histogram metrics to fix wrong metric name for prometheus [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63485:
URL: https://github.com/apache/doris/pull/63485#issuecomment-4508034846
<details>
<summary>TPC-H: <b>Total hot run time: 31667 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d75989a31e8e63f9cad55cf2a27f6c12f1c84fb3, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17639 3962 3913 3913
q2 q3 10851 1478 816 816
q4 4689 476 356 356
q5 7664 2298 2118 2118
q6 237 177 149 149
q7 929 783 654 654
q8 9367 1869 1767 1767
q9 5185 5059 4921 4921
q10 6393 2098 1810 1810
q11 441 277 240 240
q12 634 438 294 294
q13 18193 3414 2758 2758
q14 263 255 239 239
q15 q16 821 763 704 704
q17 1015 980 887 887
q18 7009 5736 5554 5554
q19 1159 1191 1057 1057
q20 569 491 300 300
q21 5996 2805 2737 2737
q22 461 402 393 393
Total cold run time: 99515 ms
Total hot run time: 31667 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4613 4544 4466 4466
q2 q3 4976 5288 4668 4668
q4 2153 2265 1410 1410
q5 4945 4687 4615 4615
q6 245 186 135 135
q7 1887 1783 1502 1502
q8 2378 2124 2057 2057
q9 7678 7251 7171 7171
q10 4517 4404 4031 4031
q11 533 381 354 354
q12 717 734 515 515
q13 3004 3426 2845 2845
q14 275 283 257 257
q15 q16 675 711 609 609
q17 1278 1251 1243 1243
q18 7331 6779 6673 6673
q19 1127 1106 1140 1106
q20 2251 2223 1923 1923
q21 5372 4665 4531 4531
q22 532 472 407 407
Total cold run time: 56487 ms
Total hot run time: 50518 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Preserve labels for histogram metrics to fix wrong metric name for prometheus [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #63485:
URL: https://github.com/apache/doris/pull/63485#issuecomment-4540979254
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Preserve labels for histogram metrics to fix wrong metric name for prometheus [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63485:
URL: https://github.com/apache/doris/pull/63485#issuecomment-4518103777
<details>
<summary>TPC-DS: <b>Total hot run time: 169462 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 29aa71b76d6d3399419dd60e6869f927080302cc, data reload: false
query5 4310 644 509 509
query6 329 229 198 198
query7 4287 558 312 312
query8 327 237 212 212
query9 8812 3995 3972 3972
query10 463 350 293 293
query11 5757 2514 2209 2209
query12 178 127 125 125
query13 1291 602 446 446
query14 6002 5394 5065 5065
query14_1 4361 4424 4373 4373
query15 215 206 181 181
query16 986 443 463 443
query17 986 739 597 597
query18 2465 508 372 372
query19 219 204 163 163
query20 146 135 131 131
query21 217 139 123 123
query22 13605 13510 13340 13340
query23 17338 16369 16048 16048
query23_1 16166 16205 16190 16190
query24 7432 1767 1307 1307
query24_1 1327 1319 1299 1299
query25 577 494 427 427
query26 1311 344 174 174
query27 2676 556 345 345
query28 4444 1942 1951 1942
query29 1003 643 512 512
query30 307 243 209 209
query31 1119 1068 945 945
query32 88 81 76 76
query33 553 382 339 339
query34 1183 1144 663 663
query35 761 784 673 673
query36 1347 1280 1151 1151
query37 150 107 95 95
query38 3203 3162 3050 3050
query39 927 916 892 892
query39_1 865 887 880 880
query40 251 145 122 122
query41 65 63 61 61
query42 108 107 107 107
query43 320 327 293 293
query44
query45 205 199 194 194
query46 1078 1196 708 708
query47 2253 2309 2232 2232
query48 397 423 300 300
query49 643 487 385 385
query50 961 351 269 269
query51 4333 4275 4232 4232
query52 104 105 95 95
query53 249 276 199 199
query54 306 267 250 250
query55 93 90 84 84
query56 292 306 293 293
query57 1384 1402 1301 1301
query58 301 274 265 265
query59 1516 1615 1410 1410
query60 316 328 312 312
query61 164 152 159 152
query62 675 625 574 574
query63 242 201 198 198
query64 2473 804 652 652
query65
query66 1736 467 348 348
query67 30136 30026 29939 29939
query68
query69 465 337 307 307
query70 985 1026 993 993
query71 305 274 265 265
query72 2965 2738 2249 2249
query73 839 788 440 440
query74 5078 4875 4767 4767
query75 2687 2604 2273 2273
query76 2299 1144 753 753
query77 403 407 324 324
query78 12256 12242 11636 11636
query79 1405 1089 717 717
query80 645 544 451 451
query81 460 275 241 241
query82 1388 157 129 129
query83 355 274 246 246
query84 310 141 111 111
query85 871 543 458 458
query86 380 339 317 317
query87 3411 3392 3236 3236
query88 3538 2712 2605 2605
query89 431 393 337 337
query90 1942 180 183 180
query91 180 180 137 137
query92 77 77 69 69
query93 1534 1527 882 882
query94 545 360 345 345
query95 683 463 364 364
query96 1047 747 326 326
query97 2705 2688 2549 2549
query98 237 222 225 222
query99 1123 1084 990 990
Total cold run time: 252888 ms
Total hot run time: 169462 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](fe) Preserve labels for histogram metrics [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #63485:
URL: https://github.com/apache/doris/pull/63485#issuecomment-4506991836
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Preserve labels for histogram metrics to fix wrong metric name for prometheus [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63485:
URL: https://github.com/apache/doris/pull/63485#issuecomment-4510018497
# FE Regression Coverage Report
Increment line coverage ` 88.52% (54/61)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63485_ed0253de4886fb6cf4f2f75189513fbdb9539f0e_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63485_ed0253de4886fb6cf4f2f75189513fbdb9539f0e_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Preserve labels for histogram metrics to fix wrong metric name for prometheus [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #63485:
URL: https://github.com/apache/doris/pull/63485#issuecomment-4508515538
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Preserve labels for histogram metrics to fix wrong metric name for prometheus [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63485:
URL: https://github.com/apache/doris/pull/63485#issuecomment-4508134254
<details>
<summary>TPC-DS: <b>Total hot run time: 170399 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d75989a31e8e63f9cad55cf2a27f6c12f1c84fb3, data reload: false
query5 4358 660 514 514
query6 326 230 208 208
query7 4241 559 299 299
query8 330 242 228 228
query9 8855 3991 3979 3979
query10 462 340 303 303
query11 5755 2396 2177 2177
query12 182 130 125 125
query13 1308 608 450 450
query14 6051 5419 5103 5103
query14_1 4361 4363 4342 4342
query15 217 202 183 183
query16 1002 452 452 452
query17 942 732 579 579
query18 2488 489 358 358
query19 226 203 164 164
query20 133 132 131 131
query21 215 136 118 118
query22 13615 13582 13387 13387
query23 17274 16347 16054 16054
query23_1 16111 16118 16026 16026
query24 7434 1749 1301 1301
query24_1 1308 1306 1325 1306
query25 557 478 398 398
query26 1307 321 170 170
query27 2687 533 340 340
query28 4453 1963 1967 1963
query29 971 606 544 544
query30 304 240 197 197
query31 1131 1072 948 948
query32 98 80 72 72
query33 542 341 298 298
query34 1172 1185 647 647
query35 763 784 672 672
query36 1314 1343 1194 1194
query37 150 111 89 89
query38 3213 3162 3096 3096
query39 948 922 896 896
query39_1 876 889 866 866
query40 236 145 127 127
query41 67 65 63 63
query42 113 109 105 105
query43 322 331 285 285
query44
query45 211 199 192 192
query46 1071 1224 742 742
query47 2268 2283 2115 2115
query48 399 415 308 308
query49 645 499 385 385
query50 948 349 250 250
query51 4422 4314 4220 4220
query52 108 104 93 93
query53 254 288 210 210
query54 329 288 264 264
query55 95 93 87 87
query56 315 325 313 313
query57 1430 1380 1296 1296
query58 298 278 271 271
query59 1511 1588 1391 1391
query60 321 322 305 305
query61 159 160 157 157
query62 662 625 566 566
query63 241 205 205 205
query64 2493 858 700 700
query65
query66 1763 507 380 380
query67 30137 29991 29852 29852
query68
query69 454 352 319 319
query70 973 981 1016 981
query71 311 288 275 275
query72 3232 2932 2529 2529
query73 828 742 412 412
query74 5074 4874 4766 4766
query75 2667 2620 2231 2231
query76 2323 1118 764 764
query77 413 408 333 333
query78 12216 12098 11618 11618
query79 1437 1005 735 735
query80 661 539 453 453
query81 458 281 247 247
query82 1392 164 120 120
query83 360 294 254 254
query84 316 135 112 112
query85 889 536 455 455
query86 406 325 313 313
query87 3458 3359 3190 3190
query88 3540 2669 2644 2644
query89 427 387 336 336
query90 1987 187 188 187
query91 182 170 140 140
query92 85 78 71 71
query93 1513 1549 910 910
query94 548 353 314 314
query95 671 498 343 343
query96 1071 765 330 330
query97 2704 2712 2568 2568
query98 242 230 220 220
query99 1118 1112 994 994
Total cold run time: 253348 ms
Total hot run time: 170399 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Preserve labels for histogram metrics to fix wrong metric name for prometheus [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63485:
URL: https://github.com/apache/doris/pull/63485#issuecomment-4508695378
<details>
<summary>TPC-H: <b>Total hot run time: 31047 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ed0253de4886fb6cf4f2f75189513fbdb9539f0e, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17609 3838 3819 3819
q2 q3 10781 1362 795 795
q4 4683 475 343 343
q5 7681 2271 2092 2092
q6 233 173 135 135
q7 911 780 639 639
q8 9415 1673 1551 1551
q9 5093 4926 4910 4910
q10 6413 2065 1786 1786
q11 439 271 240 240
q12 626 426 295 295
q13 18136 3407 2766 2766
q14 256 256 235 235
q15 q16 818 793 716 716
q17 979 893 953 893
q18 6854 5766 5484 5484
q19 1398 1239 1128 1128
q20 511 416 260 260
q21 6203 2756 2642 2642
q22 464 368 318 318
Total cold run time: 99503 ms
Total hot run time: 31047 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4875 4526 4507 4507
q2 q3 4877 5260 4707 4707
q4 2179 2268 1386 1386
q5 4920 4640 4591 4591
q6 234 178 128 128
q7 1905 1757 1540 1540
q8 2365 2060 2075 2060
q9 7687 7412 7223 7223
q10 4481 4393 3993 3993
q11 526 377 348 348
q12 712 721 514 514
q13 3033 3415 2837 2837
q14 267 297 266 266
q15 q16 678 700 604 604
q17 1255 1226 1225 1225
q18 7240 6902 6748 6748
q19 1102 1093 1078 1078
q20 2212 2200 1918 1918
q21 5327 4640 4561 4561
q22 511 484 424 424
Total cold run time: 56386 ms
Total hot run time: 50658 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Preserve labels for histogram metrics to fix wrong metric name for prometheus [doris]
Posted by "seawinde (via GitHub)" <gi...@apache.org>.
seawinde commented on PR #63485:
URL: https://github.com/apache/doris/pull/63485#issuecomment-4517616778
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Preserve labels for histogram metrics to fix wrong metric name for prometheus [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63485:
URL: https://github.com/apache/doris/pull/63485#issuecomment-4518963501
# FE Regression Coverage Report
Increment line coverage ` 89.04% (65/73)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63485_29aa71b76d6d3399419dd60e6869f927080302cc_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63485_29aa71b76d6d3399419dd60e6869f927080302cc_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Preserve labels for histogram metrics to fix wrong metric name for prometheus [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63485:
URL: https://github.com/apache/doris/pull/63485#issuecomment-4518211113
# FE UT Coverage Report
Increment line coverage ` 83.56% (61/73)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63485_29aa71b76d6d3399419dd60e6869f927080302cc/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63485_29aa71b76d6d3399419dd60e6869f927080302cc/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Preserve labels for histogram metrics to fix wrong metric name for prometheus [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #63485:
URL: https://github.com/apache/doris/pull/63485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](metric) Preserve labels for histogram metrics to fix wrong metric name for prometheus [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63485:
URL: https://github.com/apache/doris/pull/63485#issuecomment-4508277338
# FE Regression Coverage Report
Increment line coverage ` 88.52% (54/61)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63485_d75989a31e8e63f9cad55cf2a27f6c12f1c84fb3_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63485_d75989a31e8e63f9cad55cf2a27f6c12f1c84fb3_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org