You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2012/10/25 22:21:14 UTC
[jira] [Commented] (HADOOP-6671) To use maven for hadoop common
builds
[ https://issues.apache.org/jira/browse/HADOOP-6671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484456#comment-13484456 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-6671:
------------------------------------------------
{code}
diff --git hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
index de72eee..f4632f3 100644
--- hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
+++ hadoop-common/src/main/java/org/apache/hadoop/fs/AbstractFileSystem.java
@@ -91,7 +91,7 @@ public abstract class AbstractFileSystem {
StringTokenizer tokens = new StringTokenizer(src, Path.SEPARATOR);
while(tokens.hasMoreTokens()) {
String element = tokens.nextToken();
- if (element.equals("..") ||
+ if (element.equals("target/generated-sources") ||
element.equals(".") ||
(element.indexOf(":") >= 0)) {
return false;
{code}
Why replace ".." with "target/generated-sources"? Is it by mistake?
> To use maven for hadoop common builds
> -------------------------------------
>
> Key: HADOOP-6671
> URL: https://issues.apache.org/jira/browse/HADOOP-6671
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build
> Affects Versions: 0.22.0
> Reporter: Giridharan Kesavan
> Assignee: Alejandro Abdelnur
> Fix For: 0.23.0
>
> Attachments: build.png, common-mvn-layout-i.sh, HADOOP-6671-AA.patch, HADOOP-6671-AB.patch, HADOOP-6671-AC.patch, HADOOP-6671-AC.sh, HADOOP-6671-AD.patch, HADOOP-6671-AD.sh, HADOOP-6671b.patch, HADOOP-6671c.patch, HADOOP-6671-cross-project-HDFS.patch, HADOOP-6671d.patch, HADOOP-6671-e.patch, HADOOP-6671-f.patch, HADOOP-6671-g.patch, HADOOP-6671-h.patch, HADOOP-6671-i.patch, HADOOP-6671-j.patch, HADOOP-6671-k.sh, HADOOP-6671-l.patch, HADOOP-6671-m.patch, HADOOP-6671-n.patch, HADOOP-6671-o.patch, HADOOP-6671.patch, HADOOP-6671-p.patch, HADOOP-6671-q.patch, hadoop-commons-maven.patch, mvn-layout2.sh, mvn-layout2.sh, mvn-layout-AA.sh, mvn-layout-AB.sh, mvn-layout-e.sh, mvn-layout-f.sh, mvn-layout-k.sh, mvn-layout-l.sh, mvn-layout-m.sh, mvn-layout-n.sh, mvn-layout-o.sh, mvn-layout-p.sh, mvn-layout-q.sh, mvn-layout.sh, mvn-layout.sh
>
>
> We are now able to publish hadoop artifacts to the maven repo successfully [ Hadoop-6382]
> Drawbacks with the current approach:
> * Use ivy for dependency management with ivy.xml
> * Use maven-ant-task for artifact publishing to the maven repository
> * pom files are not generated dynamically
> To address this I propose we use maven to build hadoop-common, which would help us to manage dependencies, publish artifacts and have one single xml file(POM) for dependency management and artifact publishing.
> I would like to have a branch created to work on mavenizing hadoop common.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira