You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Oleg Kalnichevski <ol...@apache.org> on 2005/08/26 11:32:38 UTC
Cookie2 code review
Folks,
The code review of the Cookie2 cookie spec Samit wrote should be our top
priority at the moment. We have got to give Samit at least a couple of
days to correct things if problems are found. I suggest a new branch be
created off SVN TRUNK, which will later be merged back into TRUNK before
the first 3.1 release, for this end. Corrective patches should be
created against this branch.If there are objections to this plan, please
make them known.
I'll start reviewing the code tonight and intend to be done by the end
of the weekend. More people looking into that code would be great.
Around the same time I would like the new branch be created.
Please let me know what you think
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
Re: Cookie2 code review
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Fri, Aug 26, 2005 at 07:56:14AM -0400, Michael Becke wrote:
> A new branch sounds like the way to go. Once the code is checked in
> I'll take a look.
>
> Mike
>
Mike,
Then I will do the first round of review tonight, and if no massive
design problems are found, I will check the patch in as is. We have to
give Samit at least a couple of days before Sept 1st to act on the
review feedback.
Oleg
> On 8/26/05, Oleg Kalnichevski <ol...@apache.org> wrote:
> > Folks,
> > The code review of the Cookie2 cookie spec Samit wrote should be our top
> > priority at the moment. We have got to give Samit at least a couple of
> > days to correct things if problems are found. I suggest a new branch be
> > created off SVN TRUNK, which will later be merged back into TRUNK before
> > the first 3.1 release, for this end. Corrective patches should be
> > created against this branch.If there are objections to this plan, please
> > make them known.
> >
> > I'll start reviewing the code tonight and intend to be done by the end
> > of the weekend. More people looking into that code would be great.
> > Around the same time I would like the new branch be created.
> >
> > Please let me know what you think
> >
> > Oleg
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
Re: Cookie2 code review
Posted by Michael Becke <mb...@gmail.com>.
A new branch sounds like the way to go. Once the code is checked in
I'll take a look.
Mike
On 8/26/05, Oleg Kalnichevski <ol...@apache.org> wrote:
> Folks,
> The code review of the Cookie2 cookie spec Samit wrote should be our top
> priority at the moment. We have got to give Samit at least a couple of
> days to correct things if problems are found. I suggest a new branch be
> created off SVN TRUNK, which will later be merged back into TRUNK before
> the first 3.1 release, for this end. Corrective patches should be
> created against this branch.If there are objections to this plan, please
> make them known.
>
> I'll start reviewing the code tonight and intend to be done by the end
> of the weekend. More people looking into that code would be great.
> Around the same time I would like the new branch be created.
>
> Please let me know what you think
>
> Oleg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
Re: Cookie2 code review
Posted by Ortwin Glück <od...@odi.ch>.
Oleg, I have reviewed the code last week and made some comments. Sorry,
I did not post that email to the whole list. I can do that from home
tonight. Be careful with the patch on SF as it is corrupt: it contains
several versions of the patch in one file. Just check the SVN revision
numbers and remove the top ~10000 lines from the patch.
Odi
Oleg Kalnichevski wrote:
> Folks,
> The code review of the Cookie2 cookie spec Samit wrote should be our top
> priority at the moment. We have got to give Samit at least a couple of
> days to correct things if problems are found. I suggest a new branch be
> created off SVN TRUNK, which will later be merged back into TRUNK before
> the first 3.1 release, for this end. Corrective patches should be
> created against this branch.If there are objections to this plan, please
> make them known.
>
> I'll start reviewing the code tonight and intend to be done by the end
> of the weekend. More people looking into that code would be great.
> Around the same time I would like the new branch be created.
>
> Please let me know what you think
>
> Oleg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
>
>
--
[web] http://www.odi.ch/
[blog] http://www.odi.ch/weblog/
[pgp] key 0x81CF3416
finger print F2B1 B21F F056 D53E 5D79 A5AF 02BE 70F5 81CF 3416
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org