You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/16 09:55:10 UTC

[GitHub] [flink] xuyang1706 commented on issue #9413: [FLINK-13676][ml] Add class of Vector to Columns mapper

xuyang1706 commented on issue #9413: [FLINK-13676][ml] Add class of Vector to Columns mapper
URL: https://github.com/apache/flink/pull/9413#issuecomment-575073494
 
 
   > @xuyang1706 overall it looks good. I changed the `RowCollector` test bug in [walterddr@2cd2906](https://github.com/walterddr/flink/commit/2cd29067856ed2372a6186bfe03cdeb26e54dcb2) to get Travis pass. I just left minor comments. please kindly take a look.
   
   Thanks @walterddr for your comments and discussion. I have refined the code, renamed the test cases and added more JavaDoc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services