You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Дмитрий Рябов <so...@gmail.com> on 2017/04/05 08:12:14 UTC

IGNITE-2313 - ready for review

Hello, please review.

PR: https://github.com/apache/ignite/pull/1709/files
JIRA: https://issues.apache.org/jira/browse/IGNITE-2313
CI:
http://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests_RatJavadoc&branch_IgniteTests=pull%2F1709%2Fhead&tab=buildTypeStatusDiv

Re: IGNITE-2313 - ready for review

Posted by Дмитрий Рябов <so...@gmail.com>.
Em... sorry, always forgot about meaningful title(

Discussion? Yeah, I'll do it.

2017-04-05 22:15 GMT+03:00 Denis Magda <dm...@apache.org>:

> Dmitriy R., may I ask you to make a title and description of review
> request more meaningful? Looking at email's subject and body neither me nor
> anyone else have an idea what you ask to review. As a result most of
> community members will simply ignore your review request skipping the
> message. Don’t force people to go to JIRA ;)
>
> Igniters,
>
> This is the ticket to be reviewed: "Need to add a mode to fail atomic
> operations within a transaction”. Please review it.
>
> Dmitriy R., there was a relevant discussion around the ticket. Would you
> paste a link to it there?
>
> —
> Denis
>
>
> > On Apr 5, 2017, at 4:12 AM, Дмитрий Рябов <so...@gmail.com> wrote:
> >
> > Hello, please review.
> >
> > PR: https://github.com/apache/ignite/pull/1709/files
> > JIRA: https://issues.apache.org/jira/browse/IGNITE-2313
> > CI:
> > http://ci.ignite.apache.org/viewType.html?buildTypeId=
> IgniteTests_RatJavadoc&branch_IgniteTests=pull%2F1709%
> 2Fhead&tab=buildTypeStatusDiv
>
>

Re: IGNITE-2313 - ready for review

Posted by Denis Magda <dm...@apache.org>.
Dmitriy R., may I ask you to make a title and description of review request more meaningful? Looking at email's subject and body neither me nor anyone else have an idea what you ask to review. As a result most of community members will simply ignore your review request skipping the message. Don’t force people to go to JIRA ;)

Igniters,

This is the ticket to be reviewed: "Need to add a mode to fail atomic operations within a transaction”. Please review it.

Dmitriy R., there was a relevant discussion around the ticket. Would you paste a link to it there?

—
Denis


> On Apr 5, 2017, at 4:12 AM, Дмитрий Рябов <so...@gmail.com> wrote:
> 
> Hello, please review.
> 
> PR: https://github.com/apache/ignite/pull/1709/files
> JIRA: https://issues.apache.org/jira/browse/IGNITE-2313
> CI:
> http://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests_RatJavadoc&branch_IgniteTests=pull%2F1709%2Fhead&tab=buildTypeStatusDiv