You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "ASolarers-Rodriguez (via GitHub)" <gi...@apache.org> on 2026/08/18 15:32:19 UTC
[PR] fix(plugin-chart-chord): declare react as a peerDependency [superset]
ASolarers-Rodriguez opened a new pull request, #43304:
URL: https://github.com/apache/superset/pull/43304
### SUMMARY
`plugin-chart-chord` declares `react: ^19.2.7` in `dependencies`, while the app ships react 18.3.1. npm therefore installs a second, nested copy of React (19.2.8) under the plugin — visible in `package-lock.json` at `plugins/plugin-chart-chord/node_modules/react`.
Every sibling plugin declares react as a **peerDependency** instead (e.g. `plugin-chart-echarts`: `^18.3.0`), so the chord plugin is the only one bundling its own React. Besides being inconsistent, this:
- creates a latent dual-React hazard (two React copies in one webpack bundle can break hooks/context if the nested copy is ever resolved)
- makes SCA scanners (Black Duck, etc.) flag React 19.x advisories against Superset even though the app neither ships nor uses that copy
This PR moves react to `peerDependencies: "^18.3.0"` (matching the sibling convention) and removes the now-orphaned nested lockfile entry. `npm ci --dry-run` validates cleanly on node 24.16.0.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — dependency declaration only, no runtime behavior change (the plugin now resolves the same hoisted React the rest of the app uses).
### TESTING INSTRUCTIONS
- `npm ci` succeeds; `npm ls react` shows a single react 18.3.1 resolution
- Chord chart renders in Explore/dashboards as before
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(plugin-chart-chord): declare react as a peerDependency [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi merged PR #43304:
URL: https://github.com/apache/superset/pull/43304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(plugin-chart-chord): declare react as a peerDependency [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #43304:
URL: https://github.com/apache/superset/pull/43304#issuecomment-5330617863
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43304?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 66.63%. Comparing base ([`3c90bdc`](https://app.codecov.io/gh/apache/superset/commit/3c90bdc6f04c533167bd6f70b8bd2499416477e4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4d0ab71`](https://app.codecov.io/gh/apache/superset/commit/4d0ab71c593667bd75dad51e15de2ca702a97622?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #43304 +/- ##
=======================================
Coverage 66.63% 66.63%
=======================================
Files 2874 2874
Lines 163887 163887
Branches 37816 37816
=======================================
Hits 109209 109209
Misses 52535 52535
Partials 2143 2143
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/43304/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/43304/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.79% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43304?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(plugin-chart-chord): declare react as a peerDependency [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43304:
URL: https://github.com/apache/superset/pull/43304#issuecomment-5330432194
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(plugin-chart-chord): declare react as a peerDependency [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43304:
URL: https://github.com/apache/superset/pull/43304#issuecomment-5349502328
**Bito Automatic Review Skipped – PR Already Merged**<br/><br/>Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.<br/>No action is needed if you didn't intend to review it. To get a review, you can type `/review` in a comment and save it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org