[GitHub] [superset] rusackas commented on pull request #24012: fix(dashboard): Inoperable dashboard filter slider when range is <= 1

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #24012:
URL: https://github.com/apache/superset/pull/24012#issuecomment-1546146923

   Pinged a couple of reviewers, but I'm a little nervous that this might cause as many problems as it solves. If your data has a range of integers from 1-10, for example, then this would cause 20 steps in that range, and may cause queries to fail. 
   
   If this is intended specifically for values between 0 and 1, maybe an agreeable compromise is:
   `const step = max <= 1 ? stepHeuristic(min, max) : 1;`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org