You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/04 20:05:44 UTC
[GitHub] [airflow] potiuk opened a new pull request #11268: Improve running and canceliling of the PR-triggered builds.
potiuk opened a new pull request #11268:
URL: https://github.com/apache/airflow/pull/11268
The PR builds are now better handled with regards to both
running (using merge-request) and canceling (with cancel notifications).
First of all we are using merged commit from the PR, not the original commit
from the PR.
Secondly - the workflow run notifies the original PR with comment
stating that the image is being built in a separate workflow -
including the link to that workflow.
Thirdly - when canceling duplicate PRs or PRs with failed
jobs, the workflow will add a comment to the PR stating the
reason why the PR is being cancelled.
Last but not least, we also add cancel job for the CodeQL duplicate
messages. They run for ~ 12 miinutes so it makes perfect sense to
also cancel those CodeQL jobs for which someone pushed fixups in a
quick succession.
Fixes: #10471
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #11268: Improve running and cancelling of the PR-triggered builds.
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #11268:
URL: https://github.com/apache/airflow/pull/11268#issuecomment-703312391
LGTM!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #11268: Improve running and cancelling of the PR-triggered builds.
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #11268:
URL: https://github.com/apache/airflow/pull/11268
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11268: Improve running and canceliling of the PR-triggered builds.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11268:
URL: https://github.com/apache/airflow/pull/11268#issuecomment-703310069
On top of fixing the dreadful #10471 problem with merge PRs, this one adds useful, informative messages for contriibutors - directly in the PR comments.
You can see several examples of the PRs run on my private fork:
https://github.com/potiuk/airflow/pulls
Just a few screenshots:
This is a comment that will be automatically posted when PR starts. It supplements missing feature of GitHub to provide a link to 'workflow_run' triggered event: this way the PR creators will get the link to the "Build Image" workflow for their PR - directly as comment in the PR:
<img width="969" alt="Screenshot 2020-10-04 at 22 07 46" src="https://user-images.githubusercontent.com/595491/95025968-258c3380-068e-11eb-9b2b-1beecec3a2b7.png">
When they will get the image build failure, they will get this comment in their PR (they will be able to click trough to get:
<img width="958" alt="Screenshot 2020-10-04 at 22 11 25" src="https://user-images.githubusercontent.com/595491/95026039-ae0ad400-068e-11eb-9fe3-c95cb2a9be46.png">
Also, if there is a reason for cancelling a build (duplicate runs, failing jobs) the users will get a message as comment in their PRs, explaining why their PR builds got cancelled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org