[jira] Commented: (SCM-606) UnsupportedOperationException on blame GIT

["Mark Struberg (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/SCM-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=255592#action_255592 ] 

Mark Struberg commented on SCM-606:
-----------------------------------

the way to go is to implement this feature for the maven-scm-provider-gitexe also.
Will do this in the next week.

> UnsupportedOperationException on blame GIT
> ------------------------------------------
>
>                 Key: SCM-606
>                 URL: http://jira.codehaus.org/browse/SCM-606
>             Project: Maven SCM
>          Issue Type: Wish
>          Components: maven-scm-provider-git
>    Affects Versions: 1.4
>            Reporter: Fabien Bousquet
>            Assignee: Mark Struberg
>            Priority: Minor
>         Attachments: GitBlame_UnsupportedOperationException.patch
>
>
> Sometimes, running the blame command for GIT return an error for exit code. In this case, Maven SCM throw an
> UnsupportedOperationException :
> {code}
> Caused by: java.lang.UnsupportedOperationException
> at org.apache.maven.scm.provider.git.gitexe.command.blame.GitBlameCommand.executeBlameCommand(GitBlameCommand.java:46)
> etc...
> {code}
> Is it possible to have the same way that others providers (SVN or TFS for example) which is to return a 
> result (with a success to false) ?
> In other word replace :
> {code}
>   throw new UnsupportedOperationException();
> {code}
> by :
> {code}
> return new BlameScmResult(cl.toString(), "The git command failed.", stderr.getOutput(), false);
> {code}
> Another reason is that we do not know that this UnsupportedOperationException may be raised because is 
> a RuntimeException.
> A similar problem : http://jira.codehaus.org/browse/SONARPLUGINS-618 
> Do you agree with that ?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira