[GitHub] [incubator-superset] willbarrett commented on a change in pull request #9056: Do not show stacktraces on some intentionally-thrown errors

[GitBox <gi...@apache.org>]

willbarrett commented on a change in pull request #9056: Do not show stacktraces on some intentionally-thrown errors
URL: https://github.com/apache/incubator-superset/pull/9056#discussion_r374226728
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -1363,7 +1363,9 @@ def testconn(self):
         except Exception as e:
             logging.exception(e)
             return json_error_response(
-                "Connection failed!\n\n" "The error message returned was:\n{}".format(e)
+                "Connection failed!\n\n"
+                "The error message returned was:\n{}".format(e),
 
 Review comment:
   Yes, that clarifies it. Thank you!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org