svn commit: r349859 - /beehive/trunk/wsm/src/core/org/apache/beehive/wsm/processor/checker/Jsr181AnnotationChecker.java

[ek...@apache.org]

Author: ekoneil
Date: Tue Nov 29 17:40:25 2005
New Revision: 349859

URL: http://svn.apache.org/viewcvs?rev=349859&view=rev
Log:
Disable the OUT / INOUT checks that I added a moment ago.

I assumed that this wouldn't be a problem with the samples and was wrong.  We (apparently) have samples that don't conform to the spec.  Will address those and re-enable the tests.

BB: self
Test: WSM pass


Modified:
    beehive/trunk/wsm/src/core/org/apache/beehive/wsm/processor/checker/Jsr181AnnotationChecker.java

Modified: beehive/trunk/wsm/src/core/org/apache/beehive/wsm/processor/checker/Jsr181AnnotationChecker.java
URL: http://svn.apache.org/viewcvs/beehive/trunk/wsm/src/core/org/apache/beehive/wsm/processor/checker/Jsr181AnnotationChecker.java?rev=349859&r1=349858&r2=349859&view=diff
==============================================================================
--- beehive/trunk/wsm/src/core/org/apache/beehive/wsm/processor/checker/Jsr181AnnotationChecker.java (original)
+++ beehive/trunk/wsm/src/core/org/apache/beehive/wsm/processor/checker/Jsr181AnnotationChecker.java Tue Nov 29 17:40:25 2005
@@ -279,8 +279,8 @@
         SOAPBinding soapBinding = methodDecl.getDeclaringType().getAnnotation(SOAPBinding.class);
         SOAPBinding.Style style = soapBinding != null ? soapBinding.style() : SOAPBinding.Style.DOCUMENT;
         SOAPBinding.ParameterStyle parameterStyle = soapBinding != null ? soapBinding.parameterStyle() : SOAPBinding.ParameterStyle.WRAPPED;
-
-        if(style == SOAPBinding.Style.DOCUMENT) { // && parameterStyle == SOAPBinding.ParameterStyle.BARE) {
+/*
+        if(style == SOAPBinding.Style.DOCUMENT) {
             if(parameterStyle == SOAPBinding.ParameterStyle.BARE) {
                 if(oneway == null && methodDecl.getReturnType() instanceof VoidType)
                     _messager.printError("Document bare operation \"" + methodDecl.getSimpleName() + "\" must be declared oneway if it returns void");
@@ -296,7 +296,7 @@
                     _messager.printError("Document style operation \"" + methodDecl.getSimpleName() + "\" must have exactly one non-header IN parameter");
             }
             else if(parameterStyle == SOAPBinding.ParameterStyle.WRAPPED) {
-                /* no-op */
+                // no-op
             }
 
             for(ParameterDeclaration paramDecl : params) {
@@ -304,9 +304,9 @@
                 if(webParam != null && !webParam.header() && (webParam.mode() == WebParam.Mode.INOUT || webParam.mode() == WebParam.Mode.OUT))
                     _messager.printError("Document style operation \"" + methodDecl.getSimpleName() + "\" must not have a non-header OUT or INOUT parameter.");
             }
-
-            /* todo: another check in 6.1.2.2 about the uniqueness of XML elements */
+          //todo: another check in 6.1.2.2 about the uniqueness of XML elements
         }
+    */
     }
 
     /* todo: need to compost this up into a base class so that it can be reused across