[GitHub] [incubator-pinot] mayankshriv commented on issue #7185: Connection is not closed in pinot JAVA client using the close API

[GitBox <gi...@apache.org>]

mayankshriv commented on issue #7185:
URL: https://github.com/apache/incubator-pinot/issues/7185#issuecomment-884664962


   @khushbu14 I think there are two issues:
   - ZK connection is not being closed (as you pointed out)
   - The client in your case is perhaps opening one ZK connection per query. This is highly inefficient. At this point I am unclear on whether the same pinot client could be used across multiple threads. But assuming it cannot, the next best today would be to maintain one connection per thread in the executor service, and reuse it for all queries that the thread fires. Ideally, this should be part of pinot java client itself.
   
   @ramambme Could you investigate:
   - The ZK connection issue
   - If connection is thread/safe or not, to be used by multiple threads?
   - If it is not thread safe, can we provide a connection pool based client?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org