You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Dan Bentley <db...@google.com> on 2008/03/20 04:20:13 UTC

Review Board?

Missing web-based visual-diff code reviews, I've been paying around with
Review Board http://www.review-board.org/

It's pretty cool stuff.  I have it running on my machine, but now would love
to have a public instance running against shindig's svn.  Does anyone have
experience/ideas about getting a machine to run this on?

It depends on various python libraries being installed in root-owned
directories (roughly), so a machine where I can get root access without
being an unreasonable security risk is preferable.

Cheers, and thanks,
-Dan

Re: Review Board?

Posted by Santiago Gala <sa...@gmail.com>.
El jue, 20-03-2008 a las 22:31 +0000, Upayavira escribió:

> Apache does have some Solaris boxes that run Zones, but really they
> aren't for this kind of thing.
> 
> We've recently set up a mailing list, infrastructure-dev@apache.org,
> which is for discussing changes to Apache's infrastructure. If you want
> to pursue this on Apache's infrastructure, I'd suggest you go over there
> to discuss it. Having said that, having a demo to show over there of it
> running on one of your own boxes would certainly help any discussion.
> 
I commented on reviewboard, in case anyone is interested:
http://markmail.org/message/mpz2d7umvyz65uvy

Regards

> Regards, Upayavira
> 
> 
-- 
Santiago Gala
http://memojo.com/~sgala/blog/


Re: Review Board?

Posted by Upayavira <uv...@odoko.co.uk>.
On Thu, 2008-03-20 at 05:56 -0400, Dan Bentley wrote:
> On Thu, Mar 20, 2008 at 5:46 AM, Santiago Gala <sa...@gmail.com>
> wrote:
> 
> >
> > El mié, 19-03-2008 a las 23:20 -0400, Dan Bentley escribió:
> > > Missing web-based visual-diff code reviews, I've been paying around with
> > > Review Board http://www.review-board.org/
> > >
> >
> > I mostly use the git tools for code inspection. It works offline, it is
> > fast and free software.
> > http://github.com/sgala/apache-incubator-shindig/commits/master/ is a
> > copy of my repository. github can do visual diffs, see for instance
> >
> > http://github.com/sgala/apache-incubator-shindig/commit/3b94aa96495264a4b4aa48a4ed927642d263f754
> >
> > Apart from my "pending" cue of experiments or branches it should track
> > the current svn. And once cloned it is fairly easy to keep update both
> > from my clone or directly from subversion. While git-svn initial imports
> > are a bit stressful on the server,
> >
> >
> 
> > It does not have the "social" component, but it works for me.
> >
> 
> Yeah, I'd prefer not to have to learn another source control system.
> 
> 
> >
> > > It's pretty cool stuff.  I have it running on my machine, but now would
> > love
> > > to have a public instance running against shindig's svn.  Does anyone
> > have
> > > experience/ideas about getting a machine to run this on?
> > >
> >
> > I'm taking a look into the code. It is django and python, so it doesn't
> > look difficult to set up.
> >
> 
> Yeah, it's not at all, once you have things installed.
> 
> 
> >
> > > It depends on various python libraries being installed in root-owned
> > > directories (roughly), so a machine where I can get root access without
> > > being an unreasonable security risk is preferable.
> > >
> >
> > What are you trying to get? Any decent hosted site will offer you
> > python, with or without mod_fastcgi, mod_python or mod_wsgi, and the
> > ability to install the dependencies in your home. I don't think there is
> > any real need of root access, just CPU and bandwidth if it becomes
> > popular.
> >
> 
> Perhaps not root access.  Though python packages want to live in
> site-packages, I'm sure I could futz with pythonpath.  I more just wondered
> if there were servers through apache that I could run this on instead of
> setting up my own hosting account just for this.

Apache does have some Solaris boxes that run Zones, but really they
aren't for this kind of thing.

We've recently set up a mailing list, infrastructure-dev@apache.org,
which is for discussing changes to Apache's infrastructure. If you want
to pursue this on Apache's infrastructure, I'd suggest you go over there
to discuss it. Having said that, having a demo to show over there of it
running on one of your own boxes would certainly help any discussion.

Regards, Upayavira



Re: Review Board?

Posted by Dan Bentley <db...@google.com>.
On Thu, Mar 20, 2008 at 5:46 AM, Santiago Gala <sa...@gmail.com>
wrote:

>
> El mié, 19-03-2008 a las 23:20 -0400, Dan Bentley escribió:
> > Missing web-based visual-diff code reviews, I've been paying around with
> > Review Board http://www.review-board.org/
> >
>
> I mostly use the git tools for code inspection. It works offline, it is
> fast and free software.
> http://github.com/sgala/apache-incubator-shindig/commits/master/ is a
> copy of my repository. github can do visual diffs, see for instance
>
> http://github.com/sgala/apache-incubator-shindig/commit/3b94aa96495264a4b4aa48a4ed927642d263f754
>
> Apart from my "pending" cue of experiments or branches it should track
> the current svn. And once cloned it is fairly easy to keep update both
> from my clone or directly from subversion. While git-svn initial imports
> are a bit stressful on the server,
>
>

> It does not have the "social" component, but it works for me.
>

Yeah, I'd prefer not to have to learn another source control system.


>
> > It's pretty cool stuff.  I have it running on my machine, but now would
> love
> > to have a public instance running against shindig's svn.  Does anyone
> have
> > experience/ideas about getting a machine to run this on?
> >
>
> I'm taking a look into the code. It is django and python, so it doesn't
> look difficult to set up.
>

Yeah, it's not at all, once you have things installed.


>
> > It depends on various python libraries being installed in root-owned
> > directories (roughly), so a machine where I can get root access without
> > being an unreasonable security risk is preferable.
> >
>
> What are you trying to get? Any decent hosted site will offer you
> python, with or without mod_fastcgi, mod_python or mod_wsgi, and the
> ability to install the dependencies in your home. I don't think there is
> any real need of root access, just CPU and bandwidth if it becomes
> popular.
>

Perhaps not root access.  Though python packages want to live in
site-packages, I'm sure I could futz with pythonpath.  I more just wondered
if there were servers through apache that I could run this on instead of
setting up my own hosting account just for this.

Thanks,
-Dan


>
> Regards
> Santiago
>
> > Cheers, and thanks,
> > -Dan
> --
> Santiago Gala
> http://memojo.com/~sgala/blog/ <http://memojo.com/%7Esgala/blog/>
>
>

Re: Review Board?

Posted by Santiago Gala <sa...@gmail.com>.
El mié, 19-03-2008 a las 23:20 -0400, Dan Bentley escribió:
> Missing web-based visual-diff code reviews, I've been paying around with
> Review Board http://www.review-board.org/
> 

I mostly use the git tools for code inspection. It works offline, it is
fast and free software.
http://github.com/sgala/apache-incubator-shindig/commits/master/ is a
copy of my repository. github can do visual diffs, see for instance
http://github.com/sgala/apache-incubator-shindig/commit/3b94aa96495264a4b4aa48a4ed927642d263f754

Apart from my "pending" cue of experiments or branches it should track
the current svn. And once cloned it is fairly easy to keep update both
from my clone or directly from subversion. While git-svn initial imports
are a bit stressful on the server, 

It does not have the "social" component, but it works for me.

> It's pretty cool stuff.  I have it running on my machine, but now would love
> to have a public instance running against shindig's svn.  Does anyone have
> experience/ideas about getting a machine to run this on?
> 

I'm taking a look into the code. It is django and python, so it doesn't
look difficult to set up.

> It depends on various python libraries being installed in root-owned
> directories (roughly), so a machine where I can get root access without
> being an unreasonable security risk is preferable.
> 

What are you trying to get? Any decent hosted site will offer you
python, with or without mod_fastcgi, mod_python or mod_wsgi, and the
ability to install the dependencies in your home. I don't think there is
any real need of root access, just CPU and bandwidth if it becomes
popular.

Regards
Santiago

> Cheers, and thanks,
> -Dan
-- 
Santiago Gala
http://memojo.com/~sgala/blog/


Re: Review Board?

Posted by Dan Bentley <db...@google.com>.
Yeah, it just needs an svn server to point to.  Then you upload diffs to the
review board server, and you get web-based reviews.

Check out http://demo.review-board.org or
http://reviews.review-board.org/ .  The latter is their dogfood instance.

-Dan

On Thu, Mar 20, 2008 at 1:17 AM, <ih...@gmail.com> wrote:

> On Wed, Mar 19, 2008 at 10:14 PM, Dan Bentley <db...@google.com> wrote:
> > It's certainly possible to run one against code.google.com, but why when
> the
> >  code is on apache's svn?
>
> Sorry, I was not being clear. :/ This is OT for Shindig. Was just
> wondering about code.google.com projects.
>
> Thanks.
>
> Ihab
>
> --
> Ihab A.B. Awad, Palo Alto, CA
>

Re: Review Board?

Posted by ih...@gmail.com.
On Wed, Mar 19, 2008 at 10:14 PM, Dan Bentley <db...@google.com> wrote:
> It's certainly possible to run one against code.google.com, but why when the
>  code is on apache's svn?

Sorry, I was not being clear. :/ This is OT for Shindig. Was just
wondering about code.google.com projects.

Thanks.

Ihab

-- 
Ihab A.B. Awad, Palo Alto, CA

Re: Review Board?

Posted by Dan Bentley <db...@google.com>.
It's certainly possible to run one against code.google.com, but why when the
code is on apache's svn?

-Dan

On Thu, Mar 20, 2008 at 1:09 AM, <ih...@gmail.com> wrote:

> On Wed, Mar 19, 2008 at 8:20 PM, Dan Bentley <db...@google.com> wrote:
> >  It's pretty cool stuff.  I have it running on my machine, but now would
> love
> >  to have a public instance running against shindig's svn.
>
> Is there a chance of running one against code.google.com?
>
> Ihab
>
> --
> Ihab A.B. Awad, Palo Alto, CA
>

Re: Review Board?

Posted by ih...@gmail.com.
On Wed, Mar 19, 2008 at 8:20 PM, Dan Bentley <db...@google.com> wrote:
>  It's pretty cool stuff.  I have it running on my machine, but now would love
>  to have a public instance running against shindig's svn.

Is there a chance of running one against code.google.com?

Ihab

-- 
Ihab A.B. Awad, Palo Alto, CA

Re: Review Board?

Posted by Dan Bentley <db...@google.com>.
Good question:  Nope.  There's a lot of optimizations you can apparently
apply, so at some point memcached might be worth setting up.  But for now I
just need a machine that doesn't even need mysql (it can use sqlite).

-Dan

On Thu, Mar 20, 2008 at 12:55 AM, Kevin Brown <et...@google.com> wrote:

> Does it have to be on the same machine as the SVN repository? If not, I'm
> sure we can find some one or some organization to donate something.
>
> On Wed, Mar 19, 2008 at 8:20 PM, Dan Bentley <db...@google.com> wrote:
>
> > Missing web-based visual-diff code reviews, I've been paying around with
> > Review Board http://www.review-board.org/
> >
> > It's pretty cool stuff.  I have it running on my machine, but now would
> > love
> > to have a public instance running against shindig's svn.  Does anyone
> have
> > experience/ideas about getting a machine to run this on?
> >
> > It depends on various python libraries being installed in root-owned
> > directories (roughly), so a machine where I can get root access without
> > being an unreasonable security risk is preferable.
> >
> > Cheers, and thanks,
> > -Dan
> >
>
>
>
> --
> ~Kevin
>

Re: Review Board?

Posted by Kevin Brown <et...@google.com>.
Does it have to be on the same machine as the SVN repository? If not, I'm
sure we can find some one or some organization to donate something.

On Wed, Mar 19, 2008 at 8:20 PM, Dan Bentley <db...@google.com> wrote:

> Missing web-based visual-diff code reviews, I've been paying around with
> Review Board http://www.review-board.org/
>
> It's pretty cool stuff.  I have it running on my machine, but now would
> love
> to have a public instance running against shindig's svn.  Does anyone have
> experience/ideas about getting a machine to run this on?
>
> It depends on various python libraries being installed in root-owned
> directories (roughly), so a machine where I can get root access without
> being an unreasonable security risk is preferable.
>
> Cheers, and thanks,
> -Dan
>



-- 
~Kevin