You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by "devinjdangelo (via GitHub)" <gi...@apache.org> on 2024/04/20 13:03:43 UTC
[PR] minor: unparser cleanup and new roundtrip test [datafusion]
devinjdangelo opened a new pull request, #10150:
URL: https://github.com/apache/datafusion/pull/10150
## Which issue does this PR close?
related to #9726
## Rationale for this change
Unimplemented paths should error not panic. Match arms should be listed explicitly to make discovery of unimplemented paths easier, especially if new enum variants are added the compiler will identify them.
## What changes are included in this PR?
- Replaces some instances of todo!() with not_impl_err!()
- Explicitly lists all match arms for expr -> SQL expr
- Adds round trip SQL test that includes some of the newly added expressions
## Are these changes tested?
Yes
## Are there any user-facing changes?
No - other than preventing panic in some cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org
Re: [PR] minor: unparser cleanup and new roundtrip test [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #10150:
URL: https://github.com/apache/datafusion/pull/10150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org