[jira] [Updated] (WICKET-4909) ModalWindow overwrites window.onbeforeunload

["Jesse Bonzo (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-4909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse Bonzo updated WICKET-4909:
--------------------------------

    Attachment: windowOnBeforeUnloadFix.patch

This patch provides the desired behavior.
                
> ModalWindow overwrites window.onbeforeunload
> --------------------------------------------
>
>                 Key: WICKET-4909
>                 URL: https://issues.apache.org/jira/browse/WICKET-4909
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-extensions
>    Affects Versions: 6.3.0
>            Reporter: Jesse Bonzo
>            Priority: Minor
>              Labels: ajax, event, javascript, modal, wicket
>         Attachments: windowOnBeforeUnloadFix.patch
>
>
> If window.onbeforeunload is changed after a ModalWindow is opened the change is lost when the ModalWindow is closed. I expected calling ModalWindow#showUnloadConfirmation(false) would fix this, but the javascript for the modal window unconditionally overwrites window.onbeforeunload. I suggest checking settings.unloadConfirmation before overwriting window.onbeforeunload.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira