You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/08/14 16:20:31 UTC
[GitHub] [hive] soumyakanti3578 opened a new pull request #1404: [HIVE-23979|https://issues.apache.org/jira/browse/HIVE-23979] Resolve spotbugs errors in JsonReporter.java, Metrics.java, and PerfLogger.java
soumyakanti3578 opened a new pull request #1404:
URL: https://github.com/apache/hive/pull/1404
Resolving minor spotbugs errors in log/PerfLogger.java, metrics/[PerfLogger, Metrics, JsonReporter]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jcamachor commented on a change in pull request #1404: [HIVE-23979] Resolve spotbugs errors in JsonReporter.java, Metrics.java, and PerfLogger.java
Posted by GitBox <gi...@apache.org>.
jcamachor commented on a change in pull request #1404:
URL: https://github.com/apache/hive/pull/1404#discussion_r470726118
##########
File path: common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java
##########
@@ -148,7 +148,7 @@ public static void setPerfLogger(PerfLogger resetPerfLogger) {
* @param method method or ID that identifies this perf log element.
*/
@SuppressFBWarnings(value = "NM_METHOD_NAMING_CONVENTION", justification = "Intended")
Review comment:
Can this line be removed now? Same for few methods below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jcamachor commented on a change in pull request #1404: [HIVE-23979] Resolve spotbugs errors in JsonReporter.java, Metrics.java, and PerfLogger.java
Posted by GitBox <gi...@apache.org>.
jcamachor commented on a change in pull request #1404:
URL: https://github.com/apache/hive/pull/1404#discussion_r470726118
##########
File path: common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java
##########
@@ -148,7 +148,7 @@ public static void setPerfLogger(PerfLogger resetPerfLogger) {
* @param method method or ID that identifies this perf log element.
*/
@SuppressFBWarnings(value = "NM_METHOD_NAMING_CONVENTION", justification = "Intended")
Review comment:
Can this be removed now? Same for few methods below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] jcamachor merged pull request #1404: [HIVE-23979] Resolve spotbugs errors in JsonReporter.java, Metrics.java, and PerfLogger.java
Posted by GitBox <gi...@apache.org>.
jcamachor merged pull request #1404:
URL: https://github.com/apache/hive/pull/1404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] soumyakanti3578 commented on a change in pull request #1404: [HIVE-23979] Resolve spotbugs errors in JsonReporter.java, Metrics.java, and PerfLogger.java
Posted by GitBox <gi...@apache.org>.
soumyakanti3578 commented on a change in pull request #1404:
URL: https://github.com/apache/hive/pull/1404#discussion_r470726442
##########
File path: common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java
##########
@@ -148,7 +148,7 @@ public static void setPerfLogger(PerfLogger resetPerfLogger) {
* @param method method or ID that identifies this perf log element.
*/
@SuppressFBWarnings(value = "NM_METHOD_NAMING_CONVENTION", justification = "Intended")
Review comment:
Totally missed these! Thanks 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org