You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by joerg84 <gi...@git.apache.org> on 2017/01/11 14:41:13 UTC
[GitHub] flink pull request #3093: [FLINK-5444] Made Flink UI links relative.
GitHub user joerg84 opened a pull request:
https://github.com/apache/flink/pull/3093
[FLINK-5444] Made Flink UI links relative.
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joerg84/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3093.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3093
----
commit fa9b0c3642248d4329acb19bf0ac2ef461dbac66
Author: Joerg Schad <jo...@mesosphere.io>
Date: 2017-01-11T13:58:54Z
Made Flink UI links relative.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.
Posted by joerg84 <gi...@git.apache.org>.
Github user joerg84 commented on the issue:
https://github.com/apache/flink/pull/3093
Please retest!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3093
That looks better. I tried out these changes locally and they don't seem to break anything. Have you verifies yourself that this fixes the issue mentioned in the JIRA?
Still, I'd like other people's take on this, this is fickle stuff... @uce @iampeter @sachingoel0101.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3093: [FLINK-5444] Made Flink UI links relative.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3093
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3093: [FLINK-5444] Made Flink UI links relative.
Posted by joerg84 <gi...@git.apache.org>.
Github user joerg84 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3093#discussion_r95741031
--- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/submit/submit.ctrl.coffee ---
@@ -167,7 +167,7 @@ angular.module('flinkApp')
$scope.uploader['success'] = null
else
$scope.uploader['success'] = "Uploaded!"
- xhr.open("POST", "/jars/upload")
+ xhr.open("POST", "jars/upload")
--- End diff --
Thx, @sachingoel0101 could you provide me some more details on why that is preferrable? Happy to change it, just want to understand the details it :-).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.
Posted by joerg84 <gi...@git.apache.org>.
Github user joerg84 commented on the issue:
https://github.com/apache/flink/pull/3093
@zentol thanks and yes I verified the expected behavior.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3093: [FLINK-5444] Made Flink UI links relative.
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3093#discussion_r95740581
--- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/submit/submit.ctrl.coffee ---
@@ -167,7 +167,7 @@ angular.module('flinkApp')
$scope.uploader['success'] = null
else
$scope.uploader['success'] = "Uploaded!"
- xhr.open("POST", "/jars/upload")
+ xhr.open("POST", "jars/upload")
--- End diff --
Can you use `flinkConfig.jobServer + "jars/upload"` here? Otherwise, looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3093: [FLINK-5444] Made Flink UI links relative.
Posted by sachingoel0101 <gi...@git.apache.org>.
Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3093#discussion_r95749646
--- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/submit/submit.ctrl.coffee ---
@@ -167,7 +167,7 @@ angular.module('flinkApp')
$scope.uploader['success'] = null
else
$scope.uploader['success'] = "Uploaded!"
- xhr.open("POST", "/jars/upload")
+ xhr.open("POST", "jars/upload")
--- End diff --
Primarily, this makes all server side requests consistent. Further, if you check in index.coffee, the jobserver URL is set to empty for production, and a local host string for development purposes. This helps with streamlining dashboard dev without having to rebuild the maven modules again and again.
This particular case was disabling the dev on submit page. Best to get this in while you're fixing all urls.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.
Posted by joerg84 <gi...@git.apache.org>.
Github user joerg84 commented on the issue:
https://github.com/apache/flink/pull/3093
@zentol Thx! Could you check again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3093
These changes will be overridden the next time someone builds the web-dashboard. You have to modify the .jade files.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3093: [FLINK-5444] Made Flink UI links relative.
Posted by joerg84 <gi...@git.apache.org>.
Github user joerg84 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3093#discussion_r95783168
--- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/submit/submit.ctrl.coffee ---
@@ -167,7 +167,7 @@ angular.module('flinkApp')
$scope.uploader['success'] = null
else
$scope.uploader['success'] = "Uploaded!"
- xhr.open("POST", "/jars/upload")
+ xhr.open("POST", "jars/upload")
--- End diff --
Thx for the explanation!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.
Posted by joerg84 <gi...@git.apache.org>.
Github user joerg84 commented on the issue:
https://github.com/apache/flink/pull/3093
@sachingoel0101 PTAL
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3093: [FLINK-5444] Made Flink UI links relative.
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3093
Thanks! LGTM, going to merge this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---