You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/04/07 02:23:15 UTC
[kudu-CR] [consensus] fixed typos in consensus flags tagging
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6580
Change subject: [consensus] fixed typos in consensus flags tagging
......................................................................
[consensus] fixed typos in consensus flags tagging
Change-Id: I39fb954313368c8f612c986ab13dd47e8c948998
---
M src/kudu/consensus/consensus_peers.cc
1 file changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/6580/1
--
To view, visit http://gerrit.cloudera.org:8080/6580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39fb954313368c8f612c986ab13dd47e8c948998
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [consensus] fixed typos in consensus flags tagging
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [consensus] fixed typos in consensus flags tagging
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6580/1/src/kudu/consensus/consensus_peers.cc
File src/kudu/consensus/consensus_peers.cc:
Line 54: TAG_FLAG(raft_get_node_instance_timeout_ms, hidden);
> I meant line 50 makes it consensus_rpc_timeout advanced. If they wanted to
honestly I forget the intent (if I ever even knew it) but IMO it makes sense to have consensus_rpc_timeout_ms as advanced and not hidden as this more likely to be tweaked than raft_get_node_instance_timeout_ms
--
To view, visit http://gerrit.cloudera.org:8080/6580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39fb954313368c8f612c986ab13dd47e8c948998
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [consensus] fixed typos in consensus flags tagging
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [consensus] fixed typos in consensus flags tagging
......................................................................
[consensus] fixed typos in consensus flags tagging
Change-Id: I39fb954313368c8f612c986ab13dd47e8c948998
Reviewed-on: http://gerrit.cloudera.org:8080/6580
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/consensus/consensus_peers.cc
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I39fb954313368c8f612c986ab13dd47e8c948998
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [consensus] fixed typos in consensus flags tagging
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [consensus] fixed typos in consensus flags tagging
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6580/1/src/kudu/consensus/consensus_peers.cc
File src/kudu/consensus/consensus_peers.cc:
Line 54: TAG_FLAG(raft_get_node_instance_timeout_ms, hidden);
> honestly I forget the intent (if I ever even knew it) but IMO it makes sens
OK, thanks! Then this fix makes sense.
--
To view, visit http://gerrit.cloudera.org:8080/6580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39fb954313368c8f612c986ab13dd47e8c948998
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [consensus] fixed typos in consensus flags tagging
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [consensus] fixed typos in consensus flags tagging
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6580/1/src/kudu/consensus/consensus_peers.cc
File src/kudu/consensus/consensus_peers.cc:
Line 54: TAG_FLAG(raft_get_node_instance_timeout_ms, hidden);
You sure the intent was to make this flag hidden and not consensus_rpc_timeout_ms?
--
To view, visit http://gerrit.cloudera.org:8080/6580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39fb954313368c8f612c986ab13dd47e8c948998
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [consensus] fixed typos in consensus flags tagging
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [consensus] fixed typos in consensus flags tagging
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6580/1/src/kudu/consensus/consensus_peers.cc
File src/kudu/consensus/consensus_peers.cc:
Line 54: TAG_FLAG(raft_get_node_instance_timeout_ms, hidden);
> As I understand, consensus_rpc_timeout_ms is already hidden by correspondin
I meant line 50 makes it consensus_rpc_timeout advanced. If they wanted to hide it, then specifying 'advanced' when it's already marked 'hidden' would be too much.
But it's necessary to clarify, sure.
--
To view, visit http://gerrit.cloudera.org:8080/6580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39fb954313368c8f612c986ab13dd47e8c948998
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [consensus] fixed typos in consensus flags tagging
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [consensus] fixed typos in consensus flags tagging
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6580/1/src/kudu/consensus/consensus_peers.cc
File src/kudu/consensus/consensus_peers.cc:
Line 54: TAG_FLAG(raft_get_node_instance_timeout_ms, hidden);
> You sure the intent was to make this flag hidden and not consensus_rpc_time
As I understand, consensus_rpc_timeout_ms is already hidden by corresponding TAG_FLAG() macro at line 50. That's why I think it's a typo.
But it would be nice if David or Todd could confirm that, sure.
--
To view, visit http://gerrit.cloudera.org:8080/6580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39fb954313368c8f612c986ab13dd47e8c948998
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes