You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/03/13 16:11:34 UTC
[GitHub] [maven-compiler-plugin] pzygielo opened a new pull request #102: [MCOMPILER-402] Pass implicit configuration down to compiler
pzygielo opened a new pull request #102:
URL: https://github.com/apache/maven-compiler-plugin/pull/102
Needs
- https://github.com/codehaus-plexus/plexus-compiler/pull/202
or similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] olamy commented on pull request #102: [MCOMPILER-402] Pass `implicit` configuration down to compiler
Posted by GitBox <gi...@apache.org>.
olamy commented on pull request #102:
URL: https://github.com/apache/maven-compiler-plugin/pull/102#issuecomment-1069887523
> Changed my mind about updating example to _not needed_.
>
> Also - I think it was my mistake to use this ticket. Perhaps it would be better to have new _New feature_ linked to 402. And probably to close 402 as not an issue.
agree. a new jira as a feature would be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] olamy merged pull request #102: [MCOMPILER-488] dedicated option for `implicit` javac flag
Posted by GitBox <gi...@apache.org>.
olamy merged pull request #102:
URL: https://github.com/apache/maven-compiler-plugin/pull/102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #102: [MCOMPILER-402] Pass `implicit` configuration down to compiler
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #102:
URL: https://github.com/apache/maven-compiler-plugin/pull/102#issuecomment-1068875228
Changed my mind about updating example to _not needed_.
Also - I think it was my mistake to use this ticket. Perhaps it would be better to have new _New feature_ linked to 402. And probably to close 402 as not an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] olamy merged pull request #102: [MCOMPILER-488] dedicated option for `implicit` javac flag
Posted by GitBox <gi...@apache.org>.
olamy merged pull request #102:
URL: https://github.com/apache/maven-compiler-plugin/pull/102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #102: [MCOMPILER-402] Pass `implicit` configuration down to compiler
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #102:
URL: https://github.com/apache/maven-compiler-plugin/pull/102#issuecomment-1068851030
@olamy - thanks for checking (and pushing `plexus-*`es).
This has now completed GH workflow and is marked as ready for review.
I added [comment](https://issues.apache.org/jira/browse/MCOMPILER-402?focusedCommentId=17507407&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17507407) to MCOMPILER-402 to update [the example](https://maven.apache.org/plugins/maven-compiler-plugin/examples/module-info.html). Not sure about that, and I'd rather not have it in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #102: [MCOMPILER-488] dedicated option for `implicit` javac flag
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #102:
URL: https://github.com/apache/maven-compiler-plugin/pull/102#issuecomment-1070903801
Switched to new ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] pzygielo commented on pull request #102: [MCOMPILER-488] dedicated option for `implicit` javac flag
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #102:
URL: https://github.com/apache/maven-compiler-plugin/pull/102#issuecomment-1070903801
Switched to new ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] olamy edited a comment on pull request #102: [MCOMPILER-402] Pass `implicit` configuration down to compiler
Posted by GitBox <gi...@apache.org>.
olamy edited a comment on pull request #102:
URL: https://github.com/apache/maven-compiler-plugin/pull/102#issuecomment-1069887523
> Changed my mind about updating example to _not needed_.
>
> Also - I think it was my mistake to use this ticket. Perhaps it would be better to have new _New feature_ linked to 402. And probably to close 402 as not an issue.
agree. a new jira as a feature would be nice.
and an IT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] olamy commented on pull request #102: [MCOMPILER-402] Pass `implicit` configuration down to compiler
Posted by GitBox <gi...@apache.org>.
olamy commented on pull request #102:
URL: https://github.com/apache/maven-compiler-plugin/pull/102#issuecomment-1068757197
@pzygielo plexus-compiler changes merged and 2.11.2-SNAPSHOT so you can mark it as ready ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org