You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/08/01 09:18:52 UTC

[GitHub] [flink] dawidwys commented on issue #9297: [FLINK-13504][table] Fixed shading issues in table modules.

dawidwys commented on issue #9297: [FLINK-13504][table] Fixed shading issues in table modules.
URL: https://github.com/apache/flink/pull/9297#issuecomment-517202233
 
 
   Unfortunately this approach does not work.
   
   The problem is that when we relocate `flink-sql-parser` it uses the relocated guava classes. `flink-table-planner*` have direct dependency on calcite which pulls the unshaded versions of the same classes in tests (as tests are executed before shading). Therefore we cannot move the shading configuration to the `flink-table` module.
   
   I will close this PR in favor of a new approach (#9313 )

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services