You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by "rzhang10 (via GitHub)" <gi...@apache.org> on 2023/03/10 18:36:20 UTC

[GitHub] [gobblin] rzhang10 opened a new pull request, #3659: Add completion watermark to State

rzhang10 opened a new pull request, #3659:
URL: https://github.com/apache/gobblin/pull/3659

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-XXX
   
   
   ### Description
   This patch adds an additional map `tableToCompletedPartitions` in the `State` class where it stores the table partition completeness information in memory, so that it can be later shared/retrieved by other `MetadataWriter` impl in the framework.
   
   The data stored in `tableToCompletedPartitions` will be removed once consumed by other MetadataWriters, so that the `tableToCompletedPartitions` will not be growing indefinitely.
   
   ### Tests
   `gradle :gobblin-iceberg:test`
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] ZihanLi58 commented on a diff in pull request #3659: Add completion watermark to State

Posted by "ZihanLi58 (via GitHub)" <gi...@apache.org>.

ZihanLi58 commented on code in PR #3659:
URL: https://github.com/apache/gobblin/pull/3659#discussion_r1139395912


##########
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/writer/IcebergMetadataWriter.java:
##########
@@ -947,9 +950,14 @@ private long computeCompletenessWatermark(String table, SortedSet<ZonedDateTime>
         if (timestampDT.isAfter(prevWatermarkDT)
             && TimeIterator.durationBetween(prevWatermarkDT, now, granularity) > 0) {
           long timestampMillis = timestampDT.toInstant().toEpochMilli();
-          if (auditCountVerifier.get().isComplete(table,
-              TimeIterator.dec(timestampDT, granularity, 1).toInstant().toEpochMilli(), timestampMillis)) {
+          ZonedDateTime auditCountCheckLowerBoundDT = TimeIterator.dec(timestampDT, granularity, 1);
+          if (auditCountVerifier.get().isComplete(topicName,
+                  auditCountCheckLowerBoundDT.toInstant().toEpochMilli(), timestampMillis)) {
             completionWatermark = timestampMillis;
+            // Also persist the watermark into State object to share this with other MetadataWriters
+            // we enforce ourselves to always use lower-cased table name here
+            String catalogDbTableNameLowerCased = catalogDbTableName.toLowerCase(Locale.ROOT);
+            this.state.setProp(catalogDbTableNameLowerCased + ".watermark", completionWatermark);

Review Comment:
   Can we make "%.completeion.watermark" to a static regex string, then you can easily use that to re-construct a configuration key



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org