You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/10 15:09:53 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6409: mm: Add mm_uninitialize to release the resource
xiaoxiang781216 opened a new pull request, #6409:
URL: https://github.com/apache/incubator-nuttx/pull/6409
## Summary
## Impact
New API
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6409: mm: Add mm_uninitialize to release the resource
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6409:
URL: https://github.com/apache/incubator-nuttx/pull/6409#discussion_r894748927
##########
fs/procfs/fs_procfsmeminfo.c:
##########
@@ -582,4 +582,28 @@ void procfs_register_meminfo(FAR struct procfs_meminfo_entry_s *entry)
g_procfs_meminfo = entry;
}
+/****************************************************************************
+ * Name: procfs_unregister_meminfo
+ *
+ * Description:
+ * Remove a meminfo entry from the procfs file system.
+ *
+ * Input Parameters:
+ * entry - Describes the entry to be unregistered.
+ *
+ ****************************************************************************/
+
+void procfs_unregister_meminfo(FAR struct procfs_meminfo_entry_s *entry)
+{
+ FAR struct procfs_meminfo_entry_s **cur;
+
+ for (cur = &g_procfs_meminfo; *cur != NULL; cur = &cur->next)
Review Comment:
```suggestion
for (cur = g_procfs_meminfo; cur != NULL; cur = cur->next)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6409: mm: Add mm_uninitialize to release the resource
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6409:
URL: https://github.com/apache/incubator-nuttx/pull/6409#discussion_r894749417
##########
fs/procfs/fs_procfsmeminfo.c:
##########
@@ -582,4 +582,28 @@ void procfs_register_meminfo(FAR struct procfs_meminfo_entry_s *entry)
g_procfs_meminfo = entry;
}
+/****************************************************************************
+ * Name: procfs_unregister_meminfo
+ *
+ * Description:
+ * Remove a meminfo entry from the procfs file system.
+ *
+ * Input Parameters:
+ * entry - Describes the entry to be unregistered.
+ *
+ ****************************************************************************/
+
+void procfs_unregister_meminfo(FAR struct procfs_meminfo_entry_s *entry)
+{
+ FAR struct procfs_meminfo_entry_s **cur;
+
+ for (cur = &g_procfs_meminfo; *cur != NULL; cur = &cur->next)
Review Comment:
```suggestion
for (cur = &g_procfs_meminfo; *cur != NULL; cur = &(*cur)->next)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6409: mm: Add mm_uninitialize to release the resource
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6409:
URL: https://github.com/apache/incubator-nuttx/pull/6409#issuecomment-1153125278
@pkarashchenko could you merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 merged pull request #6409: mm: Add mm_uninitialize to release the resource
Posted by GitBox <gi...@apache.org>.
masayuki2009 merged PR #6409:
URL: https://github.com/apache/incubator-nuttx/pull/6409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6409: mm: Add mm_uninitialize to release the resource
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6409:
URL: https://github.com/apache/incubator-nuttx/pull/6409#discussion_r894775078
##########
fs/procfs/fs_procfsmeminfo.c:
##########
@@ -582,4 +582,28 @@ void procfs_register_meminfo(FAR struct procfs_meminfo_entry_s *entry)
g_procfs_meminfo = entry;
}
+/****************************************************************************
+ * Name: procfs_unregister_meminfo
+ *
+ * Description:
+ * Remove a meminfo entry from the procfs file system.
+ *
+ * Input Parameters:
+ * entry - Describes the entry to be unregistered.
+ *
+ ****************************************************************************/
+
+void procfs_unregister_meminfo(FAR struct procfs_meminfo_entry_s *entry)
+{
+ FAR struct procfs_meminfo_entry_s **cur;
+
+ for (cur = &g_procfs_meminfo; *cur != NULL; cur = &cur->next)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org