You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "JunRuiLee (via GitHub)" <gi...@apache.org> on 2024/10/11 12:05:09 UTC
[PR] [FLINK-36446][runtime] Refactor Job Submission Process to Use ExecutionPlan Instead of JobGraph. [flink]
JunRuiLee opened a new pull request, #25498:
URL: https://github.com/apache/flink/pull/25498
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
[FLINK-36446][runtime] Refactor Job Submission Process to Use ExecutionPlan Instead of JobGraph.
## Brief change log
[FLINK-36446][runtime] Refactor Job Submission Process to Use ExecutionPlan Instead of JobGraph.
## Verifying this change
This change is already covered by existing tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36446][runtime] Refactor Job Submission Process to Use ExecutionPlan Instead of JobGraph. [flink]
Posted by "zhuzhurk (via GitHub)" <gi...@apache.org>.
zhuzhurk merged PR #25498:
URL: https://github.com/apache/flink/pull/25498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36446][runtime] Refactor Job Submission Process to Use ExecutionPlan Instead of JobGraph. [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25498:
URL: https://github.com/apache/flink/pull/25498#issuecomment-2407277396
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4a80613cf6231f1faa48b7363cfbb6972a49b4d8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4a80613cf6231f1faa48b7363cfbb6972a49b4d8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a80613cf6231f1faa48b7363cfbb6972a49b4d8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36446][runtime] Refactor Job Submission Process to Use ExecutionPlan Instead of JobGraph. [flink]
Posted by "zhuzhurk (via GitHub)" <gi...@apache.org>.
zhuzhurk commented on code in PR #25498:
URL: https://github.com/apache/flink/pull/25498#discussion_r1797644232
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobManagerSharedServices.java:
##########
@@ -176,6 +187,11 @@ public static JobManagerSharedServices fromConfiguration(
Executors.newFixedThreadPool(
jobManagerIoPoolSize, new ExecutorThreadFactory("jobmanager-io"));
+ ExecutorService serializationExecutor =
+ Executors.newFixedThreadPool(
+ numberCPUCores,
+ new ExecutorThreadFactory("flink-operator-serialization-io"));
Review Comment:
What's this change for? Is it needed in this PR?
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java:
##########
@@ -515,20 +515,21 @@ private void stopDispatcherServices() throws Exception {
// ------------------------------------------------------
@Override
- public CompletableFuture<Acknowledge> submitJob(JobGraph jobGraph, Duration timeout) {
- final JobID jobID = jobGraph.getJobID();
+ public CompletableFuture<Acknowledge> submitJob(ExecutionPlan executionPlan, Duration timeout) {
+ final JobID jobID = executionPlan.getJobID();
try (MdcCloseable ignored = MdcUtils.withContext(MdcUtils.asContextData(jobID))) {
- log.info("Received JobGraph submission '{}' ({}).", jobGraph.getName(), jobID);
+ log.info(
+ "Received ExecutionPlan submission '{}' ({}).", executionPlan.getName(), jobID);
}
return isInGloballyTerminalState(jobID)
.thenComposeAsync(
isTerminated -> {
if (isTerminated) {
log.warn(
- "Ignoring JobGraph submission '{}' ({}) because the job already "
+ "Ignoring ExecutionPlan submission '{}' ({}) because the job already "
Review Comment:
ExecutionPlan -> job
##########
flink-tests/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterITCase.java:
##########
@@ -60,7 +60,7 @@ public void testRejectionOfEmptyJobGraphs() throws Exception {
miniCluster.getMiniCluster().submitJob(jobGraph).get();
fail("Expect failure");
} catch (Throwable t) {
- assertThat(t, containsMessage("The given job is empty"));
+ assertThat(t, containsMessage("The given execution plan is empty"));
Review Comment:
execution plan -> job
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java:
##########
@@ -515,20 +515,21 @@ private void stopDispatcherServices() throws Exception {
// ------------------------------------------------------
@Override
- public CompletableFuture<Acknowledge> submitJob(JobGraph jobGraph, Duration timeout) {
- final JobID jobID = jobGraph.getJobID();
+ public CompletableFuture<Acknowledge> submitJob(ExecutionPlan executionPlan, Duration timeout) {
+ final JobID jobID = executionPlan.getJobID();
try (MdcCloseable ignored = MdcUtils.withContext(MdcUtils.asContextData(jobID))) {
- log.info("Received JobGraph submission '{}' ({}).", jobGraph.getName(), jobID);
+ log.info(
+ "Received ExecutionPlan submission '{}' ({}).", executionPlan.getName(), jobID);
Review Comment:
ExecutionPlan -> job
I it's more common and user friendly.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/JobMasterServiceLeadershipRunnerFactory.java:
##########
@@ -64,19 +64,19 @@ public JobManagerRunner createJobManagerRunner(
long initializationTimestamp)
throws Exception {
- checkArgument(!jobGraph.isEmpty(), "The given job is empty");
+ checkArgument(!executionPlan.isEmpty(), "The given execution plan is empty");
Review Comment:
execution plan -> job
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobSubmitHeaders.java:
##########
@@ -26,6 +27,8 @@
import org.apache.flink.shaded.netty4.io.netty.handler.codec.http.HttpResponseStatus;
/** These headers define the protocol for submitting a job to a flink cluster. */
+@Documentation.ExcludeFromDocumentation(
+ "This API is not exposed to the users, as ExecutionPlan is used only internally.")
Review Comment:
-> "This API is for Flink client only and should not be exposed to users, as it relies on internal classes."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org