You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2023/01/09 18:22:21 UTC
[GitHub] [lucene] jpountz opened a new issue, #12068: Is it right to throttle the creation of compound files?
jpountz opened a new issue, #12068:
URL: https://github.com/apache/lucene/issues/12068
### Description
Our current merge throttling implementation also covers the creation of the compound file when `MergePolicy#useCompoundFile` returns true. But I don't think it is right and I suspect that it was not done intentionally:
- My understanding is that merge throttling does not generally try to throttle I/O, e.g. integrity checks are not throttled. It mostly uses written bytes as a best-effort proxy for the amount of CPU spent on merging, so that merges leave CPU for searches.
- The page cache has protection against long sequential reads/writes from completely trashing the filesystem cache.
@mikemccand Do you know if this was intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz closed issue #12068: Is it right to throttle the creation of compound files?
Posted by GitBox <gi...@apache.org>.
jpountz closed issue #12068: Is it right to throttle the creation of compound files?
URL: https://github.com/apache/lucene/issues/12068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on issue #12068: Is it right to throttle the creation of compound files?
Posted by GitBox <gi...@apache.org>.
jpountz commented on issue #12068:
URL: https://github.com/apache/lucene/issues/12068#issuecomment-1377296297
I wanted to see if any tests would fail if I would remove throttling when creating compound files, and none did, so I opened a PR. I'm still interested in thoughts regarding whether this was intentional or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org