You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/02 13:17:31 UTC
[GitHub] tillrohrmann commented on a change in pull request #6786:
[FLINK-10292][rest] Separate REST and Dispatcher RPC thread pools
tillrohrmann commented on a change in pull request #6786: [FLINK-10292][rest] Separate REST and Dispatcher RPC thread pools
URL: https://github.com/apache/flink/pull/6786#discussion_r221943598
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java
##########
@@ -714,6 +717,7 @@ public void startInternal() throws Exception {
@Override
protected CompletableFuture<Void> shutDownInternal() {
executionGraphCache.close();
+ ExecutorUtils.gracefulShutdown(10, TimeUnit.SECONDS, executor);
Review comment:
I think we should shut down the `executor` after shutting down the handlers. Otherwise we might run into the situation that a handler tries to add something to a closed `Executor`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services