[jira] [Commented] (CB-8627) 'cordova plugin add git_url' erroneously updates fetch.json even when the 'add operation fails'

["Omar Mefire (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351088#comment-14351088 ] 

Omar Mefire commented on CB-8627:
---------------------------------

This error also manifests itself with folders : `cordova plugin add ~/phonegap-facebook-plugin/`

> 'cordova plugin add git_url' erroneously updates fetch.json even when the 'add operation fails'
> -----------------------------------------------------------------------------------------------
>
>                 Key: CB-8627
>                 URL: https://issues.apache.org/jira/browse/CB-8627
>             Project: Apache Cordova
>          Issue Type: Bug
>            Reporter: Omar Mefire
>
> Trying to add the facebookconnect plugin, with missing variables results in :
> - cordova plugin add com.phonegap.plugins.facebookconnect
>     This results in an error message, as expected: 'Variable(s) missing (use: --variable APP_ID=value --variable APP_NAME=value). and as expected, fetch.json is not updated with the plugin info.
> However, trying to add the same plugin by using its github repository yields the following result : 
> - cordova plugin add https://github.com/Wizcorp/phonegap-facebook-plugin.git
>     This results in fetch.json being updated with the plugin info even though the plugin installation failed. It should not be the case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org