[GitHub] [tvm] areusch commented on a diff in pull request #11987: [release] Follow ups from v0.9.0 - scripts, docs

[GitBox <gi...@apache.org>]

areusch commented on code in PR #11987:
URL: https://github.com/apache/tvm/pull/11987#discussion_r931617980


##########
docs/contribute/release_process.rst:
##########
@@ -54,6 +54,12 @@ Release note contains new features, improvement, bug fixes, known issues and dep
 It is recommended to open a Github issue to collect feedbacks for the release note draft before cutting the release branch.

Review Comment:
   should we crosslink to tests/scripts/release/README.md here?



##########
tests/scripts/release/README.md:
##########
@@ -0,0 +1,42 @@
+<!--- Licensed to the Apache Software Foundation (ASF) under one -->
+<!--- or more contributor license agreements.  See the NOTICE file -->
+<!--- distributed with this work for additional information -->
+<!--- regarding copyright ownership.  The ASF licenses this file -->
+<!--- to you under the Apache License, Version 2.0 (the -->
+<!--- "License"); you may not use this file except in compliance -->
+<!--- with the License.  You may obtain a copy of the License at -->
+
+<!---   http://www.apache.org/licenses/LICENSE-2.0 -->
+
+<!--- Unless required by applicable law or agreed to in writing, -->
+<!--- software distributed under the License is distributed on an -->
+<!--- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -->
+<!--- KIND, either express or implied.  See the License for the -->
+<!--- specific language governing permissions and limitations -->
+<!--- under the License. -->
+
+These scripts can be helpful when creating release notes.

Review Comment:
   do we need to mention GITHUB_TOKEN?



##########
docs/contribute/release_process.rst:
##########
@@ -111,16 +117,16 @@ Create source code artifacts,
 
 .. code-block:: bash
 
-	git clone git@github.com:apache/tvm.git apache-tvm-src-v0.6.0.rc0
-	cd apache-tvm-src-v0.6.0.rc0
+	git clone git@github.com:apache/tvm.git apache-tvm-src-v0.6.0

Review Comment:
   since folks are gonna replace the version number, maybe we should add a note to explain this change explicitly above?



##########
tests/scripts/release/.gitignore:
##########
@@ -0,0 +1,5 @@
+*.md

Review Comment:
   maybe this should be tools/release/ or release/?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org