You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by GitBox <gi...@apache.org> on 2023/01/06 11:54:12 UTC
[GitHub] [geronimo-txmanager] rzo1 opened a new pull request, #8: Migrate to Jakarta Namespace
rzo1 opened a new pull request, #8:
URL: https://github.com/apache/geronimo-txmanager/pull/8
Hi all,
don't know, what the future will be, but I did switch from Javax to Jakarta namespace (for EE10) and updated the related spec versions. I don't know, what the plan for Geronimo provided spec jars will be, so for now, I switched to the API jars provided by the eclipse foundation.
Did switch to 4.0.0-SNAPSHOT to indicate namespace switch; would be neat to switch to Java 11 but that seems to be blocked by the Genesis parent, so likely there is the need for a Java 11 parent?
I also didn't run the sigtests / tcks yet, still fiddling around on how to set them up locally and don't know, what the general status for them looks like.
Changes between EE9 to EE10 are (at a first glance) pretty minor for these two
- https://jakarta.ee/specifications/connectors/2.1/
- https://jakarta.ee/specifications/transactions/2.0/
But any thoughts / ideas are welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] rzo1 commented on a diff in pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
Posted by GitBox <gi...@apache.org>.
rzo1 commented on code in PR #8:
URL: https://github.com/apache/geronimo-txmanager/pull/8#discussion_r1066697045
##########
pom.xml:
##########
@@ -62,45 +62,45 @@
<dependency>
<groupId>org.apache.geronimo.components</groupId>
<artifactId>geronimo-transaction</artifactId>
- <version>3.1.6-SNAPSHOT</version>
+ <version>4.0.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.components</groupId>
<artifactId>geronimo-connector</artifactId>
- <version>3.1.6-SNAPSHOT</version>
+ <version>4.0.0-SNAPSHOT</version>
</dependency>
<!-- external -->
<dependency>
Review Comment:
I am fine to migrate the slf4j dep to jul.
##########
pom.xml:
##########
@@ -62,45 +62,45 @@
<dependency>
<groupId>org.apache.geronimo.components</groupId>
<artifactId>geronimo-transaction</artifactId>
- <version>3.1.6-SNAPSHOT</version>
+ <version>4.0.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.components</groupId>
<artifactId>geronimo-connector</artifactId>
- <version>3.1.6-SNAPSHOT</version>
+ <version>4.0.0-SNAPSHOT</version>
</dependency>
<!-- external -->
<dependency>
Review Comment:
I am fine to migrate slf4j to jul.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] rzo1 commented on a diff in pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
Posted by GitBox <gi...@apache.org>.
rzo1 commented on code in PR #8:
URL: https://github.com/apache/geronimo-txmanager/pull/8#discussion_r1066727262
##########
pom.xml:
##########
@@ -62,45 +62,45 @@
<dependency>
<groupId>org.apache.geronimo.components</groupId>
<artifactId>geronimo-transaction</artifactId>
- <version>3.1.6-SNAPSHOT</version>
+ <version>4.0.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.components</groupId>
<artifactId>geronimo-connector</artifactId>
- <version>3.1.6-SNAPSHOT</version>
+ <version>4.0.0-SNAPSHOT</version>
</dependency>
<!-- external -->
<dependency>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] rzo1 commented on pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #8:
URL: https://github.com/apache/geronimo-txmanager/pull/8#issuecomment-1378394073
> As mentionned in the ticket think we don't need GERONIMO-6845, however we need to validate we use jakarta artifact and complete the migration of spec jars before being able to merge the change.
I am fine with either using the java11 flava thing or apache-parent directly. Whatever the project wants to use.
Yup - there is an ongoing discussion on the list regarding the spec jars, if I remember correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] rzo1 commented on pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #8:
URL: https://github.com/apache/geronimo-txmanager/pull/8#issuecomment-1378367735
Genesis Parent: https://issues.apache.org/jira/browse/GERONIMO-6845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] rzo1 commented on a diff in pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
Posted by GitBox <gi...@apache.org>.
rzo1 commented on code in PR #8:
URL: https://github.com/apache/geronimo-txmanager/pull/8#discussion_r1067025406
##########
.github/workflows/maven.yml:
##########
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Java CI
+
+on: [push, pull_request]
+
+jobs:
+ build:
+ runs-on: ${{ matrix.os }}
+ continue-on-error: ${{ matrix.experimental }}
+ strategy:
+ matrix:
+ os: [ubuntu-latest]
+ java: [ 11 ]
Review Comment:
https://issues.apache.org/jira/browse/GERONIMO-6847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] rmannibucau commented on a diff in pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on code in PR #8:
URL: https://github.com/apache/geronimo-txmanager/pull/8#discussion_r1066690285
##########
pom.xml:
##########
@@ -62,45 +62,45 @@
<dependency>
<groupId>org.apache.geronimo.components</groupId>
<artifactId>geronimo-transaction</artifactId>
- <version>3.1.6-SNAPSHOT</version>
+ <version>4.0.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.components</groupId>
<artifactId>geronimo-connector</artifactId>
- <version>3.1.6-SNAPSHOT</version>
+ <version>4.0.0-SNAPSHOT</version>
</dependency>
<!-- external -->
<dependency>
Review Comment:
think the new major is the opportunity to ditch this required dep and migrate to jul for consistency with the other stacks and new API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] jeanouii commented on pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
Posted by GitBox <gi...@apache.org>.
jeanouii commented on PR #8:
URL: https://github.com/apache/geronimo-txmanager/pull/8#issuecomment-1378710169
Looks good to me. I'll merge it for you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] jeanouii commented on a diff in pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
Posted by GitBox <gi...@apache.org>.
jeanouii commented on code in PR #8:
URL: https://github.com/apache/geronimo-txmanager/pull/8#discussion_r1066964549
##########
geronimo-connector/src/main/java/org/apache/geronimo/connector/outbound/AbstractSinglePoolConnectionInterceptor.java:
##########
@@ -24,21 +24,20 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.locks.ReadWriteLock;
import java.util.concurrent.locks.ReentrantReadWriteLock;
+import java.util.logging.Level;
+import java.util.logging.Logger;
-import javax.resource.ResourceException;
-import javax.resource.spi.ConnectionRequestInfo;
-import javax.resource.spi.ManagedConnection;
-import javax.resource.spi.ManagedConnectionFactory;
+import jakarta.resource.ResourceException;
+import jakarta.resource.spi.ConnectionRequestInfo;
+import jakarta.resource.spi.ManagedConnection;
+import jakarta.resource.spi.ManagedConnectionFactory;
import javax.security.auth.Subject;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
/**
* @version $Rev$ $Date$
*/
public abstract class AbstractSinglePoolConnectionInterceptor implements ConnectionInterceptor, PoolingAttributes {
- protected static Logger log = LoggerFactory.getLogger(AbstractSinglePoolConnectionInterceptor.class);
+ protected static Logger log = Logger.getLogger(AbstractSinglePoolConnectionInterceptor.class.getName());
Review Comment:
I'd also make a small ticket for this component to have the logger switch to JUL
##########
pom.xml:
##########
@@ -113,102 +95,70 @@
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
- <version>3.8.2</version>
+ <version>4.13.2</version>
<scope>test</scope>
</dependency>
</dependencies>
</dependencyManagement>
- <profiles>
- <profile>
- <id>java8-doclint-disabled</id>
- <activation>
- <jdk>[1.8,)</jdk>
- </activation>
-
- <properties>
- <additionalparam>-Xdoclint:none</additionalparam>
- <javadoc.opts>-Xdoclint:none</javadoc.opts>
- </properties>
- </profile>
- </profiles>
<build>
<pluginManagement>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <source>11</source>
Review Comment:
I'd use the new release attribute
##########
pom.xml:
##########
@@ -113,102 +95,70 @@
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
- <version>3.8.2</version>
+ <version>4.13.2</version>
<scope>test</scope>
</dependency>
</dependencies>
</dependencyManagement>
- <profiles>
- <profile>
- <id>java8-doclint-disabled</id>
- <activation>
- <jdk>[1.8,)</jdk>
- </activation>
-
- <properties>
- <additionalparam>-Xdoclint:none</additionalparam>
- <javadoc.opts>-Xdoclint:none</javadoc.opts>
- </properties>
- </profile>
- </profiles>
<build>
<pluginManagement>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <source>11</source>
+ <target>11</target>
+ </configuration>
+ </plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
- <version>2.9</version>
<executions>
<execution>
<id>attach-javadocs</id>
<goals>
<goal>jar</goal>
</goals>
<configuration>
- <additionalparam>${javadoc.opts}</additionalparam>
+ <quiet>true</quiet>
+ <source>11</source>
Review Comment:
I think there is a release attribute as well
##########
geronimo-connector/src/main/java/org/apache/geronimo/connector/outbound/AbstractSinglePoolConnectionInterceptor.java:
##########
@@ -24,21 +24,20 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.locks.ReadWriteLock;
import java.util.concurrent.locks.ReentrantReadWriteLock;
+import java.util.logging.Level;
+import java.util.logging.Logger;
-import javax.resource.ResourceException;
-import javax.resource.spi.ConnectionRequestInfo;
-import javax.resource.spi.ManagedConnection;
-import javax.resource.spi.ManagedConnectionFactory;
+import jakarta.resource.ResourceException;
+import jakarta.resource.spi.ConnectionRequestInfo;
+import jakarta.resource.spi.ManagedConnection;
+import jakarta.resource.spi.ManagedConnectionFactory;
import javax.security.auth.Subject;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
/**
* @version $Rev$ $Date$
*/
public abstract class AbstractSinglePoolConnectionInterceptor implements ConnectionInterceptor, PoolingAttributes {
- protected static Logger log = LoggerFactory.getLogger(AbstractSinglePoolConnectionInterceptor.class);
+ protected static Logger log = Logger.getLogger(AbstractSinglePoolConnectionInterceptor.class.getName());
Review Comment:
Haven't seen SLF4J dependency removed. Maybe we were using a transitive dependency as compile
##########
.github/workflows/maven.yml:
##########
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Java CI
+
+on: [push, pull_request]
+
+jobs:
+ build:
+ runs-on: ${{ matrix.os }}
+ continue-on-error: ${{ matrix.experimental }}
+ strategy:
+ matrix:
+ os: [ubuntu-latest]
+ java: [ 11 ]
Review Comment:
I'd create a ticket for this component to mention the Java 11 version as being the minimum required version from now on so it appears in the release notes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] rzo1 commented on pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #8:
URL: https://github.com/apache/geronimo-txmanager/pull/8#issuecomment-1378651316
Ok did the switch to Apache Parent v29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] jeanouii merged pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
Posted by GitBox <gi...@apache.org>.
jeanouii merged PR #8:
URL: https://github.com/apache/geronimo-txmanager/pull/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geronimo-txmanager] rmannibucau commented on pull request #8: GERONIMO-6844 - Migrate to Jakarta Namespace
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on PR #8:
URL: https://github.com/apache/geronimo-txmanager/pull/8#issuecomment-1378384552
As mentionned in the ticket think we don't need GERONIMO-6845, however we need to validate we use jakarta artifact and complete the migration of spec jars before being able to merge the change.
Except the slf4j and this "move task" +1 from me once they are both done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@geronimo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org