You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/03/17 09:33:17 UTC
[GitHub] [echarts] plainheart opened a new pull request #16691: fix(dataview): fix unexpected scrollbar and outline when using default textview
plainheart opened a new pull request #16691:
URL: https://github.com/apache/echarts/pull/16691
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Optimize the default textview style to fix unexpected scrollbar and outline.
## Comparison
| Before | After |
| :----: | :----: |
| <img width="400" alt="mac" src="https://user-images.githubusercontent.com/26999792/158779494-6a7182e0-e747-4061-83f3-b7d3f4ef0f9b.png"> | <img width="400" alt="mac" src="https://user-images.githubusercontent.com/26999792/158779509-28f31d8f-7c84-4627-a726-b720334be728.png"> |
| <img width="400" alt="windows" src="https://user-images.githubusercontent.com/26999792/158780002-0a7471e3-6775-4e0b-8fd6-4dedd9504ca5.png"> | <img width="400" alt="windows" src="https://user-images.githubusercontent.com/26999792/158779674-fb513d60-62b7-4d49-81f3-5d82d7d61f90.png"> |
## Misc
<!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
- [ ] The API has been changed (apache/echarts-doc#xxx).
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
Please refer to `test/dataZoom-toolbox.html`
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #16691: fix(dataview): fix unexpected scrollbar and outline when using default textview
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #16691:
URL: https://github.com/apache/echarts/pull/16691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #16691: fix(dataview): fix unexpected scrollbar and outline when using default textview
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #16691:
URL: https://github.com/apache/echarts/pull/16691#issuecomment-1071991606
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #16691: fix(dataview): fix unexpected scrollbar and outline when using default textview
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #16691:
URL: https://github.com/apache/echarts/pull/16691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #16691: fix(dataview): fix unexpected scrollbar and outline when using default textview
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #16691:
URL: https://github.com/apache/echarts/pull/16691#discussion_r829666886
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
Thanks for the explanation. Didn't aware the default display of textarea is `inline-block`. Perhaps setting `display` to `block` will be better? I'm not sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a change in pull request #16691: fix(dataview): fix unexpected scrollbar and outline when using default textview
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #16691:
URL: https://github.com/apache/echarts/pull/16691#discussion_r829665688
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
This is to remove the unexpected gap to avoid the scrollbar since the default `display` of `textarea` is `inline-block`. Of course, we can also set `display` as `block`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #16691: fix(dataview): fix unexpected scrollbar and outline when using default textview
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #16691:
URL: https://github.com/apache/echarts/pull/16691#discussion_r829666886
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
Thanks for the explaination. Didn't aware the default display of textarea is `inline-block`. Perhaps setting `display` to `block` will be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #16691: fix(dataview): fix unexpected scrollbar and outline when using default textview
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #16691:
URL: https://github.com/apache/echarts/pull/16691#discussion_r829630324
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
I'm not sure if this `vertical-align:middle;` is necessary.
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
Didn't aware the default display of textarea is `inline-block`. Perhaps setting `display` to `block` will be better?
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
Thanks for the explaination. Didn't aware the default display of textarea is `inline-block`. Perhaps setting `display` to `block` will be better?
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
Thanks for the explaination. Didn't aware the default display of textarea is `inline-block`. Perhaps setting `display` to `block` will be better? I'm not sure
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
Thanks for the explanation. Didn't aware the default display of textarea is `inline-block`. Perhaps setting `display` to `block` will be better? I'm not sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #16691: fix(dataview): fix unexpected scrollbar and outline when using default textview
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #16691:
URL: https://github.com/apache/echarts/pull/16691#issuecomment-1071991606
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a change in pull request #16691: fix(dataview): fix unexpected scrollbar and outline when using default textview
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #16691:
URL: https://github.com/apache/echarts/pull/16691#discussion_r829665688
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
This is to remove the expected gap to avoid the scrollbar since the default `display` of `textarea` is `inline-block`. Of course, we can also set `display` as `block`.
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
Sure.
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
This is to remove the unexpected gap to avoid the scrollbar since the default `display` of `textarea` is `inline-block`. Of course, we can also set `display` as `block`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #16691: fix(dataview): fix unexpected scrollbar and outline when using default textview
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #16691:
URL: https://github.com/apache/echarts/pull/16691#discussion_r829630324
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
I'm not sure if this `vertical-align:middle;` is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a change in pull request #16691: fix(dataview): fix unexpected scrollbar and outline when using default textview
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #16691:
URL: https://github.com/apache/echarts/pull/16691#discussion_r829667067
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #16691: fix(dataview): fix unexpected scrollbar and outline when using default textview
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #16691:
URL: https://github.com/apache/echarts/pull/16691#discussion_r829666886
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
Thanks for the explaination. Didn't aware the default display of textarea is `inline-block`. Perhaps setting `display` to `block` will be better? I'm not sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #16691: fix(dataview): fix unexpected scrollbar and outline when using default textview
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #16691:
URL: https://github.com/apache/echarts/pull/16691#issuecomment-1070632369
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a change in pull request #16691: fix(dataview): fix unexpected scrollbar and outline when using default textview
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #16691:
URL: https://github.com/apache/echarts/pull/16691#discussion_r829665688
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
This is to remove the expected gap to avoid the scrollbar since the default `display` of `textarea` is `inline-block`. Of course, we can also set `display` as `block`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #16691: fix(dataview): fix unexpected scrollbar and outline when using default textview
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #16691:
URL: https://github.com/apache/echarts/pull/16691#discussion_r829666886
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText = 'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
Didn't aware the default display of textarea is `inline-block`. Perhaps setting `display` to `block` will be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org