You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by mikewalch <gi...@git.apache.org> on 2016/10/25 14:47:03 UTC
[GitHub] accumulo pull request #170: ACCUMULO-4503 Added blog to project website
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/170
ACCUMULO-4503 Added blog to project website
* Upgraded bootstrap
* Changed website theme
* Redesigned home page
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mikewalch/accumulo accumulo-4503
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/170.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #170
----
commit baa5fb287c98de21a43b77b8e9f61c70e4823dac
Author: Mike Walch <mw...@apache.org>
Date: 2016-10-25T13:42:30Z
ACCUMULO-4503 Upgraded Bootstrap and changed theme
* Upgraded Bootstrap to v3.3.7
* Changed to theme to Bootswatch Readable (MIT license)
* Removed unused dataTables code and main.scss
commit b14b97216ecc3f36c8869e60481aa4f78cba3fa6
Author: Mike Walch <mw...@apache.org>
Date: 2016-10-25T14:33:44Z
ACCUMULO-4503 Added blog to website
* Redesigned home page and added latest news
* Copied blog posts from external ASF-hosted blog
* Removed links to external blog
* Created news archive
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #170: ACCUMULO-4503 Added blog to project website
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on the issue:
https://github.com/apache/accumulo/pull/170
For the blog post, could include a link to the original post along with a sentence stating it was copied. This could be at the end of the post.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #170: ACCUMULO-4503 Added blog to project website
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/170
@joshelser, with this pull request, I am trying to mimic what has been done on the Apache Fluo website. The Fluo website has two kinds of Jekyll posts (blog and release). Blog posts are self-explanatory. Release posts contain the release notes for the release and links to resources (binary tarball, docs, javadocs, etc) for that release. Below are examples each post type:
https://fluo.apache.org/blog/2016/06/02/fluo-moving-to-apache/
https://fluo.apache.org/release/fluo-1.0.0-incubating/
When you go to https://fluo.apache.org/news/, you see all posts (blog & release). This was done to avoid creating two posts (a release post and a blog post announcing the release). When you go https://fluo.apache.org/release/, you only see releases (the pre-apache releases have been excluded). Currently, the page https://fluo.apache.org/blog/ redirects to /news/ but it could show only blog posts. This system has made releases easier to Fluo. You just need to create one markdown document and the release will show up in 3 locations automatically ( 'latest news' on main page, the news archive '/news/', and release archive '/release/').
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #170: ACCUMULO-4503 Added blog to project website
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/170
> I'll let this sit overnight for additional reviews, then merge tomorrow
Deployed locally and saw all posts are called the "news archive". Seems confusing to me to use both the term "blog" and "news". Also, I would have expected to find the archives at "/blog", but that is just an directory listing. The archives are actually at "/news". This is a little nit-picky, I know. If it's something simple that can be changed, I think it would be beneficial. However, if it's going to go against the grain of what Jekyll wants you to do, I'm not going to get upset over it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #170: ACCUMULO-4503 Added blog to project website
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/170
> The Fluo website has two kinds of Jekyll posts (blog and release). Blog posts are self-explanatory. Release posts contain the release notes for the release and links to resources (binary tarball, docs, javadocs, etc) for that release.
Aha, this makes sense now. Thanks for the explanation.
> Currently, the page https://fluo.apache.org/blog/ redirects to /news/ but it could show only blog posts.
That satisfies me!
> To be clear, this PR doesn't make releases Jekyll posts but I would like to do this in a later PR.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #170: ACCUMULO-4503 Added blog to project website
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/170#discussion_r85198479
--- Diff: css/accumulo.css ---
@@ -15,37 +15,67 @@
* limitations under the License.
*/
-#nav-logo {
- padding-top: 10px;
- padding-bottom: 10px;
+h1 {
+ font-size: 34px;
+}
+
+h2 {
+ font-size: 28px;
+}
+
+h3 {
+ font-size: 22px;
+}
+
+h4 {
+ font-size: 18px;
+}
+
+h5 {
+ font-size: 16px;
+}
+
+h6 {
+ font-size: 15px;
}
body {
- /* for fixed top navbar */
- padding-top: 70px;
- font-size: 14px;
+ font-size: 14px;
}
-.nav-link {
- padding-top: 20px;
- font-size: 16px;
+code {
+ background-color: #f5f5f5;
+ color: #555;
--- End diff --
Suggest a greenish color here like `#20b2aa;`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #170: ACCUMULO-4503 Added blog to project website
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/accumulo/pull/170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #170: ACCUMULO-4503 Added blog to project website
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on the issue:
https://github.com/apache/accumulo/pull/170
> This is a little nit-picky, I know. If it's something simple that can be changed, I think it would be beneficial.
w.r.t. to blog post links it would be nice to get something settled that will be stable, so the links will be stable over time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #170: ACCUMULO-4503 Added blog to project website
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/170
All looks good to me. I'll let this sit overnight for additional reviews, then merge tomorrow. Thanks, @mikewalch !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #170: ACCUMULO-4503 Added blog to project website
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/170
> For the blog post, could include a link to the original post along with a sentence stating it was copied. This could be at the end of the post.
+1
Not related to this changeset, but we should also make a post on blogs.a.o saying that it is discontinued, pointing people back to accumulo.a.o/blog
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #170: ACCUMULO-4503 Added blog to project website
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/170
To be clear, this PR doesn't make releases Jekyll posts but I would like to do this in a later PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #170: ACCUMULO-4503 Added blog to project website
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the issue:
https://github.com/apache/accumulo/pull/170
@joshelser That looked funny to me, too, until I realized that News activity could include other kinds of posts than blogs, such as the release posts that Apache Fluo is doing.
We can add an additional archive of just the blogs at the root of /blog. That's no big deal.
As for any potential releases feed, we might want to think about doing that as follow-on work later, after we folks get a chance to acclimate to this change and provide feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---