You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "Vi-Ku (via GitHub)" <gi...@apache.org> on 2026/03/30 07:11:30 UTC
[PR] fix(drill-detail): restrict page size options to match defaultPageSize [superset]
Vi-Ku opened a new pull request, #38945:
URL: https://github.com/apache/superset/pull/38945
## Summary
Fixes #36267
The DrillDetailPane Table component uses `defaultPageSize={PAGE_SIZE}` (where `PAGE_SIZE = 50`) but does not pass `pageSizeOptions`, causing the Table to display the default options (`[5, 15, 25, 50, 100]`). Since the server-side pagination always fetches exactly 50 rows per page, these other page size options are misleading and break the pagination display.
## Fix
Pass `pageSizeOptions={[\`${PAGE_SIZE}\`]}` to the Table component so the page size selector only shows 50 — matching the actual server-side page size.
## Testing
- The only change is adding a single prop to `<Table>`. The existing `DrillDetailPane.test.tsx` test suite does not test page size options, and the fix is a pure prop passthrough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(drill-detail): restrict page size options to match defaultPageSize [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #38945:
URL: https://github.com/apache/superset/pull/38945#issuecomment-4164537907
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/38945?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 64.52%. Comparing base ([`d1903af`](https://app.codecov.io/gh/apache/superset/commit/d1903afc69423b22506b2778eed7077b91db56f1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c004504`](https://app.codecov.io/gh/apache/superset/commit/c004504d532317dce8b035d5aa4c56c28bf3171d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 33 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #38945 +/- ##
=======================================
Coverage 64.52% 64.52%
=======================================
Files 2536 2536
Lines 130778 130778
Branches 30347 30347
=======================================
Hits 84380 84380
Misses 44935 44935
Partials 1463 1463
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/38945/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/38945/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.83% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/38945?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(drill-detail): restrict page size options to match defaultPageSize [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #38945:
URL: https://github.com/apache/superset/pull/38945#issuecomment-4434606399
Closed in favor of https://github.com/apache/superset/pull/37975 which seems to do all the right stuff. If anyone finds differently, let's open a new Issue/PR off `master` as it now stands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(drill-detail): restrict page size options to match defaultPageSize [superset]
Posted by "Vi-Ku (via GitHub)" <gi...@apache.org>.
Vi-Ku commented on PR #38945:
URL: https://github.com/apache/superset/pull/38945#issuecomment-4201220552
Hi @hainenber, thanks for pointing that out! I see the existing PRs now:
- **#36273** — Same one-line fix but hardcodes `'50'` as a string literal instead of using the `PAGE_SIZE` constant.
- **#36780** — Changes the global `Table` component defaults, which would affect every Table consumer, not just DrillDetail.
- **#37975** — Adds tests alongside the fix, but the diff is larger.
My PR uses `\`${PAGE_SIZE}\`` so the value stays in sync with the constant (if it ever changes). That said, if one of the other PRs is closer to being merged, I'm happy to close this one — just let me know. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(drill-detail): restrict page size options to match defaultPageSize [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38945:
URL: https://github.com/apache/superset/pull/38945#issuecomment-4152781702
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(drill-detail): restrict page size options to match defaultPageSize [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #38945:
URL: https://github.com/apache/superset/pull/38945#issuecomment-4163587995
@Vi-Ku thanks for your contribution but there are already 3 opening PRs to fix the linked issue. Do you see any missing logics that incentivize this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(drill-detail): restrict page size options to match defaultPageSize [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #38945: fix(drill-detail): restrict page size options to match defaultPageSize
URL: https://github.com/apache/superset/pull/38945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org