You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ak...@apache.org on 2019/06/24 20:07:42 UTC

[incubator-pinot] branch master updated: [TE] Fix doc - add import sql url, disable pinot build (#4357)

This is an automated email from the ASF dual-hosted git repository.

akshayrai09 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 9497a75  [TE] Fix doc - add import sql url, disable pinot build (#4357)
9497a75 is described below

commit 9497a756bfb99f8efff41a02bba3950cd782056c
Author: Akshay Rai <ak...@gmail.com>
AuthorDate: Mon Jun 24 13:07:37 2019 -0700

    [TE] Fix doc - add import sql url, disable pinot build (#4357)
---
 thirdeye/docs/import_sql_metric.rst                            |  7 +++++--
 thirdeye/docs/production.rst                                   |  4 ++--
 thirdeye/install.sh                                            | 10 ++++------
 .../thirdeye-pinot/config/data-sources/data-sources-config.yml |  2 +-
 4 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/thirdeye/docs/import_sql_metric.rst b/thirdeye/docs/import_sql_metric.rst
index bf5743a..f0286e9 100644
--- a/thirdeye/docs/import_sql_metric.rst
+++ b/thirdeye/docs/import_sql_metric.rst
@@ -28,7 +28,10 @@ Run through step 1-2 in :ref:`presto`. or :ref:`mysql`.
 
 **1: Import Metric on Front End**
 
-Click `Create Alert` on top right of the page, click `Import a Metric from SQL` link under `Define detection configuration`.
+Click on this link to import: ``http://localhost:1426/app/#/self-serve/import-sql-metric``
+
+Once the UI is fixed, this link should appear in the create alert page.
+
 Fill in the form which includes the following fields, and click Import Metrics.
  
 ``Table Name``: For Presto, it is the Presto table name, including all schema prefixes. For MySQL it is just the table name.
@@ -56,4 +59,4 @@ The data set name will be ``[source name].[db name].[table name]``. For example,
 And the metric name is just the metric name you set.
 
 Note that this page does not validate that your entry is correct. Try on the Root Cause Analysis page whether you can see the
-metric showing up. If not, please retry entering the form again and the previous entry will be overwritten.
\ No newline at end of file
+metric showing up. If not, please retry entering the form again and the previous entry will be overwritten.
diff --git a/thirdeye/docs/production.rst b/thirdeye/docs/production.rst
index fabc6a0..cecbb91 100644
--- a/thirdeye/docs/production.rst
+++ b/thirdeye/docs/production.rst
@@ -22,6 +22,6 @@
 Production Settings
 ====================
 
-ThirdEye relies on a central meta data store to coordinate its workers and frontend processes. The first step towards moving ThirdEye into production should therefore be the setup of a dedicated (MySQL) database instance. You can use the ``thirdeye-pinot/src/resources/schema/create-schema.sql`` script to create your tables. Then, update the ``thirdeye-pinot/config/persistence.yml`` file with path and credentials. Once you have a dedicated database instance, you can run backend and fronte [...]
+ThirdEye relies on a central meta data store to coordinate its workers and frontend processes. The first step towards moving ThirdEye into production should therefore be the setup of a dedicated (MySQL) database instance. You can use the ``thirdeye-pinot/src/main/resources/schema/create-schema.sql`` script to create your tables. Then, update the ``thirdeye-pinot/config/persistence.yml`` file with path and credentials. Once you have a dedicated database instance, you can run backend and f [...]
 
-The next step could be the configuration of the holiday auto-loader. The holiday auto loader connects to the Google Calendar API. Once you obtain an API token, place it in ``thirdeye-pinot/config/holiday-loader-key.json`` and in ``thirdeye-pinot/config/detector.yml`` set holidayEventsLoader: true. Once the backend worker is restarted, it will periodically update the local cache of holiday events for ThirdEye's detection and Root-Cause Analysis components.
\ No newline at end of file
+The next step could be the configuration of the holiday auto-loader. The holiday auto loader connects to the Google Calendar API. Once you obtain an API token, place it in ``thirdeye-pinot/config/holiday-loader-key.json`` and in ``thirdeye-pinot/config/detector.yml`` set holidayEventsLoader: true. Once the backend worker is restarted, it will periodically update the local cache of holiday events for ThirdEye's detection and Root-Cause Analysis components.
diff --git a/thirdeye/install.sh b/thirdeye/install.sh
index 9d05b97..ae9f697 100755
--- a/thirdeye/install.sh
+++ b/thirdeye/install.sh
@@ -1,11 +1,9 @@
 #!/bin/bash
-echo "*******************************************************"
-echo "Building Pinot components"
-echo "*******************************************************"
 
-cd ..
-mvn install -DskipTests -pl pinot-common,pinot-core,pinot-api -am -Pbuild-shaded-jar || exit 1
-cd thirdeye
+# [Optional] Uncomment below lines to build with latest Pinot changes
+# cd ..
+# mvn install -DskipTests -pl pinot-common,pinot-core,pinot-api -am -Pbuild-shaded-jar || exit 1
+# cd thirdeye
 
 echo "*******************************************************"
 echo "Building ThirdEye"
diff --git a/thirdeye/thirdeye-pinot/config/data-sources/data-sources-config.yml b/thirdeye/thirdeye-pinot/config/data-sources/data-sources-config.yml
index b889767..b8043cb 100644
--- a/thirdeye/thirdeye-pinot/config/data-sources/data-sources-config.yml
+++ b/thirdeye/thirdeye-pinot/config/data-sources/data-sources-config.yml
@@ -210,4 +210,4 @@ dataSourceConfigs:
             timezone: "UTC"
             metrics:
               value: "SUM"
-            dataFile: "hourly.csv"
\ No newline at end of file
+            dataFile: "hourly.csv"


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org