You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by je...@apache.org on 2004/09/23 00:02:13 UTC
cvs commit: httpd-2.0/modules/experimental mod_cache.c
jerenkrantz 2004/09/22 15:02:13
Modified: modules/experimental mod_cache.c
Log:
Fix up some comments in CACHE_SAVE filter and fix a minor style nit.
No functional changes.
Revision Changes Path
1.91 +10 -5 httpd-2.0/modules/experimental/mod_cache.c
Index: mod_cache.c
===================================================================
RCS file: /home/cvs/httpd-2.0/modules/experimental/mod_cache.c,v
retrieving revision 1.90
retrieving revision 1.91
diff -u -u -r1.90 -r1.91
--- mod_cache.c 21 Sep 2004 22:56:23 -0000 1.90
+++ mod_cache.c 22 Sep 2004 22:02:13 -0000 1.91
@@ -236,12 +236,15 @@
* ---------------
*
* Decide whether or not this content should be cached.
- * If we decide no it should:
+ * If we decide no it should not:
* remove the filter from the chain
* If we decide yes it should:
- * pass the data to the storage manager
- * pass the data to the next filter (the network)
- *
+ * Have we already started saving the response?
+ * If we have started, pass the data to the storage manager via store_body
+ * Otherwise:
+ * Check to see if we *can* save this particular response.
+ * If we can, call cache_create_entity() and save the headers and body
+ * Finally, pass the data to the next filter (the network or whatever)
*/
static int cache_save_filter(ap_filter_t *f, apr_bucket_brigade *in)
@@ -447,6 +450,8 @@
/* ship the data up the stack */
return ap_pass_brigade(f->next, in);
}
+
+ /* Make it so that we don't execute this path again. */
cache->in_checked = 1;
/* Set the content length if known.
@@ -629,7 +634,7 @@
info->content_type = apr_pstrdup(r->pool, r->content_type);
info->etag = apr_pstrdup(r->pool, etag);
info->lastmods = apr_pstrdup(r->pool, lastmods);
- info->filename = apr_pstrdup(r->pool, r->filename );
+ info->filename = apr_pstrdup(r->pool, r->filename);
/*
* Write away header information to cache.